helm-charts: support pre-release suffix as well#463
helm-charts: support pre-release suffix as well#463catpineapple merged 1 commit intoapache:masterfrom
Conversation
Without this, eks or gke versions will not be considered as valid versions
|
Hi @catpineapple, sorry to bother you. I saw that you reviewed and merged the previous PRs related to the |
|
Thank you very much for your submission. This is a thoughtful change. Will this change affect operation on self-built or open-source Kubernetes? Have you conducted any related tests? |
|
@catpineapple thanks for the quick response.
This change does not affect any operation neither in self-built or kubernetes. It is only a fix in the kuberentes version constraint (the Ref: https://helm.sh/docs/v3/topics/charts/#the-kubeversion-field |
|
We are being affected by this same issue. |
|
friendly ping @catpineapple |
|
desperate ping @catpineapple |
|
@catpineapple @matiasbertani When are you planned to give this in chart release. Last release happen on sep. Can you do one release to solve this? |
Without it eks or gke versions will not be considered as valid versions
Related to #401
What problem does this PR solve?
Helm relies on Masterminds/semver for version comparison. According to both the Helm docs and the SemVer README (see the "Checking Version Constraints" section), version ranges do not match pre-release versions unless the constraint explicitly allows them.
EKS (and GKE) Kubernetes versions always include a pre-release suffix, e.g.:
v1.34.1-eks-3025e55. So, with a constraint like>= 1.19, SemVer will not consider pre-release versions valid, so Helm rejects the chart even though the Kubernetes version is technically higher.The SemVer documentation explains that to include pre-releases in a version range, you must add a
-0suffix:>= 1.19.0-0After changing the chart’s kubeVersion to include
.0-0, Helm correctly accepted the EKS version.Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)