Skip to content

Comments

[chore](macOS) Specify the version of LLVM for Homebrew to install it#17945

Merged
BiteTheDDDDt merged 1 commit intoapache:masterfrom
adonis0147:llvm
Mar 22, 2023
Merged

[chore](macOS) Specify the version of LLVM for Homebrew to install it#17945
BiteTheDDDDt merged 1 commit intoapache:masterfrom
adonis0147:llvm

Conversation

@adonis0147
Copy link
Contributor

@adonis0147 adonis0147 commented Mar 20, 2023

Proposed changes

Issue Number: close #xxx

Problem summary

Clang 16 was released last week and we haven't ported the codebase to it. If Homebrew bumped the version of LLVM, our workflows would fail.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the kind/docs Categorizes issue or PR as related to documentation. label Mar 20, 2023
@adonis0147
Copy link
Contributor Author

adonis0147 commented Mar 20, 2023

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 20, 2023 •
edited
Loading

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 33.81 seconds
stream load tsv: 473 seconds loaded 74807831229 Bytes, about 150 MB/s
stream load json: 25 seconds loaded 2358488459 Bytes, about 89 MB/s
stream load orc: 75 seconds loaded 1101869774 Bytes, about 14 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230321201914_clickbench_pr_118143.html

@adonis0147
Copy link
Contributor Author

adonis0147 commented Mar 20, 2023

run p0

@adonis0147
Copy link
Contributor Author

adonis0147 commented Mar 20, 2023

run buildall

@adonis0147
Copy link
Contributor Author

adonis0147 commented Mar 20, 2023

run buildall

@adonis0147
Copy link
Contributor Author

adonis0147 commented Mar 20, 2023

run p0

1 similar comment
@adonis0147
Copy link
Contributor Author

adonis0147 commented Mar 20, 2023

run p0

@adonis0147
Copy link
Contributor Author

adonis0147 commented Mar 20, 2023

run buildall

@adonis0147
Copy link
Contributor Author

adonis0147 commented Mar 21, 2023

run p0

@adonis0147
Copy link
Contributor Author

adonis0147 commented Mar 21, 2023

run buildall

@adonis0147
Copy link
Contributor Author

adonis0147 commented Mar 21, 2023

run buildall

1 similar comment
@adonis0147
Copy link
Contributor Author

adonis0147 commented Mar 21, 2023

run buildall

BiteTheDDDDt
BiteTheDDDDt approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BiteTheDDDDt BiteTheDDDDt merged commit d4ca7cb into apache:master Mar 22, 2023
@adonis0147 adonis0147 deleted the llvm branch March 22, 2023 03:11
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
@adonis0147 @gnehil
[chore](macOS) Specify the version of LLVM for Homebrew to install it (…
0e02da1 
…apache#17945)

Clang 16 was released last week and we haven't ported the codebase to it. If Homebrew bumped the version of LLVM, our workflows would fail.
adonis0147 added a commit to adonis0147/doris that referenced this pull request Apr 24, 2023
@adonis0147
[chore](macOS) Specify the version of LLVM for Homebrew to install it (…
9eddb53 
…apache#17945)

Clang 16 was released last week and we haven't ported the codebase to it. If Homebrew bumped the version of LLVM, our workflows would fail.
@adonis0147 adonis0147 mentioned this pull request Apr 24, 2023
Merged
5 tasks
adonis0147 added a commit that referenced this pull request Apr 24, 2023
@adonis0147
[chore](macOS) Use LLVM Clang by default (#19007)
cf16cdf 
Backport:
1. [chore](macOS) Use LLVM Clang by default #17292
2. [chore](workflow) Fix the workflow BE UT (macOS) #17403
3. [chore](macOS) Disable detect_container_overflow at BE startup #17514
4. [chore](macOS) Specify the version of LLVM for Homebrew to install it #17945
mongo360 pushed a commit to mongo360/doris that referenced this pull request Jul 12, 2023
@adonis0147
[chore](macOS) Use LLVM Clang by default (apache#19007)
14905c6 
Backport:
1. [chore](macOS) Use LLVM Clang by default apache#17292
2. [chore](workflow) Fix the workflow BE UT (macOS) apache#17403
3. [chore](macOS) Disable detect_container_overflow at BE startup apache#17514
4. [chore](macOS) Specify the version of LLVM for Homebrew to install it apache#17945
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

Assignees

No one assigned

Labels

dev/1.2.5-merged kind/docs Categorizes issue or PR as related to documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adonis0147 @hello-stephen @BiteTheDDDDt