[Fix](point query) fix memleak by increasing scanReplicaIds when using prepared statement#28184
Merged
eldenmoon merged 1 commit intoapache:masterfrom Dec 8, 2023
Merged
Conversation
…ing prepared statement OlapScanNode should release memory for `scanReplicaIds`
Member
Author
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
xiaokang
changed the title
scanReplicaIds when us…scanReplicaIds when using prepared statement
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
XuJianxu
pushed a commit
to XuJianxu/doris
that referenced
this pull request
Dec 14, 2023
…ing prepared statement (apache#28184) OlapScanNode should release memory for `scanReplicaIds`
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Dec 19, 2023
…ing prepared statement (apache#28184) OlapScanNode should release memory for `scanReplicaIds`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ing prepared statement
OlapScanNode should release memory for
scanReplicaIdsProposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...