[branch-2.0](publish version) fix publish version failed but return ok #28425#28791
Conversation
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
pick: #28424, #28425
BUG: be publish version failed (TxnManager::publish_txn), but the response rpc return status ok. When fe receive the rpc, since its status code is ok, then fe will remove the publish version task. Later fe will no send be retry request. Then BE will not retry publish this txn.
FIX: If TxnManager::publish_txn failed, the reponse rpc should return error.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...