[fix](insert-into) fix insert into lose data#29802
Merged
dataroaring merged 2 commits intoapache:masterfrom Jan 10, 2024
sollhui:insert_into_lose_data
Merged
[fix](insert-into) fix insert into lose data#29802dataroaring merged 2 commits intoapache:masterfrom sollhui:insert_into_lose_data
dataroaring merged 2 commits intoapache:masterfrom
sollhui:insert_into_lose_data
Conversation
Contributor
Author
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
liaoxin01
reviewed
Jan 10, 2024
Contributor
|
Please add a description of the PR. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
TPC-H: Total hot run time: 38515 ms |
TPC-DS: Total hot run time: 179239 ms |
ClickBench: Total hot run time: 31 s |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
yiguolei
pushed a commit
that referenced
this pull request
Jan 11, 2024
yiguolei
pushed a commit
that referenced
this pull request
Jan 12, 2024
16 tasks
liaoxin01
pushed a commit
that referenced
this pull request
Aug 14, 2025
### What problem does this PR solve? Issue Number: DORIS-20541 Related PR: #29802 Problem Summary: Fix an issue where the scanned rows and loaded bytes metrics were not updated progressively in the FE. Although the BE periodically reports execution status, the FE was ignoring these reports due to a change introduced in PR #29802, which skips processing reports without the isDone flag. This fix ensures that intermediate execution reports are processed, allowing progressive updates of scanned rows and loaded bytes during query execution.
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Aug 14, 2025
…e#54606) Issue Number: DORIS-20541 Related PR: apache#29802 Problem Summary: Fix an issue where the scanned rows and loaded bytes metrics were not updated progressively in the FE. Although the BE periodically reports execution status, the FE was ignoring these reports due to a change introduced in PR apache#29802, which skips processing reports without the isDone flag. This fix ensures that intermediate execution reports are processed, allowing progressive updates of scanned rows and loaded bytes during query execution.
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Aug 14, 2025
…e#54606) Issue Number: DORIS-20541 Related PR: apache#29802 Problem Summary: Fix an issue where the scanned rows and loaded bytes metrics were not updated progressively in the FE. Although the BE periodically reports execution status, the FE was ignoring these reports due to a change introduced in PR apache#29802, which skips processing reports without the isDone flag. This fix ensures that intermediate execution reports are processed, allowing progressive updates of scanned rows and loaded bytes during query execution.
dataroaring
pushed a commit
that referenced
this pull request
Aug 15, 2025
…ively #54606 (#54790) Backport #54606 ### What problem does this PR solve? Issue Number: DORIS-20541 Related PR: #29802 Problem Summary: Fix an issue where the scanned rows and loaded bytes metrics were not updated progressively in the FE. Although the BE periodically reports execution status, the FE was ignoring these reports due to a change introduced in PR #29802, which skips processing reports without the isDone flag. This fix ensures that intermediate execution reports are processed, allowing progressive updates of scanned rows and loaded bytes during query execution.
morrySnow
pushed a commit
that referenced
this pull request
Aug 15, 2025
…ively #54606 (#54787) Backport #54606 ### What problem does this PR solve? Issue Number: DORIS-20541 Related PR: #29802 Problem Summary: Fix an issue where the scanned rows and loaded bytes metrics were not updated progressively in the FE. Although the BE periodically reports execution status, the FE was ignoring these reports due to a change introduced in PR #29802, which skips processing reports without the isDone flag. This fix ensures that intermediate execution reports are processed, allowing progressive updates of scanned rows and loaded bytes during query execution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
There are some periodic reports during the load process, and the reports from the intermediate process may be concurrent with the last report. The last report causes the counter to decrease to zero, but it is possible that the report without commit-info triggered the commit operation, resulting in the data not being published.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...