[fix](mtmv) Fix partition mv rewrite result wrong#35236
Merged
morrySnow merged 6 commits intoapache:masterfrom May 29, 2024
Merged
[fix](mtmv) Fix partition mv rewrite result wrong#35236morrySnow merged 6 commits intoapache:masterfrom
morrySnow merged 6 commits intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41096 ms |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41816 ms |
TPC-DS: Total hot run time: 172210 ms |
ClickBench: Total hot run time: 30.99 s |
seawinde
force-pushed
the
fix_partition_mv_rewrite_result_wrong
branch
2 times, most recently
from
b252757 to
cfb4a43
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40832 ms |
TPC-DS: Total hot run time: 168496 ms |
ClickBench: Total hot run time: 30.42 s |
morrySnow
reviewed
May 27, 2024
|
|
||
| sleep(5000) | ||
| sql "SET enable_materialized_view_rewrite=false" | ||
| order_qt_query_5_0_before "${all_partition_sql}" |
Contributor
There was a problem hiding this comment.
use meaningful case name
| (1, 2, 3, 4, 5.5, 6.5, 7.5, 8.5, 'o', 'k', '2023-10-21', '2023-10-21', '2023-10-21', 'a', 'b', 'yyyyyyyyy'); | ||
| """ | ||
|
|
||
| sleep(5000) |
Contributor
There was a problem hiding this comment.
do not use sleep, real check what u want to wait
seawinde
force-pushed
the
fix_partition_mv_rewrite_result_wrong
branch
from
4bc1130 to
aeb9702
Compare
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41790 ms |
TPC-DS: Total hot run time: 171596 ms |
ClickBench: Total hot run time: 30.76 s |
Contributor
|
run feut |
seawinde
force-pushed
the
fix_partition_mv_rewrite_result_wrong
branch
from
8867d3f to
6ec923e
Compare
Contributor
Author
|
run buildall |
morrySnow
approved these changes
May 28, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
…w if related baseTable add partition
seawinde
force-pushed
the
fix_partition_mv_rewrite_result_wrong
branch
from
6ec923e to
0b55c46
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41875 ms |
TPC-DS: Total hot run time: 168944 ms |
ClickBench: Total hot run time: 30.3 s |
zddr
approved these changes
May 29, 2024
yiguolei
pushed a commit
that referenced
this pull request
May 29, 2024
this is brought by #33800 if mv is partitioned materialzied view, the data will be wrong by using the hited materialized view when the paritions in related base partiton table are deleted, created and so on. this fix the problem. if **SET enable_materialized_view_union_rewrite=true;** this will use the materializd view and make sure the data is corrent if **SET enable_materialized_view_union_rewrite=false;** this will query base table directly to make sure the data is right
dataroaring
pushed a commit
that referenced
this pull request
May 31, 2024
this is brought by #33800 if mv is partitioned materialzied view, the data will be wrong by using the hited materialized view when the paritions in related base partiton table are deleted, created and so on. this fix the problem. if **SET enable_materialized_view_union_rewrite=true;** this will use the materializd view and make sure the data is corrent if **SET enable_materialized_view_union_rewrite=false;** this will query base table directly to make sure the data is right
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
this is brought by #33800
if mv is partitioned materialzied view,
the data will be wrong by using the hited materialized view when the paritions in related base partiton table are deleted, created and so on.
this fix the problem.
if SET enable_materialized_view_union_rewrite=true; this will use the materializd view and make sure the data is corrent
if SET enable_materialized_view_union_rewrite=false; this will query base table directly to make sure the data is right
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...