Skip to content

[fix](memory allocate) Fix reinitialization of TabletReader#36314

Merged
dataroaring merged 2 commits intoapache:masterfrom
zhiqiang-hhhh:fix-reinit-tablet-reader
Jun 14, 2024
Merged

[fix](memory allocate) Fix reinitialization of TabletReader#36314
dataroaring merged 2 commits intoapache:masterfrom
zhiqiang-hhhh:fix-reinit-tablet-reader

Conversation

@zhiqiang-hhhh
Copy link
Contributor

@zhiqiang-hhhh zhiqiang-hhhh commented Jun 14, 2024

ASSIGN_STATUS_IF_CATCH_EXCEPTION will convert error code from MEM_ALLOC_FAILED to MEM_LIMIT_EXCEEDED, this will lead to problem like below:

F20240614 16:07:18.529981 3400047 delete_handler.cpp:388] Check failed: !_is_inited reinitialize delete handler.
*** Check failure stack trace: ***
    @     0x561cdc597926  google::LogMessage::SendToLog()
    @     0x561cdc594370  google::LogMessage::Flush()
    @     0x561cdc598169  google::LogMessageFatal::~LogMessageFatal()
    @     0x561cacf6ba70  doris::DeleteHandler::init()
    @     0x561caf6e9298  doris::TabletReader::_init_delete_condition()
    @     0x561caf6e257c  doris::TabletReader::_init_params()
    @     0x561caf6e1a09  doris::TabletReader::init()
    @     0x561cd847917f  doris::vectorized::BlockReader::init()
    @     0x561cdbc466a4  doris::vectorized::NewOlapScanner::open()
    @     0x561cc3a1b623  doris::vectorized::ScannerScheduler::_scanner_scan()
    @     0x561cc3a1fae1  _ZZZZN5doris10vectorized16ScannerScheduler6submitESt10shared_ptrINS0_14ScannerContextEES2_INS0_8ScanTaskEEENK3$_1clEvENKUlvE_clEvENKUlvE_clEv
    @     0x561cc3a1f554  _ZZZN5doris10vectorized16ScannerScheduler6submitESt10shared_ptrINS0_14ScannerContextEES2_INS0_8ScanTaskEEENK3$_1clEvENKUlvE_clEv
    @     0x561cc3a1f3c5  _ZSt13__invoke_implIvRZZN5doris10vectorized16ScannerScheduler6submitESt10shared_ptrINS1_14ScannerContextEES3_INS1_8ScanTaskEEENK3$_1clEvEUlvE_JEET_St14__invoke_otherOT0_DpOT1_
    @     0x561cc3a1f365  _ZSt10__invoke_rIvRZZN5doris10vectorized16ScannerScheduler6submitESt10shared_ptrINS1_14ScannerContextEES3_INS1_8ScanTaskEEENK3$_1clEvEUlvE_JEENSt9enable_ifIX16is_invocable_r_vIT_T0_DpT1_EESC_E4typeEOSD_DpOSE_
    @     0x561cc3a1f18d  _ZNSt17_Function_handlerIFvvEZZN5doris10vectorized16ScannerScheduler6submitESt10shared_ptrINS2_14ScannerContextEES4_INS2_8ScanTaskEEENK3$_1clEvEUlvE_E9_M_invokeERKSt9_Any_data
    @     0x561cac9f8023  std::function<>::operator()()
    @     0x561cc3a333b5  _ZZN5doris10vectorized23SimplifiedScanScheduler16submit_scan_taskENS0_18SimplifiedScanTaskEENKUlvE_clEv
    @     0x561cc3a33395  _ZSt13__invoke_implIvRZN5doris10vectorized23SimplifiedScanScheduler16submit_scan_taskENS1_18SimplifiedScanTaskEEUlvE_JEET_St14__invoke_otherOT0_DpOT1_
    @     0x561cc3a33335  _ZSt10__invoke_rIvRZN5doris10vectorized23SimplifiedScanScheduler16submit_scan_taskENS1_18SimplifiedScanTaskEEUlvE_JEENSt9enable_ifIX16is_invocable_r_vIT_T0_DpT1_EES7_E4typeEOS8_DpOS9_
    @     0x561cc3a3312d  _ZNSt17_Function_handlerIFvvEZN5doris10vectorized23SimplifiedScanScheduler16submit_scan_taskENS2_18SimplifiedScanTaskEEUlvE_E9_M_invokeERKSt9_Any_data
    @     0x561cac9f8023  std::function<>::operator()()
    @     0x561cb095d4e9  doris::FunctionRunnable::run()
    @     0x561cb094913e  doris::ThreadPool::dispatch_thread()
    @     0x561cb0970564  std::__invoke_impl<>()
    @     0x561cb097043d  std::__invoke<>()
    @     0x561cb09703c5  _ZNSt5_BindIFMN5doris10ThreadPoolEFvvEPS1_EE6__callIvJEJLm0EEEET_OSt5tupleIJDpT0_EESt12_Index_tupleIJXspT1_EEE
    @     0x561cb097026e  std::_Bind<>::operator()<>()
    @     0x561cb0970185  std::__invoke_impl<>()
    @     0x561cb0970125  _ZSt10__invoke_rIvRSt5_BindIFMN5doris10ThreadPoolEFvvEPS2_EEJEENSt9enable_ifIX16is_invocable_r_vIT_T0_DpT1_EESA_E4typeEOSB_DpOSC_
    @     0x561cb096fdcd  std::_Function_handler<>::_M_invoke()
    @     0x561cac9f8023  std::function<>::operator()()
    @     0x561cb091666c  doris::Thread::supervise_thread()

@doris-robot
Copy link

doris-robot commented Jun 14, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zhiqiang-hhhh zhiqiang-hhhh changed the title [fix](memory allocate) Fix reinitialization of BlockReader [fix](memory allocate) Fix reinitialization of TabletReader Jun 14, 2024
@zhiqiang-hhhh
Copy link
Contributor Author

zhiqiang-hhhh commented Jun 14, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Jun 14, 2024

TeamCity be ut coverage result:
Function Coverage: 36.45% (8988/24661)
Line Coverage: 28.02% (73677/262936)
Region Coverage: 27.49% (38276/139213)
Branch Coverage: 24.19% (19515/80660)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1d078db7ff5656e784d89d2f429c4af5d444e749_1d078db7ff5656e784d89d2f429c4af5d444e749/report/index.html

@doris-robot
Copy link

doris-robot commented Jun 14, 2024

TPC-H: Total hot run time: 39503 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1d078db7ff5656e784d89d2f429c4af5d444e749, data reload: false

------ Round 1 ----------------------------------
q1	17641	4337	4289	4289
q2	2029	194	189	189
q3	10445	1102	1189	1102
q4	10190	786	749	749
q5	7567	2619	2639	2619
q6	217	135	134	134
q7	986	595	592	592
q8	9213	2041	2069	2041
q9	8978	6452	6482	6452
q10	8944	3796	3706	3706
q11	448	242	242	242
q12	459	233	220	220
q13	17761	2990	2976	2976
q14	258	220	217	217
q15	524	477	494	477
q16	523	370	381	370
q17	958	697	673	673
q18	7989	7298	7388	7298
q19	4702	1567	1456	1456
q20	654	321	322	321
q21	4910	3106	3051	3051
q22	383	329	330	329
Total cold run time: 115779 ms
Total hot run time: 39503 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4402	4218	4206	4206
q2	377	260	257	257
q3	2979	2719	2969	2719
q4	1999	1723	1746	1723
q5	5594	5489	5517	5489
q6	230	127	129	127
q7	2165	1801	1856	1801
q8	3260	3428	3419	3419
q9	8674	8623	8782	8623
q10	4097	3924	3764	3764
q11	609	475	467	467
q12	795	635	642	635
q13	17040	3194	3144	3144
q14	301	269	285	269
q15	545	472	493	472
q16	495	420	436	420
q17	1804	1517	1480	1480
q18	7935	8070	7715	7715
q19	1809	1665	1566	1566
q20	2061	1904	1881	1881
q21	5098	4938	4760	4760
q22	625	549	515	515
Total cold run time: 72894 ms
Total hot run time: 55452 ms

@doris-robot
Copy link

doris-robot commented Jun 14, 2024

TPC-DS: Total hot run time: 173785 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1d078db7ff5656e784d89d2f429c4af5d444e749, data reload: false

query1	921	382	385	382
query2	6458	2359	2417	2359
query3	6645	205	204	204
query4	19787	17274	17263	17263
query5	3595	458	466	458
query6	243	152	151	151
query7	4573	299	287	287
query8	320	298	293	293
query9	8481	2403	2387	2387
query10	582	292	293	292
query11	10701	10101	9973	9973
query12	117	85	82	82
query13	1631	357	360	357
query14	9998	7674	7648	7648
query15	243	186	189	186
query16	7846	258	255	255
query17	1948	530	517	517
query18	1994	267	288	267
query19	199	155	148	148
query20	92	82	81	81
query21	211	132	126	126
query22	4530	4214	4185	4185
query23	33705	33502	33619	33502
query24	11222	3055	2944	2944
query25	611	365	377	365
query26	925	155	158	155
query27	2385	332	323	323
query28	6714	2119	2121	2119
query29	896	635	632	632
query30	226	152	151	151
query31	946	789	760	760
query32	93	58	58	58
query33	749	285	274	274
query34	1091	485	477	477
query35	724	638	645	638
query36	1120	949	964	949
query37	146	74	72	72
query38	2919	2824	2809	2809
query39	924	844	847	844
query40	220	129	131	129
query41	59	60	58	58
query42	115	106	103	103
query43	592	583	531	531
query44	1260	729	733	729
query45	208	162	173	162
query46	1086	731	730	730
query47	1868	1782	1790	1782
query48	371	299	306	299
query49	868	415	421	415
query50	765	394	399	394
query51	6788	6662	6645	6645
query52	111	90	95	90
query53	355	299	292	292
query54	911	442	447	442
query55	75	77	71	71
query56	288	267	280	267
query57	1102	1062	1047	1047
query58	255	253	248	248
query59	3255	3288	2982	2982
query60	309	283	306	283
query61	112	110	105	105
query62	615	444	446	444
query63	321	292	287	287
query64	8932	2356	1809	1809
query65	3193	3093	3119	3093
query66	783	335	327	327
query67	15489	14893	14747	14747
query68	7811	537	531	531
query69	687	466	388	388
query70	1169	1119	1025	1025
query71	523	261	267	261
query72	8923	5275	5419	5275
query73	814	322	319	319
query74	5871	5412	5432	5412
query75	5014	2655	2659	2655
query76	4303	943	885	885
query77	765	293	286	286
query78	10459	10050	9712	9712
query79	4038	514	519	514
query80	1016	464	464	464
query81	557	219	224	219
query82	782	105	105	105
query83	380	170	170	170
query84	276	88	95	88
query85	1258	269	269	269
query86	439	323	303	303
query87	3239	3037	3094	3037
query88	4643	2356	2330	2330
query89	497	383	384	383
query90	1913	196	189	189
query91	128	99	99	99
query92	65	49	49	49
query93	4852	501	500	500
query94	1184	185	193	185
query95	406	309	315	309
query96	606	271	261	261
query97	3165	3085	3050	3050
query98	223	198	194	194
query99	1205	834	851	834
Total cold run time: 284028 ms
Total hot run time: 173785 ms

@doris-robot
Copy link

doris-robot commented Jun 14, 2024

ClickBench: Total hot run time: 29.88 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1d078db7ff5656e784d89d2f429c4af5d444e749, data reload: false

query1	0.04	0.03	0.04
query2	0.08	0.04	0.03
query3	0.24	0.05	0.04
query4	1.68	0.06	0.07
query5	0.51	0.47	0.48
query6	1.15	0.74	0.72
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.54	0.50	0.50
query10	0.53	0.55	0.54
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.60	0.60	0.61
query14	0.78	0.78	0.81
query15	0.85	0.81	0.81
query16	0.37	0.34	0.36
query17	0.99	1.01	1.03
query18	0.21	0.24	0.27
query19	1.77	1.67	1.69
query20	0.01	0.01	0.01
query21	15.41	0.66	0.65
query22	4.67	7.98	1.31
query23	18.28	1.41	1.34
query24	2.18	0.21	0.23
query25	0.16	0.07	0.08
query26	0.25	0.18	0.17
query27	0.08	0.08	0.08
query28	13.24	1.00	0.98
query29	12.63	3.26	3.26
query30	0.25	0.07	0.06
query31	2.86	0.39	0.38
query32	3.30	0.46	0.46
query33	2.83	2.90	2.94
query34	17.19	4.39	4.40
query35	4.48	4.45	4.49
query36	0.63	0.48	0.46
query37	0.18	0.15	0.15
query38	0.15	0.15	0.14
query39	0.05	0.04	0.04
query40	0.18	0.13	0.14
query41	0.10	0.04	0.05
query42	0.05	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 109.91 s
Total hot run time: 29.88 s

xinyiZzz
xinyiZzz approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@xinyiZzz xinyiZzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jun 14, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2024

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit ff99e68 into apache:master Jun 14, 2024
@zhiqiang-hhhh zhiqiang-hhhh deleted the fix-reinit-tablet-reader branch June 15, 2024 05:22
dataroaring pushed a commit that referenced this pull request Jun 21, 2024
@zhiqiang-hhhh @dataroaring
[fix](memory allocate) Fix reinitialization of TabletReader (#36314)
c74f8b2 
`ASSIGN_STATUS_IF_CATCH_EXCEPTION` will convert error code from
`MEM_ALLOC_FAILED` to `MEM_LIMIT_EXCEEDED`, this will lead to problem
like below:

```text
F20240614 16:07:18.529981 3400047 delete_handler.cpp:388] Check failed: !_is_inited reinitialize delete handler.
*** Check failure stack trace: ***
    @     0x561cdc597926  google::LogMessage::SendToLog()
    @     0x561cdc594370  google::LogMessage::Flush()
    @     0x561cdc598169  google::LogMessageFatal::~LogMessageFatal()
    @     0x561cacf6ba70  doris::DeleteHandler::init()
    @     0x561caf6e9298  doris::TabletReader::_init_delete_condition()
    @     0x561caf6e257c  doris::TabletReader::_init_params()
    @     0x561caf6e1a09  doris::TabletReader::init()
    @     0x561cd847917f  doris::vectorized::BlockReader::init()
    @     0x561cdbc466a4  doris::vectorized::NewOlapScanner::open()
    @     0x561cc3a1b623  doris::vectorized::ScannerScheduler::_scanner_scan()
    @     0x561cc3a1fae1  _ZZZZN5doris10vectorized16ScannerScheduler6submitESt10shared_ptrINS0_14ScannerContextEES2_INS0_8ScanTaskEEENK3$_1clEvENKUlvE_clEvENKUlvE_clEv
    @     0x561cc3a1f554  _ZZZN5doris10vectorized16ScannerScheduler6submitESt10shared_ptrINS0_14ScannerContextEES2_INS0_8ScanTaskEEENK3$_1clEvENKUlvE_clEv
    @     0x561cc3a1f3c5  _ZSt13__invoke_implIvRZZN5doris10vectorized16ScannerScheduler6submitESt10shared_ptrINS1_14ScannerContextEES3_INS1_8ScanTaskEEENK3$_1clEvEUlvE_JEET_St14__invoke_otherOT0_DpOT1_
    @     0x561cc3a1f365  _ZSt10__invoke_rIvRZZN5doris10vectorized16ScannerScheduler6submitESt10shared_ptrINS1_14ScannerContextEES3_INS1_8ScanTaskEEENK3$_1clEvEUlvE_JEENSt9enable_ifIX16is_invocable_r_vIT_T0_DpT1_EESC_E4typeEOSD_DpOSE_
    @     0x561cc3a1f18d  _ZNSt17_Function_handlerIFvvEZZN5doris10vectorized16ScannerScheduler6submitESt10shared_ptrINS2_14ScannerContextEES4_INS2_8ScanTaskEEENK3$_1clEvEUlvE_E9_M_invokeERKSt9_Any_data
    @     0x561cac9f8023  std::function<>::operator()()
    @     0x561cc3a333b5  _ZZN5doris10vectorized23SimplifiedScanScheduler16submit_scan_taskENS0_18SimplifiedScanTaskEENKUlvE_clEv
    @     0x561cc3a33395  _ZSt13__invoke_implIvRZN5doris10vectorized23SimplifiedScanScheduler16submit_scan_taskENS1_18SimplifiedScanTaskEEUlvE_JEET_St14__invoke_otherOT0_DpOT1_
    @     0x561cc3a33335  _ZSt10__invoke_rIvRZN5doris10vectorized23SimplifiedScanScheduler16submit_scan_taskENS1_18SimplifiedScanTaskEEUlvE_JEENSt9enable_ifIX16is_invocable_r_vIT_T0_DpT1_EES7_E4typeEOS8_DpOS9_
    @     0x561cc3a3312d  _ZNSt17_Function_handlerIFvvEZN5doris10vectorized23SimplifiedScanScheduler16submit_scan_taskENS2_18SimplifiedScanTaskEEUlvE_E9_M_invokeERKSt9_Any_data
    @     0x561cac9f8023  std::function<>::operator()()
    @     0x561cb095d4e9  doris::FunctionRunnable::run()
    @     0x561cb094913e  doris::ThreadPool::dispatch_thread()
    @     0x561cb0970564  std::__invoke_impl<>()
    @     0x561cb097043d  std::__invoke<>()
    @     0x561cb09703c5  _ZNSt5_BindIFMN5doris10ThreadPoolEFvvEPS1_EE6__callIvJEJLm0EEEET_OSt5tupleIJDpT0_EESt12_Index_tupleIJXspT1_EEE
    @     0x561cb097026e  std::_Bind<>::operator()<>()
    @     0x561cb0970185  std::__invoke_impl<>()
    @     0x561cb0970125  _ZSt10__invoke_rIvRSt5_BindIFMN5doris10ThreadPoolEFvvEPS2_EEJEENSt9enable_ifIX16is_invocable_r_vIT_T0_DpT1_EESA_E4typeEOSB_DpOSC_
    @     0x561cb096fdcd  std::_Function_handler<>::_M_invoke()
    @     0x561cac9f8023  std::function<>::operator()()
    @     0x561cb091666c  doris::Thread::supervise_thread()
```
@bobhan1 bobhan1 mentioned this pull request Jul 1, 2024
Merged
dataroaring pushed a commit that referenced this pull request Jul 2, 2024
@bobhan1
[Fix](Scanner) Fix reinitialization of TabletReader (#37059)
3eda6b0 
## Proposed changes

```
F20240628 01:49:16.382710 4183685 delete_handler.cpp:388] Check failed: !_is_inited reinitialize delete handler.
*** Check failure stack trace: ***
    @     0x55700470e3c6  google::LogMessage::SendToLog()
    @     0x55700470ae10  google::LogMessage::Flush()
    @     0x55700470ec09  google::LogMessageFatal::~LogMessageFatal()
    @     0x556fccf40e64  doris::DeleteHandler::init()
    @     0x556fcff46678  doris::TabletReader::_init_delete_condition()
    @     0x556fcff3a2dd  doris::TabletReader::_init_params()
    @     0x556fcff39432  doris::TabletReader::init()
    @     0x556fffb8c2dd  doris::vectorized::BlockReader::init()
    @     0x557002cca96a  doris::vectorized::NewOlapScanner::open()
    @     0x556fe892d565  doris::vectorized::ScannerScheduler::_scanner_scan()
    @     0x556fe8931a0f  _ZNSt17_Function_handlerIFvvEZZN5doris10vectorized16ScannerScheduler6submitESt10shared_ptrINS2_14ScannerContextEES4_INS2_8ScanTaskEEENK3$_1clEvEUlvE_E9_M_invokeERKSt9_Any_data
    @     0x556fd0ed95dc  doris::ThreadPool::dispatch_thread()
    @     0x556fd0eb1288  doris::Thread::supervise_thread()
    @     0x7f95143b5609  start_thread
    @     0x7f9514662133  clone
    @              (nil)  (unknown)
*** Query id: c389fc2a1ff6473c-a06f032b8970810c ***
*** is nereids: 1 ***
*** tablet id: 0 ***
*** Aborted at 1719510556 (unix time) try "date -d @1719510556" if you are using GNU date ***
*** Current BE git commitID: b13c17d ***
*** SIGABRT unknown detail explain (@0x3fca33) received by PID 4180531 (TID 4183685 OR 0x7f89734a5700) from PID 4180531; stack trace: ***
 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /home/zcp/repo_center/doris_master/doris/be/src/common/signal_handler.h:421
 1# 0x00007F9514586090 in /lib/x86_64-linux-gnu/libc.so.6
 2# raise at ../sysdeps/unix/sysv/linux/raise.c:51
 3# abort at /build/glibc-SzIz7B/glibc-2.31/stdlib/abort.c:81
 4# 0x0000557004718C9D in /mnt/hdd01/ci/compatibility-deploy/be/lib/doris_be
 5# 0x000055700470B2DA in /mnt/hdd01/ci/compatibility-deploy/be/lib/doris_be
 6# google::LogMessage::SendToLog() in /mnt/hdd01/ci/compatibility-deploy/be/lib/doris_be
 7# google::LogMessage::Flush() in /mnt/hdd01/ci/compatibility-deploy/be/lib/doris_be
 8# google::LogMessageFatal::~LogMessageFatal() in /mnt/hdd01/ci/compatibility-deploy/be/lib/doris_be
 9# doris::DeleteHandler::init(std::shared_ptr<doris::TabletSchema>, std::vector<std::shared_ptr<doris::RowsetMeta>, std::allocator<std::shared_ptr<doris::RowsetMeta> > > const&, long, bool) at /home/zcp/repo_center/doris_master/doris/be/src/olap/delete_handler.cpp:388
10# doris::TabletReader::_init_delete_condition(doris::TabletReader::ReaderParams const&) at /home/zcp/repo_center/doris_master/doris/be/src/olap/tablet_reader.cpp:654
11# doris::TabletReader::_init_params(doris::TabletReader::ReaderParams const&) at /home/zcp/repo_center/doris_master/doris/be/src/olap/tablet_reader.cpp:295
12# doris::TabletReader::init(doris::TabletReader::ReaderParams const&) at /home/zcp/repo_center/doris_master/doris/be/src/olap/tablet_reader.cpp:128
13# doris::vectorized::BlockReader::init(doris::TabletReader::ReaderParams const&) in /mnt/hdd01/ci/compatibility-deploy/be/lib/doris_be
14# doris::vectorized::NewOlapScanner::open(doris::RuntimeState*) at /home/zcp/repo_center/doris_master/doris/be/src/vec/exec/scan/new_olap_scanner.cpp:219
15# doris::vectorized::ScannerScheduler::_scanner_scan(std::shared_ptr<doris::vectorized::ScannerContext>, std::shared_ptr<doris::vectorized::ScanTask>) at /home/zcp/repo_center/doris_master/doris/be/src/vec/exec/scan/scanner_scheduler.cpp:250
16# std::_Function_handler<void (), doris::vectorized::ScannerScheduler::submit(std::shared_ptr<doris::vectorized::ScannerContext>, std::shared_ptr<doris::vectorized::ScanTask>)::$_1::operator()() const::{lambda()#1}>::_M_invoke(std::_Any_data const&) at /var/local/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_function.h:291
17# doris::ThreadPool::dispatch_thread() in /mnt/hdd01/ci/compatibility-deploy/be/lib/doris_be
18# doris::Thread::supervise_thread(void*) at /home/zcp/repo_center/doris_master/doris/be/src/util/thread.cpp:499
19# start_thread at /build/glibc-SzIz7B/glibc-2.31/nptl/pthread_create.c:478
20# __clone at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97

```

related PRs: #36090,
#36101,
#36314
dataroaring pushed a commit that referenced this pull request Jul 17, 2024
@bobhan1 @dataroaring
[Fix](Scanner) Fix reinitialization of TabletReader (#37059)
9c60ecb 
## Proposed changes

```
F20240628 01:49:16.382710 4183685 delete_handler.cpp:388] Check failed: !_is_inited reinitialize delete handler.
*** Check failure stack trace: ***
    @     0x55700470e3c6  google::LogMessage::SendToLog()
    @     0x55700470ae10  google::LogMessage::Flush()
    @     0x55700470ec09  google::LogMessageFatal::~LogMessageFatal()
    @     0x556fccf40e64  doris::DeleteHandler::init()
    @     0x556fcff46678  doris::TabletReader::_init_delete_condition()
    @     0x556fcff3a2dd  doris::TabletReader::_init_params()
    @     0x556fcff39432  doris::TabletReader::init()
    @     0x556fffb8c2dd  doris::vectorized::BlockReader::init()
    @     0x557002cca96a  doris::vectorized::NewOlapScanner::open()
    @     0x556fe892d565  doris::vectorized::ScannerScheduler::_scanner_scan()
    @     0x556fe8931a0f  _ZNSt17_Function_handlerIFvvEZZN5doris10vectorized16ScannerScheduler6submitESt10shared_ptrINS2_14ScannerContextEES4_INS2_8ScanTaskEEENK3$_1clEvEUlvE_E9_M_invokeERKSt9_Any_data
    @     0x556fd0ed95dc  doris::ThreadPool::dispatch_thread()
    @     0x556fd0eb1288  doris::Thread::supervise_thread()
    @     0x7f95143b5609  start_thread
    @     0x7f9514662133  clone
    @              (nil)  (unknown)
*** Query id: c389fc2a1ff6473c-a06f032b8970810c ***
*** is nereids: 1 ***
*** tablet id: 0 ***
*** Aborted at 1719510556 (unix time) try "date -d @1719510556" if you are using GNU date ***
*** Current BE git commitID: b13c17d ***
*** SIGABRT unknown detail explain (@0x3fca33) received by PID 4180531 (TID 4183685 OR 0x7f89734a5700) from PID 4180531; stack trace: ***
 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /home/zcp/repo_center/doris_master/doris/be/src/common/signal_handler.h:421
 1# 0x00007F9514586090 in /lib/x86_64-linux-gnu/libc.so.6
 2# raise at ../sysdeps/unix/sysv/linux/raise.c:51
 3# abort at /build/glibc-SzIz7B/glibc-2.31/stdlib/abort.c:81
 4# 0x0000557004718C9D in /mnt/hdd01/ci/compatibility-deploy/be/lib/doris_be
 5# 0x000055700470B2DA in /mnt/hdd01/ci/compatibility-deploy/be/lib/doris_be
 6# google::LogMessage::SendToLog() in /mnt/hdd01/ci/compatibility-deploy/be/lib/doris_be
 7# google::LogMessage::Flush() in /mnt/hdd01/ci/compatibility-deploy/be/lib/doris_be
 8# google::LogMessageFatal::~LogMessageFatal() in /mnt/hdd01/ci/compatibility-deploy/be/lib/doris_be
 9# doris::DeleteHandler::init(std::shared_ptr<doris::TabletSchema>, std::vector<std::shared_ptr<doris::RowsetMeta>, std::allocator<std::shared_ptr<doris::RowsetMeta> > > const&, long, bool) at /home/zcp/repo_center/doris_master/doris/be/src/olap/delete_handler.cpp:388
10# doris::TabletReader::_init_delete_condition(doris::TabletReader::ReaderParams const&) at /home/zcp/repo_center/doris_master/doris/be/src/olap/tablet_reader.cpp:654
11# doris::TabletReader::_init_params(doris::TabletReader::ReaderParams const&) at /home/zcp/repo_center/doris_master/doris/be/src/olap/tablet_reader.cpp:295
12# doris::TabletReader::init(doris::TabletReader::ReaderParams const&) at /home/zcp/repo_center/doris_master/doris/be/src/olap/tablet_reader.cpp:128
13# doris::vectorized::BlockReader::init(doris::TabletReader::ReaderParams const&) in /mnt/hdd01/ci/compatibility-deploy/be/lib/doris_be
14# doris::vectorized::NewOlapScanner::open(doris::RuntimeState*) at /home/zcp/repo_center/doris_master/doris/be/src/vec/exec/scan/new_olap_scanner.cpp:219
15# doris::vectorized::ScannerScheduler::_scanner_scan(std::shared_ptr<doris::vectorized::ScannerContext>, std::shared_ptr<doris::vectorized::ScanTask>) at /home/zcp/repo_center/doris_master/doris/be/src/vec/exec/scan/scanner_scheduler.cpp:250
16# std::_Function_handler<void (), doris::vectorized::ScannerScheduler::submit(std::shared_ptr<doris::vectorized::ScannerContext>, std::shared_ptr<doris::vectorized::ScanTask>)::$_1::operator()() const::{lambda()#1}>::_M_invoke(std::_Any_data const&) at /var/local/ldb_toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_function.h:291
17# doris::ThreadPool::dispatch_thread() in /mnt/hdd01/ci/compatibility-deploy/be/lib/doris_be
18# doris::Thread::supervise_thread(void*) at /home/zcp/repo_center/doris_master/doris/be/src/util/thread.cpp:499
19# start_thread at /build/glibc-SzIz7B/glibc-2.31/nptl/pthread_create.c:478
20# __clone at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97

```

related PRs: #36090,
#36101,
#36314
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xinyiZzz xinyiZzz xinyiZzz approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhiqiang-hhhh @doris-robot @xinyiZzz @dataroaring

Comments