Skip to content

Revert "[fix](memory safe) Fix block-reader memory alloc failed make …#36979

Merged
yiguolei merged 4 commits intoapache:masterfrom
zhiqiang-hhhh:ervert
Jul 8, 2024
Merged

Revert "[fix](memory safe) Fix block-reader memory alloc failed make …#36979
yiguolei merged 4 commits intoapache:masterfrom
zhiqiang-hhhh:ervert

Conversation

@zhiqiang-hhhh
Copy link
Contributor

…be core dump. (#36299)"

This reverts commit 4bb46a8.

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 39789 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 073d1c4ccc400531105a2f97c118d043045fd41c, data reload: false

------ Round 1 ----------------------------------
q1	17597	4472	4271	4271
q2	2026	206	201	201
q3	10512	1233	1166	1166
q4	10185	815	794	794
q5	7499	2672	2609	2609
q6	223	137	136	136
q7	953	599	606	599
q8	9217	2084	2061	2061
q9	9109	6491	6434	6434
q10	8902	3726	3683	3683
q11	456	243	238	238
q12	487	228	224	224
q13	17762	3012	2991	2991
q14	283	221	226	221
q15	522	486	475	475
q16	525	386	374	374
q17	962	745	646	646
q18	8113	7520	7384	7384
q19	5144	1531	1503	1503
q20	629	327	327	327
q21	4810	3117	3210	3117
q22	391	339	335	335
Total cold run time: 116307 ms
Total hot run time: 39789 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4368	4269	4221	4221
q2	380	279	260	260
q3	2964	2784	2885	2784
q4	1977	1698	1701	1698
q5	5713	5517	5473	5473
q6	212	126	128	126
q7	2233	1880	1866	1866
q8	3288	3427	3404	3404
q9	8712	8658	8875	8658
q10	4098	3856	3708	3708
q11	620	484	506	484
q12	800	648	604	604
q13	17298	3174	3164	3164
q14	299	278	285	278
q15	553	491	496	491
q16	499	419	447	419
q17	1821	1557	1506	1506
q18	8112	8110	7881	7881
q19	1829	1482	1604	1482
q20	3204	1884	1880	1880
q21	5068	5056	4898	4898
q22	676	599	614	599
Total cold run time: 74724 ms
Total hot run time: 55884 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174357 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 073d1c4ccc400531105a2f97c118d043045fd41c, data reload: false

query1	908	385	376	376
query2	6451	2491	2373	2373
query3	6635	209	221	209
query4	22581	17390	17386	17386
query5	3663	489	483	483
query6	267	173	172	172
query7	4594	288	293	288
query8	322	287	281	281
query9	8463	2414	2410	2410
query10	571	304	292	292
query11	10463	10178	10227	10178
query12	120	86	81	81
query13	1641	368	371	368
query14	10338	7724	7232	7232
query15	233	185	187	185
query16	7826	268	259	259
query17	1892	514	521	514
query18	1960	268	267	267
query19	203	151	161	151
query20	90	84	83	83
query21	216	133	121	121
query22	4305	4094	4009	4009
query23	33796	33791	33488	33488
query24	10656	2880	2839	2839
query25	595	375	402	375
query26	717	155	156	155
query27	2277	315	313	313
query28	5851	2145	2132	2132
query29	885	628	632	628
query30	260	151	156	151
query31	971	807	758	758
query32	94	54	56	54
query33	709	288	304	288
query34	926	480	487	480
query35	740	662	625	625
query36	1096	1003	988	988
query37	148	71	73	71
query38	2930	2860	2836	2836
query39	916	851	830	830
query40	215	132	131	131
query41	57	58	57	57
query42	107	105	109	105
query43	597	583	545	545
query44	1109	737	730	730
query45	200	171	162	162
query46	1088	717	703	703
query47	1877	1763	1760	1760
query48	372	300	300	300
query49	850	397	399	397
query50	772	385	383	383
query51	6824	6769	6705	6705
query52	112	97	98	97
query53	361	294	287	287
query54	915	434	436	434
query55	76	74	73	73
query56	282	259	268	259
query57	1152	1032	1044	1032
query58	240	261	255	255
query59	3429	3417	3178	3178
query60	297	278	275	275
query61	90	121	93	93
query62	614	475	454	454
query63	314	292	289	289
query64	8519	2244	1747	1747
query65	3146	3108	3117	3108
query66	740	329	328	328
query67	15430	14816	15169	14816
query68	4489	531	531	531
query69	503	381	342	342
query70	1095	1129	1130	1129
query71	372	297	323	297
query72	7304	5579	5473	5473
query73	747	321	322	321
query74	5879	5582	5565	5565
query75	3324	2659	2701	2659
query76	2208	919	885	885
query77	423	361	302	302
query78	10391	9788	9781	9781
query79	2545	514	514	514
query80	1669	492	492	492
query81	546	226	223	223
query82	1425	107	104	104
query83	285	172	170	170
query84	252	91	90	90
query85	1323	274	268	268
query86	467	290	320	290
query87	3316	3065	3144	3065
query88	3833	2359	2369	2359
query89	479	386	385	385
query90	1708	194	192	192
query91	130	103	101	101
query92	58	53	52	52
query93	2296	513	498	498
query94	1088	196	183	183
query95	413	315	315	315
query96	595	277	265	265
query97	3179	3085	3062	3062
query98	295	206	194	194
query99	1231	825	818	818
Total cold run time: 270962 ms
Total hot run time: 174357 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.64 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 073d1c4ccc400531105a2f97c118d043045fd41c, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.03	0.04
query3	0.22	0.06	0.06
query4	1.66	0.09	0.09
query5	0.50	0.49	0.48
query6	1.13	0.73	0.73
query7	0.02	0.01	0.02
query8	0.05	0.04	0.05
query9	0.56	0.50	0.49
query10	0.55	0.55	0.55
query11	0.14	0.11	0.12
query12	0.16	0.12	0.12
query13	0.59	0.58	0.60
query14	0.81	0.79	0.77
query15	0.85	0.81	0.83
query16	0.37	0.37	0.35
query17	0.95	0.98	1.05
query18	0.21	0.24	0.23
query19	1.83	1.74	1.74
query20	0.01	0.01	0.01
query21	15.42	0.74	0.65
query22	4.31	6.93	1.90
query23	18.31	1.42	1.20
query24	2.15	0.24	0.21
query25	0.15	0.09	0.08
query26	0.28	0.18	0.18
query27	0.08	0.08	0.09
query28	13.23	1.03	1.00
query29	12.61	3.32	3.31
query30	0.25	0.06	0.06
query31	2.89	0.39	0.39
query32	3.27	0.47	0.47
query33	2.87	2.94	2.91
query34	17.09	4.41	4.45
query35	4.51	4.50	4.50
query36	0.66	0.47	0.48
query37	0.18	0.15	0.16
query38	0.15	0.15	0.14
query39	0.04	0.04	0.03
query40	0.17	0.15	0.15
query41	0.09	0.05	0.05
query42	0.06	0.04	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.54 s
Total hot run time: 30.64 s

@zhiqiang-hhhh
Copy link
Contributor Author

run p0

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 39671 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 460597dd1cecfe981617e4a494317a2c40248c28, data reload: false

------ Round 1 ----------------------------------
q1	17626	4366	4252	4252
q2	2014	198	193	193
q3	10462	1251	1130	1130
q4	10180	784	744	744
q5	7476	2616	2630	2616
q6	219	144	139	139
q7	949	609	624	609
q8	9239	2055	2035	2035
q9	9175	6499	6467	6467
q10	8991	3739	3731	3731
q11	461	238	236	236
q12	481	234	229	229
q13	17786	3028	3015	3015
q14	275	237	218	218
q15	514	495	480	480
q16	505	379	373	373
q17	952	642	625	625
q18	7962	7508	7337	7337
q19	5809	1417	1516	1417
q20	659	342	337	337
q21	4922	3151	3808	3151
q22	386	337	353	337
Total cold run time: 117043 ms
Total hot run time: 39671 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4342	4190	4222	4190
q2	369	281	263	263
q3	2978	2879	2850	2850
q4	2012	1736	1675	1675
q5	5662	5511	5497	5497
q6	223	133	131	131
q7	2246	1886	1885	1885
q8	3240	3414	3416	3414
q9	8755	8685	8861	8685
q10	4123	3781	3729	3729
q11	600	494	528	494
q12	835	651	678	651
q13	16988	3180	3158	3158
q14	299	285	290	285
q15	523	503	472	472
q16	486	450	456	450
q17	1819	1517	1536	1517
q18	8151	7859	7866	7859
q19	1731	1590	1567	1567
q20	2304	1869	1878	1869
q21	5211	4963	4764	4764
q22	617	588	590	588
Total cold run time: 73514 ms
Total hot run time: 55993 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173371 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 460597dd1cecfe981617e4a494317a2c40248c28, data reload: false

query1	922	383	377	377
query2	6447	2605	2500	2500
query3	6637	202	212	202
query4	18824	17615	17194	17194
query5	3670	488	504	488
query6	283	184	180	180
query7	4588	326	310	310
query8	322	295	297	295
query9	8361	2421	2419	2419
query10	637	313	299	299
query11	10608	10253	9990	9990
query12	115	91	87	87
query13	1659	358	371	358
query14	8903	7805	6235	6235
query15	236	188	186	186
query16	8015	270	259	259
query17	1912	566	513	513
query18	2040	271	269	269
query19	193	154	158	154
query20	93	81	82	81
query21	218	133	130	130
query22	4503	3986	3963	3963
query23	33803	33755	34107	33755
query24	10809	2807	2867	2807
query25	631	382	378	378
query26	1167	163	156	156
query27	2465	338	326	326
query28	7244	2180	2189	2180
query29	918	645	645	645
query30	250	153	159	153
query31	1002	749	793	749
query32	105	56	57	56
query33	760	299	283	283
query34	1069	503	503	503
query35	743	666	663	663
query36	1117	957	988	957
query37	165	82	83	82
query38	2932	2821	2826	2821
query39	887	862	845	845
query40	213	136	134	134
query41	59	55	55	55
query42	108	105	106	105
query43	601	575	579	575
query44	1189	734	741	734
query45	196	170	172	170
query46	1080	761	723	723
query47	1887	1817	1756	1756
query48	373	307	295	295
query49	850	407	415	407
query50	762	387	392	387
query51	6909	6854	6794	6794
query52	100	94	96	94
query53	359	294	290	290
query54	907	451	449	449
query55	75	75	71	71
query56	288	267	261	261
query57	1116	1048	1032	1032
query58	264	295	256	256
query59	3690	3472	3366	3366
query60	303	277	290	277
query61	95	94	96	94
query62	607	453	462	453
query63	353	291	288	288
query64	8915	2252	1755	1755
query65	3128	3103	3116	3103
query66	751	320	330	320
query67	15277	15101	14795	14795
query68	4476	555	556	555
query69	647	414	327	327
query70	1193	1175	1178	1175
query71	405	281	281	281
query72	7148	5732	5113	5113
query73	749	331	327	327
query74	5971	5593	5487	5487
query75	3519	2682	2686	2682
query76	2866	986	918	918
query77	684	321	312	312
query78	10395	9939	9679	9679
query79	2465	525	507	507
query80	939	481	495	481
query81	591	229	221	221
query82	756	108	114	108
query83	264	169	171	169
query84	241	84	83	83
query85	1776	280	277	277
query86	479	342	317	317
query87	3248	3061	3094	3061
query88	3680	2357	2360	2357
query89	474	389	386	386
query90	1759	192	189	189
query91	128	103	100	100
query92	59	51	52	51
query93	2424	516	526	516
query94	1106	191	186	186
query95	410	315	317	315
query96	593	266	265	265
query97	3194	3058	2999	2999
query98	236	207	193	193
query99	1200	851	847	847
Total cold run time: 269783 ms
Total hot run time: 173371 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.21 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 460597dd1cecfe981617e4a494317a2c40248c28, data reload: false

query1	0.04	0.03	0.03
query2	0.09	0.04	0.04
query3	0.22	0.05	0.06
query4	1.67	0.08	0.10
query5	0.52	0.48	0.49
query6	1.15	0.73	0.73
query7	0.02	0.01	0.02
query8	0.04	0.04	0.04
query9	0.55	0.50	0.50
query10	0.54	0.54	0.53
query11	0.15	0.12	0.11
query12	0.15	0.12	0.12
query13	0.60	0.59	0.60
query14	0.77	0.77	0.81
query15	0.87	0.82	0.80
query16	0.36	0.37	0.35
query17	0.99	1.00	0.99
query18	0.24	0.26	0.23
query19	1.86	1.77	1.69
query20	0.01	0.01	0.02
query21	15.44	0.75	0.65
query22	4.78	6.39	2.32
query23	18.24	1.43	1.50
query24	2.19	0.22	0.24
query25	0.16	0.08	0.09
query26	0.27	0.18	0.18
query27	0.09	0.08	0.08
query28	13.17	1.03	1.01
query29	12.63	3.36	3.32
query30	0.26	0.06	0.06
query31	2.87	0.40	0.40
query32	3.29	0.47	0.47
query33	2.94	2.89	2.96
query34	16.86	4.43	4.43
query35	4.45	4.47	4.51
query36	0.66	0.46	0.47
query37	0.18	0.15	0.15
query38	0.16	0.14	0.15
query39	0.04	0.03	0.04
query40	0.16	0.14	0.14
query41	0.10	0.05	0.05
query42	0.06	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 109.88 s
Total hot run time: 31.21 s

yiguolei
yiguolei previously approved these changes Jul 1, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jul 1, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2024

PR approved by anyone and no changes requested.

zhangstar333
zhangstar333 previously approved these changes Jul 4, 2024
@zhiqiang-hhhh zhiqiang-hhhh dismissed stale reviews from zhangstar333 and yiguolei via 9573edd July 5, 2024 06:37
@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jul 5, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40492 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9573edd2a1b76d4b323462f6665ab940336761fe, data reload: false

------ Round 1 ----------------------------------
q1	17611	4320	4273	4273
q2	2009	192	190	190
q3	10465	1162	1115	1115
q4	10191	788	756	756
q5	7506	2683	2624	2624
q6	224	138	139	138
q7	950	611	628	611
q8	9228	2095	2094	2094
q9	9101	6474	6500	6474
q10	8862	3713	3700	3700
q11	462	236	243	236
q12	511	236	234	234
q13	18872	2950	2988	2950
q14	260	223	224	223
q15	520	473	486	473
q16	475	370	369	369
q17	962	597	632	597
q18	8123	7427	7472	7427
q19	3852	1475	1516	1475
q20	673	332	332	332
q21	4967	4063	3862	3862
q22	402	339	340	339
Total cold run time: 116226 ms
Total hot run time: 40492 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4368	4212	4373	4212
q2	374	260	264	260
q3	3017	2844	2876	2844
q4	2024	1704	1673	1673
q5	5678	5502	5441	5441
q6	219	136	136	136
q7	2204	1887	1884	1884
q8	3267	3426	3364	3364
q9	8697	8726	8814	8726
q10	4047	3893	3787	3787
q11	599	505	499	499
q12	814	663	638	638
q13	16128	3134	3193	3134
q14	289	283	285	283
q15	530	493	497	493
q16	498	423	427	423
q17	1815	1529	1521	1521
q18	8154	7935	7846	7846
q19	1786	1627	1452	1452
q20	2153	1928	1831	1831
q21	9175	4974	4904	4904
q22	603	586	565	565
Total cold run time: 76439 ms
Total hot run time: 55916 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174459 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9573edd2a1b76d4b323462f6665ab940336761fe, data reload: false

query1	908	374	377	374
query2	6462	2430	2408	2408
query3	6636	203	210	203
query4	28280	17198	17097	17097
query5	3664	509	489	489
query6	261	171	172	171
query7	4602	305	299	299
query8	323	295	305	295
query9	8493	2487	2463	2463
query10	575	300	287	287
query11	11977	10076	9986	9986
query12	116	83	91	83
query13	1648	375	384	375
query14	10289	7863	7957	7863
query15	268	193	192	192
query16	7667	314	316	314
query17	1815	574	551	551
query18	2029	285	288	285
query19	207	161	157	157
query20	93	84	89	84
query21	220	134	132	132
query22	4406	4111	4042	4042
query23	34134	34281	33615	33615
query24	10898	2929	2950	2929
query25	631	429	425	425
query26	1265	168	162	162
query27	2892	332	345	332
query28	7183	2212	2211	2211
query29	919	685	684	684
query30	263	160	154	154
query31	987	822	771	771
query32	101	56	58	56
query33	797	332	324	324
query34	909	530	515	515
query35	792	664	733	664
query36	1155	984	985	984
query37	152	82	86	82
query38	2878	2813	2693	2693
query39	945	819	802	802
query40	206	128	126	126
query41	54	50	53	50
query42	131	103	97	97
query43	602	563	550	550
query44	1186	743	730	730
query45	190	165	159	159
query46	1080	735	758	735
query47	1835	1753	1769	1753
query48	370	299	301	299
query49	853	414	426	414
query50	763	385	394	385
query51	6890	6806	6723	6723
query52	108	92	94	92
query53	380	299	293	293
query54	868	458	454	454
query55	74	75	73	73
query56	296	294	274	274
query57	1154	1032	1020	1020
query58	254	255	250	250
query59	3386	3256	3080	3080
query60	302	283	280	280
query61	98	98	94	94
query62	577	440	423	423
query63	332	297	299	297
query64	8956	2243	1846	1846
query65	3157	3131	3111	3111
query66	698	331	338	331
query67	15702	15098	14859	14859
query68	8970	560	573	560
query69	819	448	366	366
query70	1390	1156	1128	1128
query71	513	282	279	279
query72	9357	5464	5564	5464
query73	2277	329	327	327
query74	5887	5414	5504	5414
query75	5370	2709	2644	2644
query76	5534	955	930	930
query77	756	302	318	302
query78	10535	8952	8833	8833
query79	10788	536	545	536
query80	1249	501	486	486
query81	589	220	223	220
query82	269	104	108	104
query83	302	171	166	166
query84	269	89	88	88
query85	1119	322	311	311
query86	376	310	318	310
query87	3390	3069	3065	3065
query88	5081	2451	2436	2436
query89	507	400	392	392
query90	2155	186	188	186
query91	136	104	106	104
query92	63	51	50	50
query93	6410	523	514	514
query94	1519	212	214	212
query95	407	320	319	319
query96	606	275	275	275
query97	3218	3042	3034	3034
query98	220	208	195	195
query99	1126	859	858	858
Total cold run time: 309549 ms
Total hot run time: 174459 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.92 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9573edd2a1b76d4b323462f6665ab940336761fe, data reload: false

query1	0.04	0.03	0.04
query2	0.07	0.04	0.04
query3	0.22	0.04	0.05
query4	1.69	0.07	0.06
query5	0.51	0.48	0.48
query6	1.14	0.72	0.73
query7	0.02	0.01	0.01
query8	0.05	0.05	0.05
query9	0.56	0.49	0.49
query10	0.53	0.53	0.54
query11	0.15	0.11	0.11
query12	0.16	0.12	0.12
query13	0.59	0.59	0.59
query14	0.81	0.78	0.78
query15	0.84	0.81	0.81
query16	0.38	0.38	0.38
query17	0.97	1.02	0.98
query18	0.23	0.23	0.26
query19	1.80	1.75	1.72
query20	0.01	0.01	0.01
query21	15.39	0.76	0.67
query22	4.31	6.46	2.02
query23	18.35	1.45	1.37
query24	2.42	0.22	0.22
query25	0.16	0.09	0.08
query26	0.28	0.22	0.21
query27	0.45	0.23	0.23
query28	13.27	1.01	0.99
query29	12.59	3.42	3.38
query30	0.26	0.05	0.06
query31	2.87	0.39	0.39
query32	3.27	0.49	0.47
query33	2.94	2.97	2.91
query34	17.08	4.35	4.38
query35	4.40	4.42	4.39
query36	0.65	0.46	0.47
query37	0.17	0.14	0.14
query38	0.15	0.14	0.15
query39	0.04	0.04	0.03
query40	0.15	0.12	0.13
query41	0.09	0.04	0.04
query42	0.05	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 110.15 s
Total hot run time: 30.92 s

@zhiqiang-hhhh
Copy link
Contributor Author

run p0

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 8, 2024
@yiguolei yiguolei merged commit a417fca into apache:master Jul 8, 2024
dataroaring pushed a commit that referenced this pull request Jul 17, 2024
#36979)

…be core dump. (#36299)"

This reverts commit 4bb46a8.

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.1-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments