[Refactor](Variant) should not call finalize in const functions#37839
Merged
yiguolei merged 2 commits intoapache:masterfrom Jul 16, 2024
Merged
[Refactor](Variant) should not call finalize in const functions#37839yiguolei merged 2 commits intoapache:masterfrom
yiguolei merged 2 commits intoapache:masterfrom
Conversation
`finalize` may change the inner data structure in ColumnObject, and lead to heap use after free in some scenario
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Member
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40054 ms |
TPC-DS: Total hot run time: 172967 ms |
ClickBench: Total hot run time: 30.95 s |
Member
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 42293 ms |
TPC-DS: Total hot run time: 172753 ms |
ClickBench: Total hot run time: 31.9 s |
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
yiguolei
approved these changes
Jul 16, 2024
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Jul 16, 2024
…he#37839) `finalize` may change the inner data structure in ColumnObject, and lead to heap use after free in some scenario Issue Number: close #xxx <!--Describe your changes.-->
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Jul 16, 2024
…he#37839) `finalize` may change the inner data structure in ColumnObject, and lead to heap use after free in some scenario ## Proposed changes Issue Number: close #xxx <!--Describe your changes.-->
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jul 17, 2024
…he#37839) `finalize` may change the inner data structure in ColumnObject, and lead to heap use after free in some scenario ## Proposed changes Issue Number: close #xxx <!--Describe your changes.-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
finalizemay change the inner data structure in ColumnObject, and lead to heap use after free in some scenarioProposed changes
Issue Number: close #xxx