[fix](mtmv) Fix compensate union all wrongly when query rewrite by materialized view#40803
Merged
starocean999 merged 4 commits intoapache:masterfrom Sep 20, 2024
Merged
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 42642 ms |
TPC-DS: Total hot run time: 199281 ms |
ClickBench: Total hot run time: 30.96 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 43317 ms |
TPC-H: Total hot run time: 41301 ms |
TPC-DS: Total hot run time: 199427 ms |
ClickBench: Total hot run time: 32.93 s |
morrySnow
reviewed
Sep 18, 2024
Comment on lines
360
to
361
| && ((SlotReference) expr).isColumnFromTable() | ||
| && ((SlotReference) expr).getColumn().get().getName().equals(relatedCol)).isEmpty(); |
seawinde
force-pushed
the
fix_add_union_all_wrongly_when_rewrite
branch
from
fd27e07 to
492ec60
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41754 ms |
TPC-DS: Total hot run time: 194879 ms |
ClickBench: Total hot run time: 33.13 s |
morrySnow
approved these changes
Sep 19, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
starocean999
approved these changes
Sep 20, 2024
gavinchou
pushed a commit
that referenced
this pull request
Sep 25, 2024
…terialized view (#40803) ## Proposed changes This is brought by #36056 Not all query after rewritten successfully can compensate union all Such as: mv def sql is as following, partition column is a ```sql select a, b, count(*) from t1 group by a, b ``` Query is as following: ```sq select count(*) from t1 ``` the result is +----------+ | count(*) | +----------+ | 24 | +----------+ after rewritten by materialized view successfully If mv part partition is invalid, can not compensate union all, because result is wrong after compensate union all. +----------+ | count(*) | +----------+ | 24 | | 3 | +----------+ This pr fix this.
Closed
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Oct 17, 2024
…terialized view (apache#40803) This is brought by apache#36056 Not all query after rewritten successfully can compensate union all Such as: mv def sql is as following, partition column is a ```sql select a, b, count(*) from t1 group by a, b ``` Query is as following: ```sq select count(*) from t1 ``` the result is +----------+ | count(*) | +----------+ | 24 | +----------+ after rewritten by materialized view successfully If mv part partition is invalid, can not compensate union all, because result is wrong after compensate union all. +----------+ | count(*) | +----------+ | 24 | | 3 | +----------+ This pr fix this.
yiguolei
pushed a commit
that referenced
this pull request
Oct 18, 2024
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is brought by #36056
Not all query after rewritten successfully can compensate union all
Such as:
mv def sql is as following, partition column is a
Query is as following:
the result is
+----------+
| count(*) |
+----------+
| 24 |
+----------+
after rewritten by materialized view successfully
If mv part partition is invalid, can not compensate union all, because result is wrong after
compensate union all.
+----------+
| count(*) |
+----------+
| 24 |
| 3 |
+----------+
This pr fix this.