[feature](Nereids): Optimize Query Plan by Pulling Up Join with Common Child from Union#42033
Merged
englefly merged 10 commits intoapache:masterfrom Oct 30, 2024
Merged
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41265 ms |
TPC-DS: Total hot run time: 191957 ms |
ClickBench: Total hot run time: 32.08 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41150 ms |
TPC-DS: Total hot run time: 191386 ms |
ClickBench: Total hot run time: 32.05 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41209 ms |
TPC-DS: Total hot run time: 192071 ms |
ClickBench: Total hot run time: 33.07 s |
feiniaofeiafei
force-pushed
the
pull_up_join_union
branch
from
ff4d939 to
3e5dd4e
Compare
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41333 ms |
TPC-DS: Total hot run time: 191734 ms |
ClickBench: Total hot run time: 32.98 s |
xzj7019
reviewed
Oct 24, 2024
| ----------------PhysicalDistribute[DistributionSpecExecutionAny] | ||
| ------------------PhysicalProject | ||
| --------------------hashJoin[INNER_JOIN broadcast] hashCondition=((store_sales.ss_sold_date_sk = date_dim.d_date_sk)) otherCondition=() build RFs:RF9 d_date_sk->[ss_sold_date_sk] | ||
| --------------hashJoin[INNER_JOIN broadcast] hashCondition=((ss_sold_date_sk = date_dim.d_date_sk)) otherCondition=() build RFs:RF9 d_date_sk->[cs_sold_date_sk,ss_sold_date_sk,ws_sold_date_sk] |
Contributor
There was a problem hiding this comment.
14/71/76 better to measure its real performance impact.
Contributor
Author
There was a problem hiding this comment.
tpcds1000:query4:before 6.27s after 6.09s, query71: before:1.09s after:1.14s,query76:before 7.59 afert8.07
Average time of six executions。
feiniaofeiafei
force-pushed
the
pull_up_join_union
branch
2 times, most recently
from
5d3080a to
746fa5a
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41467 ms |
TPC-DS: Total hot run time: 192659 ms |
ClickBench: Total hot run time: 32.67 s |
xzj7019
reviewed
Oct 28, 2024
| topDown( | ||
| new PullUpJoinFromUnionAll() | ||
| ), | ||
| custom(RuleType.COLUMN_PRUNING, ColumnPruning::new), |
Contributor
There was a problem hiding this comment.
make sure the new rule sets can replace the original one's column pruning functionality.
TPC-DS: Total hot run time: 192249 ms |
ClickBench: Total hot run time: 32.28 s |
feiniaofeiafei
force-pushed
the
pull_up_join_union
branch
from
7402e07 to
f3283bb
Compare
feiniaofeiafei
force-pushed
the
pull_up_join_union
branch
from
f3283bb to
fb40e30
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41565 ms |
TPC-DS: Total hot run time: 197365 ms |
ClickBench: Total hot run time: 32.1 s |
englefly
approved these changes
Oct 29, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
starocean999
approved these changes
Oct 30, 2024
feiniaofeiafei
added a commit
to feiniaofeiafei/doris
that referenced
this pull request
Nov 11, 2024
…n Child from Union (apache#42033) This pr adds rewrite rule PullUpJoinFromUnion, supports pull up join from union all separately, separates this rule from apache#28682, deletes the original PullUpJoinFromUnionAll rule.
feiniaofeiafei
added a commit
to feiniaofeiafei/doris
that referenced
this pull request
Nov 11, 2024
…n Child from Union (apache#42033) This pr adds rewrite rule PullUpJoinFromUnion, supports pull up join from union all separately, separates this rule from apache#28682, deletes the original PullUpJoinFromUnionAll rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds rewrite rule PullUpJoinFromUnion, supports pull up join from union all separately, separates this rule from #28682, deletes the original PullUpJoinFromUnionAll rule.