[fix](export) remove export task executor in TransientTaskExecutor (#42880)#42950
Merged
morningman merged 1 commit intoapache:masterfrom Oct 31, 2024
Merged
[fix](export) remove export task executor in TransientTaskExecutor (#42880)#42950morningman merged 1 commit intoapache:masterfrom
morningman merged 1 commit intoapache:masterfrom
Conversation
…pache#42880) ### What problem does this PR solve? Problem Summary: There is a memory leak on FE side when continue running `export` command. The `ExportTaskExecutor` instances will be added to `TransientTaskManager` and never be removed. This PR mainly changes: 1. Remove unused `ExportTaskRegister` in `Env`. 2. Remove `ExportTaskExecutor` from `TransientTaskManager` once export job is finished or cancelled. ### Release note Fix FE memory leak by removing `ExportTaskExecutor` from `TransientTaskManager` once export job is finished or cancelled.
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
BePPPower
approved these changes
Oct 31, 2024
Contributor
|
PR approved by anyone and no changes requested. |
CalvinKirs
approved these changes
Oct 31, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
16 tasks
morningman
added a commit
that referenced
this pull request
Nov 1, 2024
### What problem does this PR solve? Related PR: #42950 Problem Summary: PR #42950 change some logic in ExportJob, by removing the `taskIdToExecutor`, which is a thread safe ConcurrentHashMap. But there is a problem that, when cancelling a export job, it will clear the `jobExecutorList` in ExportJob, and meanwhile, this `jobExecutorList` may being traversed when creating the export job, causing concurrent modification exception. This PR fix it by locking the writeLock of ExportMgr when cancelling the export job.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 1, 2024
### What problem does this PR solve? Related PR: #42950 Problem Summary: PR #42950 change some logic in ExportJob, by removing the `taskIdToExecutor`, which is a thread safe ConcurrentHashMap. But there is a problem that, when cancelling a export job, it will clear the `jobExecutorList` in ExportJob, and meanwhile, this `jobExecutorList` may being traversed when creating the export job, causing concurrent modification exception. This PR fix it by locking the writeLock of ExportMgr when cancelling the export job.
16 tasks
morningman
added a commit
to morningman/doris
that referenced
this pull request
Nov 6, 2024
morningman
added a commit
to morningman/doris
that referenced
this pull request
Nov 6, 2024
…he#43051) ### What problem does this PR solve? Related PR: apache#42950 Problem Summary: PR apache#42950 change some logic in ExportJob, by removing the `taskIdToExecutor`, which is a thread safe ConcurrentHashMap. But there is a problem that, when cancelling a export job, it will clear the `jobExecutorList` in ExportJob, and meanwhile, this `jobExecutorList` may being traversed when creating the export job, causing concurrent modification exception. This PR fix it by locking the writeLock of ExportMgr when cancelling the export job.
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #42880