[fix](export) make sure the export task being executed after writing "create export job" edit log#43250
Merged
morningman merged 1 commit intoapache:masterfrom Nov 6, 2024
Merged
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
morningman
force-pushed
the
check_export_job
branch
from
a381544 to
d8ee074
Compare
Contributor
Author
|
run buildall |
morningman
changed the title
CalvinKirs
approved these changes
Nov 6, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
BePPPower
approved these changes
Nov 6, 2024
morningman
added a commit
to morningman/doris
that referenced
this pull request
Nov 6, 2024
…"create export job" edit log (apache#43250) Problem Summary: Fix bug like: ``` java.lang.NullPointerException: Cannot invoke "org.apache.doris.load.ExportJob.replayExportJobState(org.apache.doris.load.ExportJobState)" because "job" is null at org.apache.doris.load.ExportMgr.replayUpdateJobState(ExportMgr.java:475) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.persist.EditLog.loadJournal(EditLog.java:390) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.catalog.Env.replayJournal(Env.java:2965) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.master.Checkpoint.doCheckpoint(Checkpoint.java:135) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.master.Checkpoint.runAfterCatalogReady(Checkpoint.java:80) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.common.util.MasterDaemon.runOneCycle(MasterDaemon.java:58) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.common.util.Daemon.run(Daemon.java:119) ~[doris-fe.jar:1.2-SNAPSHOT] ``` This is because the export job is finished before adding it. The "finish" log is saved before "creating" log, so when replaying the "finish" log, the export job can not be found. This PR change the order of "writing create export job log" and `adding export task` event, to avoid this error
morningman
added a commit
that referenced
this pull request
Nov 6, 2024
morningman
added
dev/3.0.3-merged
and removed
dev/3.0.x
cherry-pick-conflict-in-3.0
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
Fix bug like:
This is because the export job is finished before adding it.
The "finish" log is saved before "creating" log, so when replaying the "finish" log,
the export job can not be found.
This PR change the order of "writing create export job log" and
adding export taskevent,to avoid this error
Check List (For Committer)
Test
Behavior changed:
Does this need documentation?
Release note
None
Check List (For Reviewer who merge this PR)