[Feature] Running Profile OLAP_SCAN_NODE layering and enhance readability#4825
Merged
morningman merged 4 commits intoapache:masterfrom Nov 11, 2020
Merged
Conversation
chaoyli
reviewed
Oct 30, 2020
be/src/exec/scan_node.cpp
Outdated
Contributor
There was a problem hiding this comment.
Where to show this _scanner_profile, it's not added into _runtime_profile
HappenLee
requested changes
Nov 2, 2020
be/src/exec/scan_node.h
Outdated
Contributor
There was a problem hiding this comment.
use std::unique_ptr replace boost::scoped_ptr
be/src/exec/scan_node.cpp
Outdated
Contributor
There was a problem hiding this comment.
should _segment_profile and scanner_profile be scan_node?
Like MysqlScanNode is a child of scan_node， _segment_profile and scanner_profile is useless in MysqlScanNode
Contributor
Author
|
@HappenLee Good question, I have moved |
HappenLee
reviewed
Nov 6, 2020
Contributor
There was a problem hiding this comment.
NumScanner应该表示的是提交到线程池Task数目，并不能直接推导出他的线程数
HappenLee
approved these changes
Nov 9, 2020
Contributor
|
LGTM |
morningman
added
kind/docs
1 task
morningman
added a commit
that referenced
this pull request
Nov 12, 2020
Fix UT failed by #4825 and remove useless profile
1 task
morningman
pushed a commit
that referenced
this pull request
Nov 13, 2020
bug introduced from pr #4825, will cause `schema_change` to report an error: ``` schema_change.cpp:1271] fail to check row num! source_rows=1, merged_rows=0, filtered_rows=0, new_index_rows=0 schema_change.cpp:1921] failed to process the version. version=2-2 schema_change.cpp:1615] failed to alter tablet. base_tablet=44643.1383650721.b140317f6662c1e0-65bcbc87db8d22bc, drop new_tablet=45680.1530531459.474e41f3dd538fb6-9284085daac24f83 ```
Closed
Hastyshell
pushed a commit
to Hastyshell/doris
that referenced
this pull request
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
mainly includes:
OLAP_SCAN_NODEprofile layering:OLAP_SCAN_NODE,OlapScanner, andSegmentIterator.RowsConditionsFilteredstatistical, split fromRowsDelFiltered, the meaning is the number of rows filtered by various column indexes, only in segment V2.Types of changes
Checklist