Skip to content

branch-2.1 [fix](nereids)avoid generate Runtime filter whose target is not a base table column #48804#49314

Merged
yiguolei merged 1 commit intoapache:branch-2.1from
englefly:rf-null-2.1
Mar 27, 2025
Merged

branch-2.1 [fix](nereids)avoid generate Runtime filter whose target is not a base table column #48804#49314
yiguolei merged 1 commit intoapache:branch-2.1from
englefly:rf-null-2.1

Conversation

@englefly
Copy link
Contributor

@englefly englefly commented Mar 20, 2025

What problem does this PR solve?

pick #48804
Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@englefly
[fix](nereids)avoid generate Runtime filter whose target is not a bas…
1989b07 
…e table column (apache#48804)

### What problem does this PR solve?
avoid generate wrong rf for pattern
```
join(apache#5=apache#8)
   --> join(apache#7=apache#6)
           -->project(null as apache#5, apache#7)
                    --->scan(t1)
           -->project(apache#6)
                   -->scan(T2[apache#5, apache#6])
   -->scan(T3[apache#8])
```
`RF(apache#8->apache#5)` should not be generated.
but current version, we set RF taget to `T2.apache#5`
@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 20, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@englefly englefly changed the base branch from master to branch-2.1 March 20, 2025 09:04
@englefly
Copy link
Contributor Author

englefly commented Mar 20, 2025

run buildall

@morrySnow morrySnow changed the title branch-2.1 [fix](nereids)avoid generate Runtime filter whose target is not a base table column (#48804) branch-2.1 [fix](nereids)avoid generate Runtime filter whose target is not a base table column #48804 Mar 20, 2025
@yiguolei yiguolei merged commit 374b901 into apache:branch-2.1 Mar 27, 2025
24 checks passed
@englefly englefly mentioned this pull request Apr 27, 2025
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

@dataroaring dataroaring Awaiting requested review from dataroaring

@morningman morningman Awaiting requested review from morningman

@xiaokang xiaokang Awaiting requested review from xiaokang

@CalvinKirs CalvinKirs Awaiting requested review from CalvinKirs

@gavinchou gavinchou Awaiting requested review from gavinchou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@englefly @hello-stephen @yiguolei

Comments