[Refactor] Refactor DeleteHandler and Cond module (2nd)#5030
Merged
yangzhg merged 2 commits intoapache:masterfrom Dec 8, 2020
Merged
[Refactor] Refactor DeleteHandler and Cond module (2nd)#5030yangzhg merged 2 commits intoapache:masterfrom
yangzhg merged 2 commits intoapache:masterfrom
Conversation
This patch mainly do the following refactors: - Use int64_t instead of int32_t for 'version' in DeleteHandler - Move some comments from .cpp to .h file, add some new comments in .h files, and also remove some meaningless comments - Use switch...case... instead of multiple if..else.. for DeleteConditionHandler::is_condition_value_valid - Use range loop to simplify code - Reduce some compare operations in Cond::del_eval - Improve some branch predictions in Reader - Fix and improve some unit tests
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Dec 17, 2020
If a column does not have any null value, and execute a delete operation with "where k1 is null" on it, BE may crash. This bug is introducaed from apache#5030
2 tasks
morningman
added a commit
to baidu-doris/incubator-doris
that referenced
this pull request
Jan 5, 2021
…pache#5109) If a column does not have any null value, and execute a delete operation with "where k1 is null" on it, BE may crash. This bug is introducaed from apache#5030
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This patch mainly do the following refactors:
Compare with #4925 , this patch fix two bugs:
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.