You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Problem Summary:
In the previous PR #51329, global lazy materialization was implemented.
However, since RPC requests will be sent to other BE nodes during the materialization phase, the external node needs to rely on query ctx when reading the corresponding file after receiving the RPC request, but the query ctx on the BE may have been released, resulting in BE core.
Solution:
By caching some information in query ctx, RPC does not need to rely on query ctx.
Release note
None
Check List (For Author)
Test
Regression test
Unit Test
Manual test (add detailed scripts or steps below)
No need to test or manual test. Explain why:
This is a refactor/code format and no logic has been changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
approvedIndicates a PR has been approved by one committer.reviewed
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related PR: #51329
Problem Summary:
In the previous PR #51329, global lazy materialization was implemented.
However, since RPC requests will be sent to other BE nodes during the materialization phase, the external node needs to rely on
query ctxwhen reading the corresponding file after receiving the RPC request, but thequery ctxon the BE may have been released, resulting in BE core.Solution:
By caching some information in
query ctx, RPC does not need to rely onquery ctx.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)