[fix](load) Convert RowInBlock* to shared_ptr to fix potential memory leaks in MemTable#52902
Merged
hello-stephen merged 1 commit intoapache:masterfrom Jul 8, 2025
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
… leaks in MemTable
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33250 ms |
TPC-DS: Total hot run time: 186691 ms |
ClickBench: Total hot run time: 29.81 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
hello-stephen
approved these changes
Jul 8, 2025
liaoxin01
added a commit
to liaoxin01/doris
that referenced
this pull request
Jul 8, 2025
… leaks in MemTable (apache#52902) Issue Number: close #xxx Related PR: #xxx Problem Summary: Direct leak of 193504 byte(s) in 6047 object(s) allocated from: (/mnt/ssd01/pipline/OpenSourceDoris/clusterEnv/P0/Cluster0/be/lib/doris_be+0x2a0015fd) const*, std::vector<unsigned int, doris::CustomStdAllocator<unsigned int, doris::Allocator<false, false, false, doris::DefaultMemoryAllocator> > > const&) /root/doris/be/src/olap/memtable.cpp:243:38 doris::MemTableWriter::write(doris::vectorized::Block const*, std::vector<unsigned int, doris::CustomStdAllocator<unsigned int, doris::Allocator<false, false, false, doris::DefaultMemoryAllocator> > > const&) /root/doris/be/src/olap/memtable_writer.cpp:107:27 doris::DeltaWriterV2::write(doris::vectorized::Block const*, std::vector<unsigned int, doris::CustomStdAllocator<unsigned int, doris::Allocator<false, false, false, doris::DefaultMemoryAllocator> > > const&) /root/doris/be/src/olap/delta_writer_v2.cpp:164:30 doris::vectorized::VTabletWriterV2::_write_memtable(std::shared_ptr<doris::vectorized::Block>, long, doris::vectorized::Rows const&) /root/doris/be/src/vec/sink/writer/vtablet_writer_v2.cpp:552:24 doris::vectorized::VTabletWriterV2::write(doris::RuntimeState*, doris::vectorized::Block&) /root/doris/be/src/vec/sink/writer/vtablet_writer_v2.cpp:486:9 doris::vectorized::AsyncResultWriter::process_block(doris::RuntimeState*, doris::RuntimeProfile*) /root/doris/be/src/vec/sink/writer/async_result_writer.cpp:169:23 doris::vectorized::AsyncResultWriter::start_writer(doris::RuntimeState*, doris::RuntimeProfile*)::$_0::operator()() const /root/doris/be/src/vec/sink/writer/async_result_writer.cpp:103:5
liaoxin01
added a commit
to liaoxin01/doris
that referenced
this pull request
Jul 8, 2025
… leaks in MemTable (apache#52902)
liaoxin01
added a commit
to liaoxin01/doris
that referenced
this pull request
Jul 8, 2025
… leaks in MemTable (apache#52902)
liaoxin01
added a commit
to liaoxin01/doris
that referenced
this pull request
Jul 8, 2025
… leaks in MemTable (apache#52902)
liaoxin01
added a commit
to liaoxin01/doris
that referenced
this pull request
Jul 8, 2025
… leaks in MemTable (apache#52902) Issue Number: close #xxx Related PR: #xxx Problem Summary: Direct leak of 193504 byte(s) in 6047 object(s) allocated from: (/mnt/ssd01/pipline/OpenSourceDoris/clusterEnv/P0/Cluster0/be/lib/doris_be+0x2a0015fd) const*, std::vector<unsigned int, doris::CustomStdAllocator<unsigned int, doris::Allocator<false, false, false, doris::DefaultMemoryAllocator> > > const&) /root/doris/be/src/olap/memtable.cpp:243:38 doris::MemTableWriter::write(doris::vectorized::Block const*, std::vector<unsigned int, doris::CustomStdAllocator<unsigned int, doris::Allocator<false, false, false, doris::DefaultMemoryAllocator> > > const&) /root/doris/be/src/olap/memtable_writer.cpp:107:27 doris::DeltaWriterV2::write(doris::vectorized::Block const*, std::vector<unsigned int, doris::CustomStdAllocator<unsigned int, doris::Allocator<false, false, false, doris::DefaultMemoryAllocator> > > const&) /root/doris/be/src/olap/delta_writer_v2.cpp:164:30 doris::vectorized::VTabletWriterV2::_write_memtable(std::shared_ptr<doris::vectorized::Block>, long, doris::vectorized::Rows const&) /root/doris/be/src/vec/sink/writer/vtablet_writer_v2.cpp:552:24 doris::vectorized::VTabletWriterV2::write(doris::RuntimeState*, doris::vectorized::Block&) /root/doris/be/src/vec/sink/writer/vtablet_writer_v2.cpp:486:9 doris::vectorized::AsyncResultWriter::process_block(doris::RuntimeState*, doris::RuntimeProfile*) /root/doris/be/src/vec/sink/writer/async_result_writer.cpp:169:23 doris::vectorized::AsyncResultWriter::start_writer(doris::RuntimeState*, doris::RuntimeProfile*)::$_0::operator()() const /root/doris/be/src/vec/sink/writer/async_result_writer.cpp:103:5
16 tasks
liaoxin01
added a commit
to liaoxin01/doris
that referenced
this pull request
Jul 8, 2025
… leaks in MemTable (apache#52902) Issue Number: close #xxx Related PR: #xxx Problem Summary: Direct leak of 193504 byte(s) in 6047 object(s) allocated from: (/mnt/ssd01/pipline/OpenSourceDoris/clusterEnv/P0/Cluster0/be/lib/doris_be+0x2a0015fd) const*, std::vector<unsigned int, doris::CustomStdAllocator<unsigned int, doris::Allocator<false, false, false, doris::DefaultMemoryAllocator> > > const&) /root/doris/be/src/olap/memtable.cpp:243:38 doris::MemTableWriter::write(doris::vectorized::Block const*, std::vector<unsigned int, doris::CustomStdAllocator<unsigned int, doris::Allocator<false, false, false, doris::DefaultMemoryAllocator> > > const&) /root/doris/be/src/olap/memtable_writer.cpp:107:27 doris::DeltaWriterV2::write(doris::vectorized::Block const*, std::vector<unsigned int, doris::CustomStdAllocator<unsigned int, doris::Allocator<false, false, false, doris::DefaultMemoryAllocator> > > const&) /root/doris/be/src/olap/delta_writer_v2.cpp:164:30 doris::vectorized::VTabletWriterV2::_write_memtable(std::shared_ptr<doris::vectorized::Block>, long, doris::vectorized::Rows const&) /root/doris/be/src/vec/sink/writer/vtablet_writer_v2.cpp:552:24 doris::vectorized::VTabletWriterV2::write(doris::RuntimeState*, doris::vectorized::Block&) /root/doris/be/src/vec/sink/writer/vtablet_writer_v2.cpp:486:9 doris::vectorized::AsyncResultWriter::process_block(doris::RuntimeState*, doris::RuntimeProfile*) /root/doris/be/src/vec/sink/writer/async_result_writer.cpp:169:23 doris::vectorized::AsyncResultWriter::start_writer(doris::RuntimeState*, doris::RuntimeProfile*)::$_0::operator()() const /root/doris/be/src/vec/sink/writer/async_result_writer.cpp:103:5
liaoxin01
added a commit
to liaoxin01/doris
that referenced
this pull request
Jul 8, 2025
… leaks in MemTable (apache#52902) Issue Number: close #xxx Related PR: #xxx Problem Summary: Direct leak of 193504 byte(s) in 6047 object(s) allocated from: (/mnt/ssd01/pipline/OpenSourceDoris/clusterEnv/P0/Cluster0/be/lib/doris_be+0x2a0015fd) const*, std::vector<unsigned int, doris::CustomStdAllocator<unsigned int, doris::Allocator<false, false, false, doris::DefaultMemoryAllocator> > > const&) /root/doris/be/src/olap/memtable.cpp:243:38 doris::MemTableWriter::write(doris::vectorized::Block const*, std::vector<unsigned int, doris::CustomStdAllocator<unsigned int, doris::Allocator<false, false, false, doris::DefaultMemoryAllocator> > > const&) /root/doris/be/src/olap/memtable_writer.cpp:107:27 doris::DeltaWriterV2::write(doris::vectorized::Block const*, std::vector<unsigned int, doris::CustomStdAllocator<unsigned int, doris::Allocator<false, false, false, doris::DefaultMemoryAllocator> > > const&) /root/doris/be/src/olap/delta_writer_v2.cpp:164:30 doris::vectorized::VTabletWriterV2::_write_memtable(std::shared_ptr<doris::vectorized::Block>, long, doris::vectorized::Rows const&) /root/doris/be/src/vec/sink/writer/vtablet_writer_v2.cpp:552:24 doris::vectorized::VTabletWriterV2::write(doris::RuntimeState*, doris::vectorized::Block&) /root/doris/be/src/vec/sink/writer/vtablet_writer_v2.cpp:486:9 doris::vectorized::AsyncResultWriter::process_block(doris::RuntimeState*, doris::RuntimeProfile*) /root/doris/be/src/vec/sink/writer/async_result_writer.cpp:169:23 doris::vectorized::AsyncResultWriter::start_writer(doris::RuntimeState*, doris::RuntimeProfile*)::$_0::operator()() const /root/doris/be/src/vec/sink/writer/async_result_writer.cpp:103:5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Direct leak of 193504 byte(s) in 6047 object(s) allocated from:
#0 0x559f1d2a45fd in operator new(unsigned long) (/mnt/ssd01/pipline/OpenSourceDoris/clusterEnv/P0/Cluster0/be/lib/doris_be+0x2a0015fd)
#1 0x559f1f54c41d in doris::MemTable::insert(doris::vectorized::Block const*, std::vector<unsigned int, doris::CustomStdAllocator<unsigned int, doris::Allocator<false, false, false, doris::DefaultMemoryAllocator> > > const&) /root/doris/be/src/olap/memtable.cpp:243:38
#2 0x559f1f597c08 in doris::MemTableWriter::write(doris::vectorized::Block const*, std::vector<unsigned int, doris::CustomStdAllocator<unsigned int, doris::Allocator<false, false, false, doris::DefaultMemoryAllocator> > > const&) /root/doris/be/src/olap/memtable_writer.cpp:107:27
#3 0x559f467a48c0 in doris::DeltaWriterV2::write(doris::vectorized::Block const*, std::vector<unsigned int, doris::CustomStdAllocator<unsigned int, doris::Allocator<false, false, false, doris::DefaultMemoryAllocator> > > const&) /root/doris/be/src/olap/delta_writer_v2.cpp:164:30
#4 0x559f4711e2f5 in doris::vectorized::VTabletWriterV2::_write_memtable(std::shared_ptrdoris::vectorized::Block, long, doris::vectorized::Rows const&) /root/doris/be/src/vec/sink/writer/vtablet_writer_v2.cpp:552:24
#5 0x559f4711b4bf in doris::vectorized::VTabletWriterV2::write(doris::RuntimeState*, doris::vectorized::Block&) /root/doris/be/src/vec/sink/writer/vtablet_writer_v2.cpp:486:9
#6 0x559f4702bb4b in doris::vectorized::AsyncResultWriter::process_block(doris::RuntimeState*, doris::RuntimeProfile*) /root/doris/be/src/vec/sink/writer/async_result_writer.cpp:169:23
#7 0x559f4702e7e8 in doris::vectorized::AsyncResultWriter::start_writer(doris::RuntimeState*, doris::RuntimeProfile*)::$_0::operator()() const /root/doris/be/src/vec/sink/writer/async_result_writer.cpp:103:5
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)