[opt](load) avoid over-flushing active memtables in memory limiter#52906
Merged
dataroaring merged 3 commits intoapache:masterfrom Jul 11, 2025
Merged
[opt](load) avoid over-flushing active memtables in memory limiter#52906dataroaring merged 3 commits intoapache:masterfrom
dataroaring merged 3 commits intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
gavinchou
previously approved these changes
Jul 7, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 33042 ms |
TPC-DS: Total hot run time: 184378 ms |
ClickBench: Total hot run time: 29.52 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Member
Author
|
run buildall |
TPC-H: Total hot run time: 33236 ms |
TPC-DS: Total hot run time: 186265 ms |
ClickBench: Total hot run time: 30.14 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
5adc296 to
fa80c13
Compare
Contributor
|
run buildall |
TPC-H: Total hot run time: 33293 ms |
TPC-DS: Total hot run time: 187285 ms |
ClickBench: Total hot run time: 29.49 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
|
PR approved by at least one committer and no changes requested. |
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Jul 25, 2025
…pache#52906) Related PR: apache#41018 Problem Summary: Update the `_need_flush()` function to subtract both `_queue_mem_usage` and `_flush_mem_usage` when deciding how much memory needs to be flushed. Previously, we only subtracted `_queue_mem_usage`, which could lead to flushing more active memtables than necessary. This change ensures that only the required amount of active memtable memory is flushed, avoiding premature flushes. This helps prevent creating small segments, which can hurt performance and storage efficiency.
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Jul 25, 2025
…pache#52906) Related PR: apache#41018 Problem Summary: Update the `_need_flush()` function to subtract both `_queue_mem_usage` and `_flush_mem_usage` when deciding how much memory needs to be flushed. Previously, we only subtracted `_queue_mem_usage`, which could lead to flushing more active memtables than necessary. This change ensures that only the required amount of active memtable memory is flushed, avoiding premature flushes. This helps prevent creating small segments, which can hurt performance and storage efficiency.
This was referenced Jul 25, 2025
dataroaring
pushed a commit
that referenced
this pull request
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related PR: #41018
Problem Summary:
Update the
_need_flush()function to subtract both_queue_mem_usageand_flush_mem_usagewhen deciding how much memory needs to be flushed.Previously, we only subtracted
_queue_mem_usage, which could lead to flushing more active memtables than necessary.This change ensures that only the required amount of active memtable memory is flushed, avoiding premature flushes.
This helps prevent creating small segments, which can hurt performance and storage efficiency.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)