Skip to content

branch-3.1: [improve](planner) select * unique_table limit n should use one instance #53948#54186

Merged
morrySnow merged 1 commit intobranch-3.1from
auto-pick-53948-branch-3.1
Aug 4, 2025
Merged

branch-3.1: [improve](planner) select * unique_table limit n should use one instance #53948#54186
morrySnow merged 1 commit intobranch-3.1from
auto-pick-53948-branch-3.1

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Aug 1, 2025

Cherry-picked from #53948

…nce (#53948)

### What problem does this PR solve?
Problem Summary:
the unique_table has a condition of delete_sign = 0 awalys,
so it's not have plan for one instance to scan table,
now add some check for unique_table let running only one instance for
select limit n.
@github-actions github-actions bot requested a review from morrySnow as a code owner August 1, 2025 06:16
@morrySnow morrySnow closed this Aug 1, 2025
@morrySnow morrySnow reopened this Aug 1, 2025
@morrySnow
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32598 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 65c3634ce168182c99a13e84c2531906a9212ff1, data reload: false

------ Round 1 ----------------------------------
q1	17581	5455	5395	5395
q2	2065	302	178	178
q3	10631	1221	754	754
q4	10341	873	447	447
q5	9643	2364	2104	2104
q6	194	169	140	140
q7	907	740	633	633
q8	9310	1438	1249	1249
q9	5229	4876	4884	4876
q10	6744	2302	1810	1810
q11	503	285	272	272
q12	335	352	206	206
q13	17805	3599	3023	3023
q14	234	223	221	221
q15	556	466	472	466
q16	422	437	391	391
q17	607	856	366	366
q18	6870	6491	6298	6298
q19	1354	953	562	562
q20	329	348	207	207
q21	2969	2172	2033	2033
q22	1050	1038	967	967
Total cold run time: 105679 ms
Total hot run time: 32598 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5554	5523	5564	5523
q2	238	324	229	229
q3	2285	2625	2343	2343
q4	1426	1874	1357	1357
q5	4411	5008	5072	5008
q6	171	164	134	134
q7	2167	2050	1877	1877
q8	2662	2830	2687	2687
q9	7345	7190	7201	7190
q10	3013	3324	2803	2803
q11	564	490	495	490
q12	609	731	619	619
q13	3410	3805	3145	3145
q14	275	297	287	287
q15	517	474	456	456
q16	449	491	429	429
q17	1232	1721	1266	1266
q18	7596	7499	7273	7273
q19	811	1075	1147	1075
q20	1977	2025	1923	1923
q21	5292	4838	4613	4613
q22	1099	1094	984	984
Total cold run time: 53103 ms
Total hot run time: 51711 ms

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.42% (12638/27822)
Line Coverage 36.27% (112661/310624)
Region Coverage 35.32% (58242/164899)
Branch Coverage 32.51% (31669/97420)

@doris-robot
Copy link

TPC-DS: Total hot run time: 195766 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 65c3634ce168182c99a13e84c2531906a9212ff1, data reload: false

query1	1310	960	896	896
query2	6241	1966	1968	1966
query3	10983	4422	4272	4272
query4	32875	23796	23182	23182
query5	3778	617	463	463
query6	285	198	193	193
query7	3991	490	333	333
query8	316	251	239	239
query9	9445	2600	2590	2590
query10	483	335	264	264
query11	18003	15477	15138	15138
query12	171	107	105	105
query13	1556	540	432	432
query14	9799	6626	7560	6626
query15	258	216	182	182
query16	7978	688	510	510
query17	1635	764	611	611
query18	2147	421	318	318
query19	239	196	169	169
query20	128	125	120	120
query21	211	126	111	111
query22	4525	4620	4342	4342
query23	35326	34511	33740	33740
query24	7437	2736	2743	2736
query25	543	513	422	422
query26	819	293	179	179
query27	2151	493	348	348
query28	5601	2248	2177	2177
query29	684	603	474	474
query30	238	187	157	157
query31	1020	923	833	833
query32	87	61	61	61
query33	486	374	311	311
query34	755	882	543	543
query35	803	826	738	738
query36	1012	1043	965	965
query37	99	87	67	67
query38	3989	3957	3955	3955
query39	1558	1474	1630	1474
query40	206	115	104	104
query41	49	48	46	46
query42	121	102	103	102
query43	496	556	506	506
query44	1362	844	841	841
query45	187	182	171	171
query46	883	1071	687	687
query47	1908	1944	1902	1902
query48	411	433	352	352
query49	728	501	403	403
query50	685	709	444	444
query51	7402	7347	7123	7123
query52	100	99	92	92
query53	230	263	201	201
query54	567	570	467	467
query55	81	76	79	76
query56	289	281	268	268
query57	1268	1253	1204	1204
query58	246	217	217	217
query59	3002	3204	3044	3044
query60	292	283	261	261
query61	148	180	170	170
query62	813	749	691	691
query63	230	198	192	192
query64	3540	999	654	654
query65	3345	3288	3283	3283
query66	779	410	300	300
query67	16460	15841	15641	15641
query68	8261	842	552	552
query69	506	304	271	271
query70	1221	1122	1110	1110
query71	444	284	269	269
query72	5174	3758	3788	3758
query73	655	749	357	357
query74	10849	9391	9021	9021
query75	4076	3119	2745	2745
query76	3657	1173	773	773
query77	775	373	275	275
query78	10252	10366	9444	9444
query79	2796	896	602	602
query80	760	522	431	431
query81	481	268	217	217
query82	401	117	91	91
query83	169	158	149	149
query84	288	105	88	88
query85	750	389	300	300
query86	341	318	307	307
query87	4357	4364	4193	4193
query88	3437	2451	2396	2396
query89	419	336	300	300
query90	1943	197	196	196
query91	136	142	108	108
query92	67	56	51	51
query93	1183	890	546	546
query94	638	408	307	307
query95	346	287	270	270
query96	495	600	283	283
query97	3169	3245	3194	3194
query98	228	209	208	208
query99	1525	1412	1270	1270
Total cold run time: 294592 ms
Total hot run time: 195766 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.94 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 65c3634ce168182c99a13e84c2531906a9212ff1, data reload: false

query1	0.04	0.03	0.04
query2	0.08	0.03	0.03
query3	0.28	0.07	0.07
query4	1.59	0.10	0.10
query5	0.50	0.53	0.49
query6	1.13	0.74	0.72
query7	0.02	0.01	0.02
query8	0.04	0.04	0.03
query9	0.56	0.50	0.48
query10	0.55	0.54	0.54
query11	0.15	0.10	0.10
query12	0.14	0.11	0.11
query13	0.61	0.58	0.60
query14	0.78	0.79	0.80
query15	0.85	0.82	0.83
query16	0.40	0.38	0.38
query17	1.09	1.02	1.02
query18	0.24	0.22	0.23
query19	1.83	1.74	1.77
query20	0.02	0.01	0.01
query21	15.40	0.93	0.57
query22	0.73	0.74	0.66
query23	15.13	1.46	0.62
query24	3.09	1.23	1.06
query25	0.14	0.11	0.14
query26	0.27	0.13	0.13
query27	0.06	0.05	0.05
query28	13.71	0.98	0.44
query29	12.61	3.97	3.28
query30	0.24	0.10	0.07
query31	2.81	0.60	0.39
query32	3.22	0.53	0.45
query33	3.03	3.00	2.98
query34	16.69	5.20	4.50
query35	4.60	4.58	4.59
query36	0.64	0.50	0.47
query37	0.08	0.06	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.17	0.13	0.14
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.05	0.04	0.03
Total cold run time: 103.77 s
Total hot run time: 28.94 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 6.67% (1/15) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.17% (20939/27489)
Line Coverage 69.62% (216114/310416)
Region Coverage 67.69% (129440/191236)
Branch Coverage 61.27% (67358/109944)

3 similar comments
@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.17% (20939/27489)
Line Coverage 69.62% (216114/310416)
Region Coverage 67.69% (129440/191236)
Branch Coverage 61.27% (67358/109944)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.17% (20939/27489)
Line Coverage 69.62% (216114/310416)
Region Coverage 67.69% (129440/191236)
Branch Coverage 61.27% (67358/109944)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.17% (20939/27489)
Line Coverage 69.62% (216114/310416)
Region Coverage 67.69% (129440/191236)
Branch Coverage 61.27% (67358/109944)

@morrySnow morrySnow merged commit 434171d into branch-3.1 Aug 4, 2025
22 of 23 checks passed
@github-actions github-actions bot deleted the auto-pick-53948-branch-3.1 branch August 4, 2025 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments