Skip to content

[fix](ubsan) Fix ubsan from glibc-compatibility/musl/logf.c#54737

Merged
airborne12 merged 3 commits intoapache:masterfrom
zhiqiang-hhhh:fix-logf-ubsan
Aug 18, 2025
Merged

[fix](ubsan) Fix ubsan from glibc-compatibility/musl/logf.c#54737
airborne12 merged 3 commits intoapache:masterfrom
zhiqiang-hhhh:fix-logf-ubsan

Conversation

@zhiqiang-hhhh
Copy link
Contributor

@zhiqiang-hhhh zhiqiang-hhhh commented Aug 14, 2025 •
edited
Loading

What problem does this PR solve?

Related PR: #54598

before 54598, logf is using impl from toolchain, after 54598, logf is using impl from doris glibc-compatibility

Analysis from gpt5:

the 0x1ff << 23 part is evaluated in type int.

0x1ff = 511 decimal.

Left-shifting it 23 bits gives 0x3ff800000 in math, which is way bigger than INT_MAX (on 32-bit signed int, any shift producing a bit in the sign position or beyond is undefined behavior in C).

Even if ix and tmp are larger types, that constant expression is first computed as an int before any promotions, triggering the UB warning from UBSan.

Fix the problem below

#0 0x5632a618a17 in logf / root/doris/be/src/glibc-compatibility/musl/logf. c: 56:25
#1 0x5632a59fec26 in std:: log(float) /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/cmath: 334:12
#2 0x5632a59fcee3 in lucene:: index: :MultiLevelSkipListWriter::MultiLevelSkipListWriter(int, int, int) /root/doris/contrib/clucene/src/core/CLucene/index/SkipListWriter.cpp:70:56
#3 0x5632a59fe497 in lucene:: index: :DefaultSkipListWriter: :DefaultSkipListWriter(int, int, int, lucene::store::IndexOutput*, lucene::store: :IndexOutput*) /root/doris/contrib/clucene/src/core/CLucene/index/SkipListWriter. cpp:175:11
+ echo 'cp -r /mnt/ssd01/pipline/0penSourceDoris/clusterEnv/PO//Cluster0/fe/bin /home/work/pipline/backup_center/54276_0b92341b39685a8528a1d769885cefe95197e7fb_p0/fe/' + cp -r /mnt/ssd01/pipline/0penSourceDoris/clusterEnv/PO//Cluster0/fe/conf /home/work/pipline/backup_center/54276_0b92341b39685a8528a1d769885cefe95197e7fb_p0/fe/
#4 0x5632a5affdb in lucene:: index:: SDocumentsWriter<char>: :writeSegment(std: :vector<std::__cxx11::basic_string<char, std: :char_traits<char>, std: :allocator<char> >, std: :allocator<std::_cxx11::basic_string<char, std:: char_traits<chars
#5 0x5632a5af009e in lucene:: index::DocumentsWriter<char>:: flush(bool) /root/doris/contrib/clucene/src/core/Lucene/index/DocumentWriter. cpp: 1340:9
#6 0x5632a5a41842 in lucene:: index:: IndexWriter:: doFlush(bool) /root/doris/contrib/clucene/src/core/CLucene/index/IndexWriter. cpp:2262:58
#7 0x5632a5a1f59b
in lucene:: index:: IndexWriter:: flush(bool, bool) / root/doris/contrib/clucene/src/core/CLucene/index/IndexWriter.cpp:2154:9
#8 0x5632a5a1dd09 in lucene:: index:: IndexWriter:: closeInternal(bool) /root/doris/contrib/clucene/src/core/CLucene/index/IndexWriter. cpp: 546:9
#9 0x5632a5a1d16e in lucene:: index:: IndexWriter:: close(bool) / root/doris/contrib/clucene/src/core/CLucene/index/IndexWriter.cpp: 519:9
#10 0x563282c28c76 in _ZN5doris10segment_v213finally_closeISt10unique_ptrIN6lucene5index11IndexWriterESt14default_deleteIS5_EEQ8HasCloseIT_EEEVRS9_RNS0_12ErrorContextE /root/doris/be/src/olap/rowset/segment_v2/inverted_index_common.h:56
#11
0x563282c3b9c2 in doris::segment_v2: :InvertedIndexColumnWriter<(doris::FieldType)17>::finish) /root/doris/be/src/olap/rowset/segment_v2/inverted
index_writer. cpp: 687:9
#12 0x563282b9fble in doris:: segment_v2::ArrayColumnWriter::write_inverted_index() /root/doris/be/src/olap/rowset/segment_v2/column_writer.cpp: 940:41
#13 0x56328248ec in doris:: segment_v2::VerticalSegmentWriter::_write_inverted_index() /root/doris/be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp: 1296:9
+ echo cp -r /mnt/ssd01/pipline/0penSourceDoris/clusterEnv/P0//Cluster0/fe/log /home/work/pipline/backup_center/54276_0b92341b39685a8528a1d769885cefe95197e7fb_p0/fe/'
#14 0x5632824d120 in doris::segment_v2::VerticalSegmentWriter::finalize_columns_indexunsigned long*) / root/doris/be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp: 1204:5
+ cp
-r /mnt/ssd01/pipline/OpenSourceDoris/clusterEnv/P0//Cluster0/fe/log /home/work/pipline/backup_center/54276_0b92341b39685a8528a1d769885cefe95197e7fb_p0/fe/
#15 0x56328251046 in doris: :segment_v2: :VerticalSegmentWriter:: finalize(unsigned long*, unsigned long*) / root/doris/be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp: 1253:5
#16
0x563282519a5a in doris: SegmentFlusher: :_flush_segment_writer(std: :unique_ptr<doris::segment_v2::VerticalSegmentWriter, std: :default_delete<doris::segment_v2: :VerticalSegmentWriter> >&, std: :shared_ptr<doris:: TabletSchema>, long*)
#17 0x56328251642f in doris::SegmentFlusher::flush_single_block(doris::vectorized::Block const*, int, long*) /root/doris/be/src/olap/rowset/segment_creator.cpp:77:9
#18 0x563282521151 in doris::SegmentCreator::flush_single_block(doris::vectorized::Block const*, int,
long*) /root/doris/be/src/olap/rowset/segment_creator.cpp: 389:5
#19
0x56329fe59dc4 in doris::BetaRowsetWriterV2:: flush_memtable(doris::vectorized::Block*, int,
long*) /root/doris/be/src/olap/rowset/beta_rowset_writer_v2.cpp: 109:9
#20
0x56328215778 in doris:: FlushToken: :_do_flush_memtable(doris::MemTable*, int, long*) / root/doris/be/src/olap/memtable_flush_executor.cpp:210:9
#21
#22
0x56328217962 in doris:: FlushToken: :_flush_memtable(std: :shared_ptr<doris::MemTable>, int, long) / root/doris/be/src/olap/memtable_flush_executor. cpp:265:16
0x5632821f1f7d in doris::MemtableFlushTask:: run() /root/doris/be/src/olap/memtable_flush_executor.cpp:63:20
#23
0x56328437d33 in doris::ThreadPool::dispatch_thread() /root/doris/be/src/util/threadpool.cpp:614:24
#24 0x56328435аабс in std:: function<void ()›::operator()() const /var/local/ldb-toolchain/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/std_function.h:593:9
#25 0x56328435aac in doris::Thread:: supervise_thread(void*) / root/doris/be/src/util/thread. cpp: 461:5
#26
0x56327fc4fd26 in asan_thread_start(void*) (/mnt/ssd01/pipline/0penSourceDoris/clusterEnv/P0/Cluster0/be/lib/doris_be+0x28da4d26)
#27 0x7fdd62967608 in start_thread /build/glibc-SzIz7B/glibc-2.31/nptl/pthread_create.c: 477:8
#28 0x7fdd6287a132 in _clone /build/glibc-SzIz7B/glibc-2.31/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S: 95

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Aug 14, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhiqiang-hhhh
Copy link
Contributor Author

zhiqiang-hhhh commented Aug 14, 2025

run buildall

@zhiqiang-hhhh
Copy link
Contributor Author

zhiqiang-hhhh commented Aug 14, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Aug 14, 2025

TPC-H: Total hot run time: 33981 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8d40890305c3946db8b35a1ddde29662a7484713, data reload: false

------ Round 1 ----------------------------------
q1	17613	5249	5058	5058
q2	1909	279	182	182
q3	10325	1271	712	712
q4	10212	1001	524	524
q5	7534	2427	2329	2329
q6	180	160	131	131
q7	910	743	605	605
q8	9302	1311	1126	1126
q9	7005	5176	5068	5068
q10	6935	2372	1936	1936
q11	477	284	258	258
q12	338	349	217	217
q13	17763	3774	3045	3045
q14	240	225	220	220
q15	554	477	487	477
q16	413	414	380	380
q17	589	858	364	364
q18	7378	7205	6983	6983
q19	1087	943	567	567
q20	330	347	206	206
q21	4149	2603	2955	2603
q22	1084	1040	990	990
Total cold run time: 106327 ms
Total hot run time: 33981 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5236	5235	5173	5173
q2	238	318	214	214
q3	2199	2734	2382	2382
q4	1429	1815	1444	1444
q5	4290	4515	4629	4515
q6	223	164	129	129
q7	2171	1926	1838	1838
q8	2659	2743	2609	2609
q9	7265	7308	7446	7308
q10	3052	3298	2906	2906
q11	590	507	515	507
q12	697	772	618	618
q13	3675	3853	3323	3323
q14	292	301	286	286
q15	547	472	493	472
q16	489	536	451	451
q17	1204	1628	1368	1368
q18	7814	7902	7563	7563
q19	786	842	953	842
q20	2038	2012	1788	1788
q21	4693	4445	4227	4227
q22	1055	1049	984	984
Total cold run time: 52642 ms
Total hot run time: 50947 ms

@doris-robot
Copy link

doris-robot commented Aug 14, 2025

TPC-DS: Total hot run time: 183865 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8d40890305c3946db8b35a1ddde29662a7484713, data reload: false

query1	986	381	405	381
query2	6526	1738	1696	1696
query3	6734	215	220	215
query4	26455	23579	22908	22908
query5	4364	619	474	474
query6	321	218	202	202
query7	4620	498	290	290
query8	277	229	215	215
query9	8580	2837	2834	2834
query10	472	333	263	263
query11	15890	14898	14713	14713
query12	154	107	111	107
query13	1635	516	410	410
query14	9269	5712	5670	5670
query15	213	189	175	175
query16	7321	635	446	446
query17	1192	713	598	598
query18	2013	421	322	322
query19	191	190	164	164
query20	126	121	118	118
query21	213	123	110	110
query22	4307	4171	4188	4171
query23	34041	33321	33110	33110
query24	8093	2327	2341	2327
query25	573	547	393	393
query26	716	264	156	156
query27	2701	508	337	337
query28	4367	2205	2185	2185
query29	669	564	441	441
query30	287	213	187	187
query31	880	804	705	705
query32	84	73	72	72
query33	541	423	329	329
query34	776	839	500	500
query35	843	814	705	705
query36	955	1022	931	931
query37	123	107	86	86
query38	4055	4015	3980	3980
query39	1472	1417	1436	1417
query40	219	125	109	109
query41	58	58	54	54
query42	119	111	111	111
query43	498	496	467	467
query44	1318	831	843	831
query45	170	180	165	165
query46	842	995	627	627
query47	1758	1800	1693	1693
query48	386	411	303	303
query49	683	480	381	381
query50	627	670	388	388
query51	4028	4082	4037	4037
query52	112	110	99	99
query53	227	253	191	191
query54	582	582	519	519
query55	86	85	91	85
query56	308	301	290	290
query57	1177	1180	1104	1104
query58	277	260	300	260
query59	2735	2709	2664	2664
query60	334	336	311	311
query61	131	120	125	120
query62	806	717	659	659
query63	232	188	184	184
query64	3098	1010	729	729
query65	4301	4166	4194	4166
query66	1065	408	325	325
query67	15473	15260	15037	15037
query68	8468	904	553	553
query69	472	319	272	272
query70	1200	1094	1120	1094
query71	446	330	304	304
query72	5559	4806	4953	4806
query73	775	668	349	349
query74	9218	9086	8827	8827
query75	3856	3113	2592	2592
query76	3590	1114	737	737
query77	794	394	314	314
query78	9662	9778	8899	8899
query79	2348	791	589	589
query80	593	518	451	451
query81	498	252	218	218
query82	455	136	104	104
query83	248	254	228	228
query84	243	101	81	81
query85	796	376	369	369
query86	389	312	291	291
query87	4178	4302	4185	4185
query88	3380	2124	2119	2119
query89	392	306	274	274
query90	1842	220	214	214
query91	137	135	106	106
query92	87	69	65	65
query93	1678	955	625	625
query94	679	400	311	311
query95	383	305	303	303
query96	471	564	268	268
query97	2624	2731	2543	2543
query98	246	221	207	207
query99	1347	1371	1315	1315
Total cold run time: 271739 ms
Total hot run time: 183865 ms

@doris-robot
Copy link

doris-robot commented Aug 14, 2025

ClickBench: Total hot run time: 32.07 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8d40890305c3946db8b35a1ddde29662a7484713, data reload: false

query1	0.05	0.04	0.03
query2	0.09	0.05	0.05
query3	0.24	0.06	0.07
query4	1.63	0.11	0.11
query5	0.43	0.40	0.40
query6	1.15	0.64	0.64
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.59	0.51	0.51
query10	0.58	0.57	0.57
query11	0.16	0.11	0.12
query12	0.15	0.12	0.11
query13	0.62	0.60	0.61
query14	0.80	0.81	0.82
query15	0.91	0.85	0.88
query16	0.40	0.40	0.39
query17	1.08	1.03	1.07
query18	0.22	0.19	0.20
query19	1.96	1.82	1.88
query20	0.02	0.02	0.01
query21	15.42	0.90	0.56
query22	0.74	1.20	0.68
query23	14.94	1.37	0.63
query24	6.55	1.33	0.42
query25	0.48	0.17	0.12
query26	0.66	0.15	0.13
query27	0.06	0.06	0.05
query28	10.10	0.93	0.42
query29	12.59	3.83	3.23
query30	3.12	3.04	2.93
query31	2.82	0.58	0.39
query32	3.23	0.55	0.47
query33	3.08	3.09	3.16
query34	16.09	5.47	4.88
query35	4.97	4.88	4.93
query36	0.70	0.50	0.49
query37	0.09	0.08	0.07
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.17	0.15	0.15
query41	0.08	0.03	0.02
query42	0.03	0.03	0.02
query43	0.03	0.04	0.04
Total cold run time: 107.17 s
Total hot run time: 32.07 s

@doris-robot
Copy link

doris-robot commented Aug 14, 2025

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 59.50% (16786/28213)
Line Coverage 48.43% (152619/315127)
Region Coverage 37.39% (116017/310263)
Branch Coverage 40.31% (51194/126993)

@zhiqiang-hhhh
Copy link
Contributor Author

zhiqiang-hhhh commented Aug 14, 2025

run external

@zhiqiang-hhhh
Copy link
Contributor Author

zhiqiang-hhhh commented Aug 14, 2025

run vault_p0

@zhiqiang-hhhh
Copy link
Contributor Author

zhiqiang-hhhh commented Aug 14, 2025

run cloud_p0

zzzxl1993
zzzxl1993 approved these changes Aug 14, 2025
View reviewed changes
Copy link
Contributor

@zzzxl1993 zzzxl1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2025

PR approved by anyone and no changes requested.

@airborne12
Copy link
Member

airborne12 commented Aug 14, 2025

Do not use image in problem description, paste text instead

@zhiqiang-hhhh
Copy link
Contributor Author

zhiqiang-hhhh commented Aug 14, 2025

Do not use image in problem description, paste text instead

Fixed

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 14, 2025

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 81.87% (22632/27643)
Line Coverage 74.57% (234811/314901)
Region Coverage 61.72% (194719/315504)
Branch Coverage 65.97% (84393/127926)

@zhiqiang-hhhh
Copy link
Contributor Author

zhiqiang-hhhh commented Aug 14, 2025

run cloud_p0

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 14, 2025

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 81.87% (22632/27643)
Line Coverage 74.57% (234811/314901)
Region Coverage 61.72% (194719/315504)
Branch Coverage 65.97% (84393/127926)

@zhiqiang-hhhh
Copy link
Contributor Author

zhiqiang-hhhh commented Aug 14, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Aug 14, 2025

TPC-H: Total hot run time: 33629 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a26d7400e10b81f6a032251e19c098f38ffd6255, data reload: false

------ Round 1 ----------------------------------
q1	17572	5150	5145	5145
q2	1919	278	184	184
q3	10317	1248	702	702
q4	10229	1012	525	525
q5	7524	2205	2337	2205
q6	177	158	134	134
q7	874	758	597	597
q8	9301	1278	1073	1073
q9	6824	5206	5143	5143
q10	6935	2398	1962	1962
q11	475	289	275	275
q12	344	346	217	217
q13	17781	3625	2997	2997
q14	232	244	222	222
q15	549	487	498	487
q16	423	409	374	374
q17	587	831	368	368
q18	7410	6937	7023	6937
q19	1228	926	569	569
q20	336	331	216	216
q21	3792	3135	2337	2337
q22	1078	1036	960	960
Total cold run time: 105907 ms
Total hot run time: 33629 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5188	5095	5084	5084
q2	243	321	223	223
q3	2173	2671	2280	2280
q4	1340	1754	1368	1368
q5	4221	4302	4481	4302
q6	214	168	132	132
q7	2043	1920	1819	1819
q8	2598	2663	2670	2663
q9	7312	7264	7356	7264
q10	3079	3309	2847	2847
q11	560	542	519	519
q12	696	771	670	670
q13	3546	3984	3395	3395
q14	297	305	274	274
q15	512	470	473	470
q16	438	500	477	477
q17	1238	1590	1386	1386
q18	7774	7597	7567	7567
q19	874	820	801	801
q20	1863	1946	1795	1795
q21	4668	4380	4167	4167
q22	1070	1044	1006	1006
Total cold run time: 51947 ms
Total hot run time: 50509 ms

@doris-robot
Copy link

doris-robot commented Aug 14, 2025

TPC-DS: Total hot run time: 184446 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a26d7400e10b81f6a032251e19c098f38ffd6255, data reload: false

query1	960	382	403	382
query2	6515	1754	1744	1744
query3	6766	216	218	216
query4	26205	23668	23259	23259
query5	4356	629	473	473
query6	291	201	211	201
query7	4627	505	279	279
query8	271	231	214	214
query9	8544	2843	2811	2811
query10	456	320	284	284
query11	15833	14968	14771	14771
query12	162	115	115	115
query13	1672	549	434	434
query14	8602	5892	5810	5810
query15	218	197	183	183
query16	7294	655	460	460
query17	1211	737	593	593
query18	2005	417	306	306
query19	182	182	165	165
query20	135	121	118	118
query21	218	116	105	105
query22	4143	4122	4064	4064
query23	34563	33350	33249	33249
query24	8055	2374	2342	2342
query25	529	469	385	385
query26	1232	267	181	181
query27	2742	517	339	339
query28	4332	2211	2194	2194
query29	750	549	469	469
query30	280	218	192	192
query31	857	791	710	710
query32	79	71	69	69
query33	576	361	321	321
query34	789	849	494	494
query35	767	823	744	744
query36	972	1023	906	906
query37	118	106	87	87
query38	3970	4062	3957	3957
query39	1470	1400	1407	1400
query40	218	126	122	122
query41	59	54	52	52
query42	113	104	105	104
query43	515	501	471	471
query44	1325	843	838	838
query45	181	165	163	163
query46	920	1001	629	629
query47	1759	1827	1723	1723
query48	378	401	311	311
query49	689	466	381	381
query50	635	690	382	382
query51	4093	4082	4062	4062
query52	116	114	102	102
query53	234	257	184	184
query54	590	579	524	524
query55	90	86	84	84
query56	316	299	280	280
query57	1166	1192	1151	1151
query58	282	259	261	259
query59	2575	2700	2569	2569
query60	363	335	323	323
query61	130	125	121	121
query62	807	754	647	647
query63	224	185	185	185
query64	4308	1008	691	691
query65	4276	4217	4202	4202
query66	1151	396	329	329
query67	15411	15229	14884	14884
query68	6963	906	565	565
query69	488	314	265	265
query70	1232	1091	1137	1091
query71	419	334	325	325
query72	5671	4711	4764	4711
query73	666	616	349	349
query74	9156	9122	8863	8863
query75	3247	3061	2594	2594
query76	3185	1127	732	732
query77	472	402	326	326
query78	9592	9609	8950	8950
query79	2290	792	589	589
query80	673	539	454	454
query81	515	249	214	214
query82	389	132	112	112
query83	255	309	230	230
query84	243	98	84	84
query85	819	366	318	318
query86	399	312	303	303
query87	4327	4348	4162	4162
query88	2808	2161	2149	2149
query89	379	307	285	285
query90	1955	218	207	207
query91	142	141	109	109
query92	91	72	62	62
query93	2396	968	630	630
query94	703	400	299	299
query95	388	317	310	310
query96	475	578	274	274
query97	2634	2696	2592	2592
query98	242	212	212	212
query99	1302	1384	1281	1281
Total cold run time: 270187 ms
Total hot run time: 184446 ms

@doris-robot
Copy link

doris-robot commented Aug 14, 2025

ClickBench: Total hot run time: 32.34 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a26d7400e10b81f6a032251e19c098f38ffd6255, data reload: false

query1	0.04	0.03	0.04
query2	0.09	0.04	0.04
query3	0.25	0.07	0.08
query4	1.62	0.10	0.11
query5	0.44	0.43	0.39
query6	1.15	0.63	0.66
query7	0.02	0.01	0.02
query8	0.05	0.04	0.03
query9	0.60	0.52	0.52
query10	0.58	0.57	0.57
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.62	0.60	0.60
query14	0.81	0.82	0.82
query15	0.87	0.84	0.85
query16	0.39	0.41	0.39
query17	1.05	1.04	1.06
query18	0.21	0.20	0.20
query19	1.93	1.84	1.83
query20	0.02	0.01	0.01
query21	15.40	0.88	0.54
query22	0.78	1.41	0.88
query23	14.71	1.36	0.59
query24	6.77	1.85	0.56
query25	0.55	0.17	0.11
query26	0.55	0.16	0.13
query27	0.06	0.04	0.05
query28	9.96	0.93	0.43
query29	12.88	3.92	3.23
query30	3.11	3.05	2.98
query31	2.82	0.58	0.38
query32	3.25	0.55	0.48
query33	3.11	3.08	3.08
query34	16.20	5.42	4.87
query35	4.90	4.93	4.85
query36	0.70	0.51	0.49
query37	0.09	0.08	0.08
query38	0.06	0.05	0.04
query39	0.03	0.03	0.02
query40	0.18	0.14	0.14
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 107.3 s
Total hot run time: 32.34 s

@doris-robot
Copy link

doris-robot commented Aug 14, 2025

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 59.48% (16784/28216)
Line Coverage 48.43% (152617/315146)
Region Coverage 37.39% (116013/310274)
Branch Coverage 40.31% (51197/127011)

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 14, 2025

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 81.86% (22632/27646)
Line Coverage 74.58% (234869/314920)
Region Coverage 61.82% (195067/315515)
Branch Coverage 65.96% (84392/127944)

airborne12
airborne12 approved these changes Aug 18, 2025
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2025

PR approved by at least one committer and no changes requested.

@airborne12 airborne12 merged commit e371014 into apache:master Aug 18, 2025
25 of 26 checks passed
@zhiqiang-hhhh zhiqiang-hhhh deleted the fix-logf-ubsan branch August 18, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@airborne12 airborne12 airborne12 approved these changes

@zzzxl1993 zzzxl1993 zzzxl1993 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zhiqiang-hhhh @Thearas @doris-robot @airborne12 @hello-stephen @zzzxl1993

Comments