Skip to content

[fix](connection)Fixes session-related data is not cleared when the connection is disconnected due to timeout.#55008

Merged
morrySnow merged 8 commits intoapache:masterfrom
zddr:fix_ctx_cleanup
Aug 27, 2025
Merged

[fix](connection)Fixes session-related data is not cleared when the connection is disconnected due to timeout.#55008
morrySnow merged 8 commits intoapache:masterfrom
zddr:fix_ctx_cleanup

Conversation

@zddr
Copy link
Contributor

@zddr zddr commented Aug 19, 2025 •
edited
Loading

What problem does this PR solve?

bug:

  1. create temporary table c(id int) properties("replication_num" = "1");
  2. set wait_timeout=5;
  3. When show data, can always see the temporary table

Additionally, in this scenario, the aliveSessionSet also cannot be properly cleared.

fix:

When the connection is lost, don't just call closeChannel—call cleanup instead.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Aug 19, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zddr
Copy link
Contributor Author

zddr commented Aug 19, 2025

run buildall

@zddr
Copy link
Contributor Author

zddr commented Aug 19, 2025

run buildall

1 similar comment
@zddr
Copy link
Contributor Author

zddr commented Aug 19, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Aug 19, 2025

TPC-H: Total hot run time: 34712 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 62d775b41eeee6e17c928a55ccdd533a6a7cd7a8, data reload: false

------ Round 1 ----------------------------------
q1	17589	5233	5251	5233
q2	1928	279	182	182
q3	10324	1269	719	719
q4	10215	982	504	504
q5	7518	2355	2294	2294
q6	177	161	133	133
q7	897	744	627	627
q8	9365	1303	1112	1112
q9	7311	5375	5186	5186
q10	7237	2409	1996	1996
q11	508	292	279	279
q12	345	354	216	216
q13	17853	3657	2997	2997
q14	228	236	219	219
q15	552	473	479	473
q16	446	421	375	375
q17	600	849	357	357
q18	7381	7027	6997	6997
q19	1089	939	550	550
q20	336	324	221	221
q21	3902	3207	3075	3075
q22	1065	1034	967	967
Total cold run time: 106866 ms
Total hot run time: 34712 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5113	5078	5088	5078
q2	239	323	224	224
q3	2127	2683	2255	2255
q4	1338	1752	1363	1363
q5	4175	4537	4495	4495
q6	206	168	125	125
q7	2037	1936	1809	1809
q8	2615	2736	2589	2589
q9	7297	7246	7235	7235
q10	3059	3345	3202	3202
q11	580	516	495	495
q12	677	818	599	599
q13	3546	3842	3267	3267
q14	447	297	265	265
q15	527	490	461	461
q16	416	494	443	443
q17	1147	1556	1331	1331
q18	7785	7579	7573	7573
q19	832	778	844	778
q20	2075	2058	2089	2058
q21	5007	4430	4351	4351
q22	1065	1025	969	969
Total cold run time: 52310 ms
Total hot run time: 50965 ms

@doris-robot
Copy link

doris-robot commented Aug 19, 2025

TPC-DS: Total hot run time: 184659 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 62d775b41eeee6e17c928a55ccdd533a6a7cd7a8, data reload: false

query1	1000	378	428	378
query2	6536	1731	1694	1694
query3	6743	218	214	214
query4	26258	23532	23250	23250
query5	4360	641	479	479
query6	297	221	208	208
query7	4630	502	293	293
query8	290	242	217	217
query9	8646	2873	2809	2809
query10	494	318	291	291
query11	15570	15267	14779	14779
query12	168	116	118	116
query13	1657	549	431	431
query14	9366	5724	5665	5665
query15	207	187	174	174
query16	7320	645	468	468
query17	1210	738	598	598
query18	2012	425	319	319
query19	193	197	165	165
query20	133	124	119	119
query21	209	127	110	110
query22	4094	4143	4145	4143
query23	34118	33243	33755	33243
query24	8128	2342	2359	2342
query25	555	486	393	393
query26	1246	265	158	158
query27	2739	499	342	342
query28	4341	2197	2185	2185
query29	737	560	467	467
query30	281	216	188	188
query31	885	786	718	718
query32	86	74	77	74
query33	551	372	342	342
query34	789	821	516	516
query35	799	852	732	732
query36	973	989	945	945
query37	117	105	81	81
query38	4114	4020	3960	3960
query39	1491	1414	1403	1403
query40	209	123	121	121
query41	60	60	77	60
query42	123	108	112	108
query43	512	495	460	460
query44	1318	842	828	828
query45	178	167	158	158
query46	848	993	640	640
query47	1738	1803	1691	1691
query48	400	409	318	318
query49	716	499	391	391
query50	624	699	401	401
query51	4079	4175	4058	4058
query52	114	109	98	98
query53	264	264	198	198
query54	591	591	514	514
query55	85	84	87	84
query56	325	314	297	297
query57	1169	1186	1111	1111
query58	284	265	270	265
query59	2671	2772	2563	2563
query60	336	331	326	326
query61	130	124	127	124
query62	839	730	677	677
query63	236	185	181	181
query64	4307	1067	744	744
query65	4299	4195	4188	4188
query66	1160	463	323	323
query67	15233	15466	15000	15000
query68	8534	909	573	573
query69	485	330	273	273
query70	1241	1203	1144	1144
query71	453	324	305	305
query72	5664	4710	4859	4710
query73	741	612	360	360
query74	8906	9029	8915	8915
query75	3905	3065	2628	2628
query76	3627	1131	726	726
query77	812	444	325	325
query78	9615	9656	8848	8848
query79	2089	792	574	574
query80	596	555	476	476
query81	474	250	223	223
query82	456	139	105	105
query83	253	244	242	242
query84	249	102	86	86
query85	796	371	329	329
query86	340	307	312	307
query87	4294	4262	4158	4158
query88	2900	2198	2179	2179
query89	389	312	287	287
query90	1924	227	215	215
query91	145	142	117	117
query92	84	74	69	69
query93	1093	982	633	633
query94	678	407	310	310
query95	401	320	355	320
query96	477	585	275	275
query97	2645	2659	2542	2542
query98	240	213	216	213
query99	1478	1374	1256	1256
Total cold run time: 272175 ms
Total hot run time: 184659 ms

@doris-robot
Copy link

doris-robot commented Aug 19, 2025

ClickBench: Total hot run time: 32.76 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 62d775b41eeee6e17c928a55ccdd533a6a7cd7a8, data reload: false

query1	0.04	0.03	0.04
query2	0.07	0.05	0.04
query3	0.24	0.07	0.08
query4	1.62	0.11	0.12
query5	0.44	0.41	0.41
query6	1.16	0.63	0.65
query7	0.03	0.02	0.02
query8	0.05	0.03	0.04
query9	0.60	0.52	0.52
query10	0.56	0.58	0.58
query11	0.16	0.12	0.11
query12	0.15	0.12	0.12
query13	0.63	0.61	0.60
query14	0.80	0.84	0.82
query15	0.88	0.88	0.87
query16	0.38	0.41	0.39
query17	1.05	1.04	1.05
query18	0.22	0.19	0.19
query19	1.93	1.83	1.92
query20	0.01	0.01	0.01
query21	15.40	0.97	0.58
query22	0.75	1.13	0.83
query23	14.85	1.38	0.62
query24	6.97	1.04	0.82
query25	0.54	0.14	0.15
query26	0.52	0.16	0.13
query27	0.06	0.06	0.05
query28	9.86	0.90	0.43
query29	12.64	3.95	3.26
query30	3.12	2.99	3.03
query31	2.82	0.58	0.39
query32	3.23	0.56	0.47
query33	3.17	3.09	3.08
query34	16.10	5.42	4.86
query35	4.95	4.87	4.93
query36	0.68	0.52	0.49
query37	0.10	0.07	0.07
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.17	0.15	0.14
query41	0.08	0.03	0.02
query42	0.03	0.03	0.02
query43	0.04	0.03	0.02
Total cold run time: 107.18 s
Total hot run time: 32.76 s

@zddr
Copy link
Contributor Author

zddr commented Aug 20, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Aug 20, 2025

TPC-H: Total hot run time: 33846 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b68e4421d9ebcc73351fdd6ccd24b2f15d2c1952, data reload: false

------ Round 1 ----------------------------------
q1	17600	5241	5057	5057
q2	1962	290	181	181
q3	10339	1298	712	712
q4	10216	1012	528	528
q5	7513	2410	2331	2331
q6	182	158	129	129
q7	890	750	618	618
q8	9306	1495	1161	1161
q9	6876	5134	5125	5125
q10	6925	2378	1978	1978
q11	477	283	264	264
q12	345	363	229	229
q13	17775	3641	3015	3015
q14	243	248	220	220
q15	540	492	476	476
q16	423	433	369	369
q17	590	851	360	360
q18	7522	7027	7063	7027
q19	1080	946	560	560
q20	351	330	218	218
q21	3711	3167	2322	2322
q22	1089	1045	966	966
Total cold run time: 105955 ms
Total hot run time: 33846 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5221	5145	5136	5136
q2	249	328	217	217
q3	2180	2651	2318	2318
q4	1378	1819	1363	1363
q5	4210	4518	4552	4518
q6	210	174	130	130
q7	2031	1988	1846	1846
q8	2688	2628	2689	2628
q9	7412	7317	7212	7212
q10	3174	3334	2979	2979
q11	565	510	503	503
q12	716	787	676	676
q13	3591	3944	3317	3317
q14	280	311	277	277
q15	543	473	483	473
q16	463	498	464	464
q17	1189	1605	1365	1365
q18	7888	7791	7507	7507
q19	847	825	866	825
q20	2044	2099	1904	1904
q21	4905	4545	4311	4311
q22	1067	1026	984	984
Total cold run time: 52851 ms
Total hot run time: 50953 ms

@doris-robot
Copy link

doris-robot commented Aug 20, 2025

TPC-DS: Total hot run time: 185140 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b68e4421d9ebcc73351fdd6ccd24b2f15d2c1952, data reload: false

query1	980	382	409	382
query2	6533	1769	1755	1755
query3	6750	221	219	219
query4	26598	23833	23127	23127
query5	4333	635	472	472
query6	321	217	203	203
query7	4624	499	280	280
query8	257	227	221	221
query9	8609	2884	2877	2877
query10	496	322	303	303
query11	15572	14969	14796	14796
query12	158	117	118	117
query13	1661	569	419	419
query14	8712	5864	5654	5654
query15	210	190	163	163
query16	7130	659	427	427
query17	951	736	603	603
query18	1989	408	324	324
query19	191	189	166	166
query20	124	126	116	116
query21	212	127	109	109
query22	4078	4278	4222	4222
query23	34519	33432	33272	33272
query24	8195	2359	2338	2338
query25	546	462	414	414
query26	1224	268	153	153
query27	2753	506	342	342
query28	4346	2265	2229	2229
query29	810	554	433	433
query30	285	229	189	189
query31	875	781	727	727
query32	88	79	74	74
query33	569	371	344	344
query34	803	853	507	507
query35	829	817	741	741
query36	966	1001	923	923
query37	123	115	88	88
query38	4013	4162	3950	3950
query39	1484	1417	1599	1417
query40	214	126	117	117
query41	59	54	51	51
query42	121	114	112	112
query43	519	494	472	472
query44	1361	852	847	847
query45	176	169	164	164
query46	860	1007	638	638
query47	1756	1834	1718	1718
query48	390	426	311	311
query49	707	487	386	386
query50	665	683	411	411
query51	4077	4129	4104	4104
query52	116	111	103	103
query53	239	259	189	189
query54	600	596	528	528
query55	91	82	87	82
query56	333	310	303	303
query57	1193	1180	1129	1129
query58	270	267	266	266
query59	2636	2743	2599	2599
query60	353	340	325	325
query61	161	125	124	124
query62	786	720	645	645
query63	227	184	187	184
query64	4365	1014	695	695
query65	4273	4160	4190	4160
query66	1152	423	342	342
query67	15628	15344	15094	15094
query68	7868	921	580	580
query69	474	404	288	288
query70	1195	1089	1141	1089
query71	461	347	307	307
query72	5718	4951	4979	4951
query73	737	680	358	358
query74	8915	8804	8956	8804
query75	3711	3054	2669	2669
query76	3672	1134	732	732
query77	798	410	331	331
query78	9564	9662	8766	8766
query79	2731	799	609	609
query80	631	534	469	469
query81	536	250	230	230
query82	456	138	108	108
query83	284	252	237	237
query84	287	102	83	83
query85	798	371	337	337
query86	388	303	302	302
query87	4343	4230	4191	4191
query88	3488	2185	2241	2185
query89	389	317	282	282
query90	1845	224	219	219
query91	137	145	113	113
query92	92	73	68	68
query93	2011	969	643	643
query94	679	404	322	322
query95	394	316	325	316
query96	502	576	273	273
query97	2693	2688	2552	2552
query98	234	213	209	209
query99	1427	1390	1322	1322
Total cold run time: 273703 ms
Total hot run time: 185140 ms

@doris-robot
Copy link

doris-robot commented Aug 20, 2025

ClickBench: Total hot run time: 32.04 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b68e4421d9ebcc73351fdd6ccd24b2f15d2c1952, data reload: false

query1	0.04	0.03	0.04
query2	0.08	0.04	0.04
query3	0.24	0.08	0.08
query4	1.62	0.11	0.11
query5	0.42	0.42	0.40
query6	1.15	0.63	0.65
query7	0.03	0.02	0.02
query8	0.04	0.04	0.04
query9	0.60	0.52	0.52
query10	0.57	0.58	0.58
query11	0.16	0.11	0.11
query12	0.14	0.11	0.12
query13	0.64	0.60	0.61
query14	0.79	0.82	0.83
query15	0.89	0.84	0.87
query16	0.40	0.40	0.38
query17	1.04	1.06	1.02
query18	0.21	0.20	0.20
query19	1.90	1.81	1.80
query20	0.01	0.02	0.01
query21	15.40	0.94	0.58
query22	0.74	1.13	0.70
query23	14.99	1.36	0.66
query24	7.22	1.01	0.35
query25	0.54	0.24	0.06
query26	0.61	0.18	0.14
query27	0.07	0.06	0.05
query28	9.39	0.94	0.42
query29	12.67	3.85	3.24
query30	3.07	3.01	2.97
query31	2.81	0.58	0.38
query32	3.31	0.53	0.47
query33	3.11	3.10	3.16
query34	16.17	5.47	4.89
query35	4.90	4.86	4.99
query36	0.68	0.50	0.50
query37	0.10	0.07	0.07
query38	0.06	0.04	0.04
query39	0.03	0.02	0.03
query40	0.18	0.15	0.13
query41	0.07	0.03	0.03
query42	0.03	0.02	0.02
query43	0.03	0.03	0.02
Total cold run time: 107.15 s
Total hot run time: 32.04 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 20, 2025

FE UT Coverage Report

Increment line coverage 66.67% (2/3) 🎉
Increment coverage report
Complete coverage report

@zddr
Copy link
Contributor Author

zddr commented Aug 20, 2025

run p0

@zddr
Copy link
Contributor Author

zddr commented Aug 20, 2025

run cloud_p0

@zddr
Copy link
Contributor Author

zddr commented Aug 22, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 22, 2025

FE UT Coverage Report

Increment line coverage 66.67% (2/3) 🎉
Increment coverage report
Complete coverage report

@zddr
Copy link
Contributor Author

zddr commented Aug 22, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 22, 2025

FE UT Coverage Report

Increment line coverage 66.67% (2/3) 🎉
Increment coverage report
Complete coverage report

@zddr
Copy link
Contributor Author

zddr commented Aug 26, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Aug 26, 2025

TPC-H: Total hot run time: 33846 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5f68dbf29e344cfbeacd38f62a58760799f95cc6, data reload: false

------ Round 1 ----------------------------------
q1	17600	5265	5077	5077
q2	1935	284	181	181
q3	10315	1284	696	696
q4	10219	1010	519	519
q5	7509	2404	2285	2285
q6	179	161	127	127
q7	915	729	599	599
q8	9299	1308	1087	1087
q9	6945	5125	5073	5073
q10	6890	2386	1955	1955
q11	466	288	284	284
q12	346	347	213	213
q13	17766	3680	3024	3024
q14	236	224	224	224
q15	542	475	477	475
q16	427	424	364	364
q17	589	867	351	351
q18	7491	7196	7213	7196
q19	1234	946	572	572
q20	348	335	215	215
q21	3740	2643	2346	2346
q22	1087	1017	983	983
Total cold run time: 106078 ms
Total hot run time: 33846 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5142	5110	5102	5102
q2	245	318	225	225
q3	2141	2657	2262	2262
q4	1360	1758	1356	1356
q5	4221	4479	4605	4479
q6	223	177	136	136
q7	2012	1985	1811	1811
q8	2669	2690	2628	2628
q9	7226	7302	7355	7302
q10	3056	3283	2900	2900
q11	559	512	509	509
q12	716	805	652	652
q13	3549	3998	3317	3317
q14	319	312	302	302
q15	544	494	515	494
q16	493	502	462	462
q17	1218	1604	1421	1421
q18	7904	7707	7564	7564
q19	810	828	966	828
q20	1994	2059	1922	1922
q21	4898	4380	4230	4230
q22	1084	1053	998	998
Total cold run time: 52383 ms
Total hot run time: 50900 ms

@doris-robot
Copy link

doris-robot commented Aug 26, 2025

TPC-DS: Total hot run time: 184776 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5f68dbf29e344cfbeacd38f62a58760799f95cc6, data reload: false

query1	1006	412	418	412
query2	6534	1755	1746	1746
query3	6752	232	215	215
query4	26135	23241	23030	23030
query5	4289	617	486	486
query6	313	227	204	204
query7	4630	505	290	290
query8	275	242	226	226
query9	8632	2907	2882	2882
query10	460	342	280	280
query11	16023	15032	14837	14837
query12	166	113	110	110
query13	1666	559	447	447
query14	9337	5665	5741	5665
query15	207	182	171	171
query16	7673	669	467	467
query17	1243	735	616	616
query18	2027	413	320	320
query19	211	191	166	166
query20	127	123	120	120
query21	216	132	116	116
query22	4147	4230	4022	4022
query23	34216	32964	33027	32964
query24	8226	2360	2332	2332
query25	537	491	404	404
query26	1237	271	161	161
query27	2743	500	353	353
query28	4345	2275	2252	2252
query29	766	563	456	456
query30	284	224	196	196
query31	890	781	726	726
query32	88	73	77	73
query33	561	376	336	336
query34	803	852	509	509
query35	803	817	758	758
query36	959	1003	905	905
query37	120	104	86	86
query38	4044	4048	4007	4007
query39	1507	1441	1399	1399
query40	223	125	115	115
query41	61	56	60	56
query42	121	112	110	110
query43	517	514	479	479
query44	1335	872	855	855
query45	176	168	166	166
query46	862	996	642	642
query47	1801	1832	1697	1697
query48	375	409	308	308
query49	729	480	389	389
query50	657	668	399	399
query51	4066	4152	4044	4044
query52	116	110	108	108
query53	232	261	195	195
query54	600	582	519	519
query55	90	85	104	85
query56	321	315	293	293
query57	1194	1217	1112	1112
query58	276	267	285	267
query59	2788	2808	2649	2649
query60	350	331	323	323
query61	128	121	124	121
query62	820	725	665	665
query63	231	185	199	185
query64	4347	1036	698	698
query65	4320	4193	4208	4193
query66	1107	464	328	328
query67	15603	15427	15210	15210
query68	8648	919	582	582
query69	466	330	289	289
query70	1260	1146	1100	1100
query71	470	339	326	326
query72	5718	4780	4852	4780
query73	758	630	351	351
query74	9211	9261	8777	8777
query75	4024	3069	2645	2645
query76	3720	1136	728	728
query77	854	398	309	309
query78	9495	9668	8867	8867
query79	2513	836	606	606
query80	663	554	468	468
query81	469	254	226	226
query82	454	134	111	111
query83	285	246	227	227
query84	297	105	88	88
query85	797	385	336	336
query86	342	312	293	293
query87	4428	4301	4140	4140
query88	2853	2223	2226	2223
query89	422	322	279	279
query90	1944	220	221	220
query91	145	146	113	113
query92	89	70	67	67
query93	1388	1010	641	641
query94	688	415	309	309
query95	401	320	326	320
query96	488	604	281	281
query97	2624	2710	2583	2583
query98	230	218	217	217
query99	1469	1423	1318	1318
Total cold run time: 275257 ms
Total hot run time: 184776 ms

@zddr
Copy link
Contributor Author

zddr commented Aug 26, 2025

run feut

@doris-robot
Copy link

doris-robot commented Aug 26, 2025

ClickBench: Total hot run time: 32.29 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5f68dbf29e344cfbeacd38f62a58760799f95cc6, data reload: false

query1	0.05	0.04	0.04
query2	0.09	0.04	0.05
query3	0.24	0.08	0.07
query4	1.62	0.11	0.11
query5	0.44	0.39	0.42
query6	1.19	0.63	0.66
query7	0.02	0.02	0.02
query8	0.05	0.03	0.04
query9	0.59	0.52	0.52
query10	0.57	0.58	0.57
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.63	0.60	0.60
query14	0.80	0.83	0.83
query15	0.88	0.87	0.86
query16	0.39	0.40	0.39
query17	1.02	1.04	1.05
query18	0.20	0.20	0.20
query19	1.93	1.78	1.82
query20	0.02	0.01	0.01
query21	15.39	0.94	0.60
query22	0.78	1.12	0.74
query23	14.91	1.41	0.62
query24	7.25	0.97	0.46
query25	0.47	0.12	0.22
query26	0.65	0.15	0.13
query27	0.07	0.06	0.06
query28	9.09	0.94	0.43
query29	12.68	3.93	3.27
query30	3.03	3.03	3.00
query31	2.82	0.58	0.38
query32	3.25	0.55	0.47
query33	3.10	3.04	3.14
query34	16.19	5.51	4.86
query35	4.90	4.91	4.94
query36	0.69	0.50	0.51
query37	0.09	0.08	0.07
query38	0.06	0.05	0.03
query39	0.03	0.02	0.03
query40	0.18	0.14	0.15
query41	0.08	0.03	0.03
query42	0.04	0.03	0.02
query43	0.04	0.04	0.03
Total cold run time: 106.83 s
Total hot run time: 32.29 s

@zddr
Copy link
Contributor Author

zddr commented Aug 26, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 26, 2025

FE UT Coverage Report

Increment line coverage 50.00% (3/6) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

doris-robot commented Aug 26, 2025

TPC-H: Total hot run time: 33870 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e2eb735c5080e7989c50b7c415f3ce7999ed0940, data reload: false

------ Round 1 ----------------------------------
q1	17611	5335	5061	5061
q2	1920	282	183	183
q3	10325	1273	706	706
q4	10224	1027	511	511
q5	7473	2427	2352	2352
q6	171	164	137	137
q7	909	745	601	601
q8	9299	1364	1115	1115
q9	6980	5067	5232	5067
q10	6869	2397	1982	1982
q11	495	283	263	263
q12	340	356	213	213
q13	17766	3629	3012	3012
q14	234	233	217	217
q15	550	480	484	480
q16	436	441	367	367
q17	608	855	363	363
q18	7403	7112	7193	7112
q19	1093	944	567	567
q20	339	335	225	225
q21	4090	3209	2358	2358
q22	1064	1027	978	978
Total cold run time: 106199 ms
Total hot run time: 33870 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5204	5069	5127	5069
q2	244	325	231	231
q3	2182	2685	2384	2384
q4	1348	1804	1407	1407
q5	4225	4542	4588	4542
q6	224	169	130	130
q7	2048	1938	1814	1814
q8	2650	2745	2609	2609
q9	7389	7367	7308	7308
q10	3127	3234	2870	2870
q11	672	576	504	504
q12	690	786	593	593
q13	3441	3939	3298	3298
q14	318	338	291	291
q15	532	502	491	491
q16	444	522	460	460
q17	1248	1472	1458	1458
q18	7979	7920	7412	7412
q19	821	835	885	835
q20	2043	2055	1976	1976
q21	5173	4419	4411	4411
q22	1081	1045	1003	1003
Total cold run time: 53083 ms
Total hot run time: 51096 ms

@doris-robot
Copy link

doris-robot commented Aug 26, 2025

TPC-DS: Total hot run time: 184476 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e2eb735c5080e7989c50b7c415f3ce7999ed0940, data reload: false

query1	992	424	445	424
query2	6514	1767	1743	1743
query3	6744	221	215	215
query4	26718	23248	23098	23098
query5	4340	604	531	531
query6	313	231	205	205
query7	4634	495	295	295
query8	270	230	223	223
query9	8618	2881	2892	2881
query10	457	328	288	288
query11	15798	14918	14776	14776
query12	163	115	116	115
query13	1660	558	427	427
query14	9495	5777	5759	5759
query15	210	181	177	177
query16	7661	656	476	476
query17	1205	723	606	606
query18	2026	423	326	326
query19	210	199	163	163
query20	128	121	112	112
query21	216	131	110	110
query22	4143	4127	4029	4029
query23	34042	32750	32602	32602
query24	8116	2359	2334	2334
query25	538	467	415	415
query26	1227	269	162	162
query27	2716	517	355	355
query28	4341	2273	2257	2257
query29	753	568	450	450
query30	285	224	191	191
query31	899	792	712	712
query32	88	75	74	74
query33	546	374	331	331
query34	821	836	513	513
query35	780	802	733	733
query36	983	1000	948	948
query37	120	106	91	91
query38	4000	4021	4053	4021
query39	1498	1415	1407	1407
query40	222	126	113	113
query41	58	58	52	52
query42	121	111	109	109
query43	549	535	502	502
query44	1357	867	854	854
query45	176	177	168	168
query46	853	997	632	632
query47	1731	1819	1699	1699
query48	382	415	323	323
query49	719	490	384	384
query50	665	671	392	392
query51	4132	4249	4124	4124
query52	114	115	107	107
query53	245	276	193	193
query54	596	610	540	540
query55	91	84	85	84
query56	328	303	292	292
query57	1190	1191	1136	1136
query58	283	275	262	262
query59	2642	2816	2623	2623
query60	342	338	323	323
query61	128	151	126	126
query62	831	736	690	690
query63	224	189	188	188
query64	4246	1007	681	681
query65	4267	4200	4192	4192
query66	1075	415	387	387
query67	15776	15182	15111	15111
query68	8229	911	584	584
query69	480	328	297	297
query70	1225	1099	1089	1089
query71	498	334	322	322
query72	5749	4625	4633	4625
query73	687	553	356	356
query74	8846	9017	8690	8690
query75	3862	3044	2628	2628
query76	3703	1141	742	742
query77	831	400	317	317
query78	9523	9532	8810	8810
query79	2538	833	599	599
query80	634	532	468	468
query81	473	252	219	219
query82	429	140	109	109
query83	279	260	242	242
query84	296	99	86	86
query85	790	363	415	363
query86	335	331	292	292
query87	4261	4239	4189	4189
query88	3310	2243	2215	2215
query89	389	310	284	284
query90	1954	225	216	216
query91	137	138	116	116
query92	85	72	69	69
query93	1770	962	645	645
query94	691	387	311	311
query95	399	327	312	312
query96	492	633	279	279
query97	2674	2670	2615	2615
query98	261	233	231	231
query99	1448	1409	1294	1294
Total cold run time: 274889 ms
Total hot run time: 184476 ms

@doris-robot
Copy link

doris-robot commented Aug 26, 2025

ClickBench: Total hot run time: 32.51 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e2eb735c5080e7989c50b7c415f3ce7999ed0940, data reload: false

query1	0.05	0.04	0.04
query2	0.07	0.04	0.05
query3	0.24	0.08	0.07
query4	1.61	0.11	0.12
query5	0.41	0.41	0.40
query6	1.17	0.63	0.63
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.61	0.52	0.51
query10	0.56	0.56	0.56
query11	0.16	0.11	0.11
query12	0.15	0.11	0.11
query13	0.63	0.62	0.61
query14	0.80	0.83	0.84
query15	0.86	0.87	0.87
query16	0.39	0.42	0.38
query17	1.05	1.05	1.05
query18	0.22	0.20	0.20
query19	1.95	1.83	1.84
query20	0.02	0.01	0.01
query21	15.46	0.99	0.57
query22	0.75	1.20	0.77
query23	14.86	1.39	0.63
query24	6.30	1.29	0.68
query25	0.50	0.15	0.09
query26	0.54	0.16	0.13
query27	0.06	0.05	0.04
query28	10.22	0.98	0.43
query29	12.60	3.91	3.24
query30	3.07	3.06	2.99
query31	2.83	0.59	0.38
query32	3.25	0.55	0.47
query33	3.04	3.10	3.10
query34	16.29	5.45	4.85
query35	4.93	4.89	4.93
query36	0.70	0.50	0.50
query37	0.10	0.06	0.07
query38	0.04	0.04	0.05
query39	0.03	0.03	0.02
query40	0.17	0.14	0.14
query41	0.08	0.02	0.03
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.92 s
Total hot run time: 32.51 s

@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2025

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit dbeed05 into apache:master Aug 27, 2025
27 of 28 checks passed
@morrySnow morrySnow changed the title [fix](connection)Fixes session-related data is not cleared when the connection is disconnected due to timeout. [fix](connection)Fixes session-related data is not cleared when the connection is disconnected due to timeout. Aug 27, 2025
zddr added a commit to zddr/incubator-doris that referenced this pull request Aug 28, 2025
@zddr
[fix](connection)Fixes session-related data is not cleared when the c…
6892682 
…onnection is disconnected due to timeout. (apache#55008)

### What problem does this PR solve?

bug:
1. create temporary table c(id int) properties("replication_num" = "1");
2. set wait_timeout=5;
3. When `show data`, can always see the temporary table

Additionally, in this scenario, the aliveSessionSet also cannot be
properly cleared.

fix:

When the connection is lost, don't just call closeChannel—call cleanup
instead.
# Conflicts:
#	fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java
@zddr zddr mentioned this pull request Aug 28, 2025
Merged
@zddr zddr mentioned this pull request Sep 9, 2025
Merged
16 tasks
924060929 pushed a commit that referenced this pull request Sep 10, 2025
@zddr
[fix](connection)Fix kill connection will make current connection kil…
829a814 
…led (#55809)

kill connection should not call `threadLocalInfo.remove();`,it will make
current thread `getConnection` is null

The current historical legacy issue: after killing the connection, it is
not possible to execute threadLocalInfo. remove() on the corresponding
thread; Resulting in more memory usage

Related PR: #55008
morrySnow pushed a commit that referenced this pull request Sep 11, 2025
@zddr
branch-3.1: [fix](connection)Fixes session-related data is not cleare…
5a8ce14 
…d when the connection is disconnected due to timeout. #55008 #55809 (#55396)

pick #55008 #55809
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Closed
yiguolei pushed a commit to yiguolei/incubator-doris that referenced this pull request Dec 19, 2025
@zddr
[fix](connection)Fix kill connection will make current connection kil…
f2a8fc2 
…led (apache#55809)

kill connection should not call `threadLocalInfo.remove();`,it will make
current thread `getConnection` is null

The current historical legacy issue: after killing the connection, it is
not possible to execute threadLocalInfo. remove() on the corresponding
thread; Resulting in more memory usage

Related PR: apache#55008
# Conflicts:
#	fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java
#	fe/fe-core/src/main/java/org/apache/doris/service/arrowflight/sessions/FlightSqlConnectContext.java
yiguolei pushed a commit to yiguolei/incubator-doris that referenced this pull request Dec 19, 2025
@zddr
[fix](connection)Fix kill connection will make current connection kil…
74aa052 
…led (apache#55809)

kill connection should not call `threadLocalInfo.remove();`,it will make
current thread `getConnection` is null

The current historical legacy issue: after killing the connection, it is
not possible to execute threadLocalInfo. remove() on the corresponding
thread; Resulting in more memory usage

Related PR: apache#55008
# Conflicts:
#	fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java
#	fe/fe-core/src/main/java/org/apache/doris/service/arrowflight/sessions/FlightSqlConnectContext.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hello-stephen hello-stephen hello-stephen approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.1-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zddr @Thearas @doris-robot @hello-stephen @morrySnow

Comments