[fix](nereids) stop merge project when generating huge expression#55293
Merged
924060929 merged 4 commits intoapache:masterfrom Sep 1, 2025
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
ae3c17f to
331b2f5
Compare
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34197 ms |
924060929
previously approved these changes
Aug 27, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-DS: Total hot run time: 186206 ms |
ClickBench: Total hot run time: 32.4 s |
774ecbd to
4de2527
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34087 ms |
TPC-DS: Total hot run time: 188286 ms |
ClickBench: Total hot run time: 32.8 s |
924060929
approved these changes
Aug 29, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
morrySnow
approved these changes
Sep 1, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
when merge projects, it will replace the parent project's slot reference with the child project's origin expression.
for example:
after replace
kwitha + b, we will got the merged project:suppose the origin parent project contains n
k, then the merged project will contains 3n (a + bcontains 3 expression) related expressions.then if there are a continous project chain, after merge these projects, the final merge expression's size may grow exponentially, finally may exceed expression size limit, then throw exception
Exceeded the maximum children of an expression tree.so when merging projects, if generate a big expression which its size exceeds the limit, need to stop merging projects.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)