Skip to content

[fix](nereids)use bigint instead of int literal to compare with count() agg function#55545

Merged
morrySnow merged 1 commit intoapache:masterfrom
starocean999:nereids_0901
Sep 2, 2025
Merged

[fix](nereids)use bigint instead of int literal to compare with count() agg function#55545
morrySnow merged 1 commit intoapache:masterfrom
starocean999:nereids_0901

Conversation

@starocean999
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@starocean999
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34148 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 43c8a23e392aff6e6b7969b07c09464cbeab8eb0, data reload: false

------ Round 1 ----------------------------------
q1	17596	5236	5072	5072
q2	1998	327	207	207
q3	10229	1307	708	708
q4	10237	1020	521	521
q5	7524	2467	2314	2314
q6	188	173	140	140
q7	922	774	644	644
q8	9360	1386	1149	1149
q9	6952	5101	5126	5101
q10	6953	2393	2008	2008
q11	493	304	286	286
q12	352	377	233	233
q13	17794	3647	3027	3027
q14	226	239	223	223
q15	571	500	492	492
q16	432	428	392	392
q17	598	861	374	374
q18	7423	7079	7124	7079
q19	1405	962	588	588
q20	350	338	263	263
q21	3897	2526	2339	2339
q22	1089	1032	988	988
Total cold run time: 106589 ms
Total hot run time: 34148 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5274	5168	5147	5147
q2	248	323	228	228
q3	2162	2684	2337	2337
q4	1366	1780	1344	1344
q5	4191	4395	4580	4395
q6	232	176	138	138
q7	2104	1935	1878	1878
q8	2682	2623	2532	2532
q9	7405	7456	7404	7404
q10	3186	3236	2928	2928
q11	588	539	526	526
q12	705	791	692	692
q13	3390	3935	3329	3329
q14	307	344	284	284
q15	519	504	480	480
q16	474	487	465	465
q17	1171	1618	1368	1368
q18	7797	7658	7637	7637
q19	822	823	903	823
q20	2025	2060	1922	1922
q21	4809	4362	4282	4282
q22	1088	1051	1014	1014
Total cold run time: 52545 ms
Total hot run time: 51153 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186888 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 43c8a23e392aff6e6b7969b07c09464cbeab8eb0, data reload: false

query1	1055	480	403	403
query2	6586	1771	1825	1771
query3	6745	232	228	228
query4	26366	23231	23021	23021
query5	4486	665	572	572
query6	340	246	240	240
query7	4668	535	303	303
query8	306	262	244	244
query9	8684	2889	2909	2889
query10	513	348	301	301
query11	15513	15140	14827	14827
query12	180	121	120	120
query13	1663	582	430	430
query14	9438	5795	5740	5740
query15	245	203	171	171
query16	7562	665	487	487
query17	1245	736	628	628
query18	2036	428	345	345
query19	198	197	171	171
query20	134	129	122	122
query21	222	129	119	119
query22	4070	4130	4200	4130
query23	33848	33034	33103	33034
query24	8212	2411	2399	2399
query25	599	525	445	445
query26	1254	289	169	169
query27	2719	513	372	372
query28	4367	2295	2259	2259
query29	821	629	521	521
query30	294	231	199	199
query31	908	813	723	723
query32	93	87	83	83
query33	582	415	371	371
query34	802	859	540	540
query35	862	823	743	743
query36	958	1026	898	898
query37	126	108	89	89
query38	4067	4042	3980	3980
query39	1496	1453	1415	1415
query40	233	141	129	129
query41	64	61	62	61
query42	135	124	124	124
query43	538	500	484	484
query44	1361	861	859	859
query45	191	176	224	176
query46	867	1024	661	661
query47	1763	1826	1715	1715
query48	403	439	325	325
query49	745	500	415	415
query50	657	681	397	397
query51	4081	4162	4133	4133
query52	119	112	105	105
query53	259	268	208	208
query54	617	599	536	536
query55	98	89	91	89
query56	347	323	324	323
query57	1191	1199	1131	1131
query58	296	276	293	276
query59	2594	2671	2664	2664
query60	355	351	349	349
query61	166	165	188	165
query62	808	712	674	674
query63	233	198	198	198
query64	4461	1180	843	843
query65	4344	4227	4211	4211
query66	1113	441	355	355
query67	15571	15695	15175	15175
query68	7977	946	583	583
query69	486	326	295	295
query70	1251	1126	1123	1123
query71	486	341	317	317
query72	5772	4946	4903	4903
query73	691	598	361	361
query74	9170	8958	9026	8958
query75	3855	3097	2644	2644
query76	3713	1158	736	736
query77	822	430	342	342
query78	9551	9726	8933	8933
query79	2423	857	592	592
query80	627	565	549	549
query81	509	261	226	226
query82	459	146	114	114
query83	271	270	352	270
query84	261	111	93	93
query85	902	475	437	437
query86	402	338	305	305
query87	4300	4197	4159	4159
query88	3652	2224	2208	2208
query89	421	354	308	308
query90	1871	227	233	227
query91	161	165	141	141
query92	88	76	73	73
query93	1886	980	653	653
query94	706	427	326	326
query95	504	330	320	320
query96	491	589	282	282
query97	2606	2633	2612	2612
query98	243	224	215	215
query99	1411	1437	1300	1300
Total cold run time: 275841 ms
Total hot run time: 186888 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.57 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 43c8a23e392aff6e6b7969b07c09464cbeab8eb0, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.05	0.05
query3	0.26	0.08	0.08
query4	1.60	0.12	0.12
query5	0.46	0.43	0.43
query6	1.17	0.65	0.67
query7	0.03	0.03	0.03
query8	0.06	0.05	0.05
query9	0.61	0.53	0.53
query10	0.59	0.58	0.59
query11	0.17	0.12	0.11
query12	0.16	0.12	0.12
query13	0.64	0.64	0.62
query14	0.79	0.85	0.84
query15	0.87	0.86	0.88
query16	0.39	0.40	0.41
query17	1.05	1.06	1.06
query18	0.22	0.20	0.20
query19	1.96	1.88	1.84
query20	0.01	0.02	0.01
query21	15.40	0.96	0.60
query22	0.78	1.19	0.68
query23	14.94	1.41	0.62
query24	6.92	1.16	0.45
query25	0.47	0.14	0.09
query26	0.53	0.17	0.13
query27	0.06	0.06	0.05
query28	10.04	0.94	0.42
query29	12.55	3.89	3.25
query30	3.08	3.04	3.01
query31	2.82	0.58	0.39
query32	3.26	0.56	0.48
query33	3.10	3.10	3.08
query34	15.99	5.44	4.91
query35	4.89	4.92	4.88
query36	0.71	0.52	0.51
query37	0.11	0.07	0.08
query38	0.06	0.05	0.05
query39	0.04	0.03	0.04
query40	0.19	0.15	0.14
query41	0.08	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 107.29 s
Total hot run time: 32.57 s

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 100% (0/0) 🎉
Increment coverage report
Complete coverage report

@starocean999 starocean999 marked this pull request as ready for review September 2, 2025 01:42
@starocean999 starocean999 changed the title [fix](nereids)use bigint instead of int literal to compare with count() aggfunction [fix](nereids)use bigint instead of int literal to compare with count() agg function Sep 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

PR approved by at least one committer and no changes requested.

@morrySnow morrySnow merged commit c40c881 into apache:master Sep 2, 2025
29 of 31 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 2, 2025
morrySnow pushed a commit that referenced this pull request Sep 4, 2025
…e with count() agg function #55545 (#55590)

Cherry-picked from #55545

Co-authored-by: starocean999 <lichi@selectdb.com>
uchenily pushed a commit to uchenily/doris that referenced this pull request Sep 5, 2025
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.1-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments