[External](parquet) pass non predicates column's offset index to RowGroupReader#55795
Merged
morningman merged 1 commit intoapache:masterfrom Oct 23, 2025
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34644 ms |
TPC-DS: Total hot run time: 189549 ms |
ClickBench: Total hot run time: 29.71 s |
f9b4486 to
960e2ca
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34512 ms |
TPC-DS: Total hot run time: 188475 ms |
960e2ca to
2d47b96
Compare
Contributor
Author
|
run buildall |
ClickBench: Total hot run time: 30.54 s |
TPC-H: Total hot run time: 34669 ms |
TPC-DS: Total hot run time: 188775 ms |
ClickBench: Total hot run time: 30.38 s |
2d47b96 to
2e39ffd
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34756 ms |
TPC-DS: Total hot run time: 189533 ms |
ClickBench: Total hot run time: 30.5 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
morningman
approved these changes
Sep 11, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
2e39ffd to
c5f6b09
Compare
Contributor
|
run buildall |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
github-actions bot
pushed a commit
that referenced
this pull request
Oct 23, 2025
…roupReader (#55795) ### What problem does this PR solve? Now, Parquet reader don't pass non predicate coloumn's offset index to `RowGroupReader`. `create_page_reader` will create `PageReader` rather than `PageReaderWithOffsetIndex`. The `PageReader` will parse each page header when `skip_page` and `next_page_header`. In the case of merging io, read and enlarge severely. So, in this PR, we pass the offset index to `RowGroupReader`. Co-authored-by: liutang123 <liulijia@gmail.com>
dwdwqfwe
pushed a commit
to dwdwqfwe/doris
that referenced
this pull request
Oct 24, 2025
…roupReader (apache#55795) ### What problem does this PR solve? Now, Parquet reader don't pass non predicate coloumn's offset index to `RowGroupReader`. `create_page_reader` will create `PageReader` rather than `PageReaderWithOffsetIndex`. The `PageReader` will parse each page header when `skip_page` and `next_page_header`. In the case of merging io, read and enlarge severely. So, in this PR, we pass the offset index to `RowGroupReader`. Co-authored-by: liutang123 <liulijia@gmail.com>
hubgeter
added a commit
to hubgeter/doris
that referenced
this pull request
Oct 28, 2025
…dex to RowGroupReader (apache#55795)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Now, Parquet reader don't pass non predicate coloumn's offset index to
RowGroupReader.create_page_readerwill createPageReaderrather thanPageReaderWithOffsetIndex.The
PageReaderwill parse each page header whenskip_pageandnext_page_header. In the case of merging io, read and enlarge severely.So, in this PR, we pass the offset index to
RowGroupReader.Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)