[chore](refactor-params)remove old properties#56163
[chore](refactor-params)remove old properties#56163CalvinKirs merged 3 commits intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 34967 ms |
TPC-DS: Total hot run time: 185907 ms |
ClickBench: Total hot run time: 29.93 s |
|
run buildall |
TPC-H: Total hot run time: 34517 ms |
TPC-DS: Total hot run time: 186958 ms |
ClickBench: Total hot run time: 30.41 s |
FE UT Coverage ReportIncrement line coverage |
|
run compile |
There was a problem hiding this comment.
duplicate in S3StorageVault.java.
I think we can move it to S3Properties?
There was a problem hiding this comment.
I think this method should be moved to S3Properties?
- properties -> S3StorageProperties
- S3StorageProperties -> ObjectStoreInfoPB
There was a problem hiding this comment.
Use method like SENSITIVE_KEY.addAll(ConnectorPropertiesUtils.getSensitiveKeys(OBSProperties.class));
There was a problem hiding this comment.
These 4 strings are not used, can be removed
There was a problem hiding this comment.
Need to refactor this later.
FE Regression Coverage ReportIncrement line coverage |
|
run buildall |
TPC-H: Total hot run time: 34872 ms |
TPC-DS: Total hot run time: 188862 ms |
ClickBench: Total hot run time: 29.15 s |
FE Regression Coverage ReportIncrement line coverage |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
remove oldcode (cherry picked from commit 87f8248)
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)