Skip to content

Comments

[fix](filecache) fix filecache microbench bvar#56360

Merged
dataroaring merged 5 commits intoapache:masterfrom
freemandealer:fix-microbench-bvar
Sep 28, 2025
Merged

[fix](filecache) fix filecache microbench bvar#56360
dataroaring merged 5 commits intoapache:masterfrom
freemandealer:fix-microbench-bvar

Conversation

@freemandealer
Copy link
Contributor

@freemandealer freemandealer commented Sep 23, 2025

read_at should update read latency bvar instead of write latency bvar

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@freemandealer
[fix](filecache) fix filecache microbench bvar
a22626e 
read_at should update read latency bvar instead of write latency bvar

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@freemandealer
Copy link
Contributor Author

freemandealer commented Sep 23, 2025

run buildall

@Thearas
Copy link
Contributor

Thearas commented Sep 23, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@freemandealer
Copy link
Contributor Author

freemandealer commented Sep 23, 2025

run buildall

@freemandealer
Copy link
Contributor Author

freemandealer commented Sep 23, 2025

run buildall

@freemandealer
Copy link
Contributor Author

freemandealer commented Sep 23, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 23, 2025

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.41% (17643/33661)
Line Coverage 37.64% (160166/425563)
Region Coverage 32.10% (121922/379869)
Branch Coverage 33.50% (53479/159646)

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 23, 2025

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.19% (23407/32879)
Line Coverage 57.60% (244501/424465)
Region Coverage 52.87% (203167/384307)
Branch Coverage 54.56% (87422/160243)

@freemandealer
Copy link
Contributor Author

freemandealer commented Sep 24, 2025

run nonConcurrent

@freemandealer
Copy link
Contributor Author

freemandealer commented Sep 24, 2025

run p0

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 24, 2025

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.22% (23415/32879)
Line Coverage 57.63% (244616/424465)
Region Coverage 52.94% (203436/384307)
Branch Coverage 54.59% (87470/160243)

1 similar comment
@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 24, 2025

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.22% (23415/32879)
Line Coverage 57.63% (244616/424465)
Region Coverage 52.94% (203436/384307)
Branch Coverage 54.59% (87470/160243)

@freemandealer
Copy link
Contributor Author

freemandealer commented Sep 24, 2025

run p0

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 24, 2025

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.22% (23417/32879)
Line Coverage 57.64% (244671/424465)
Region Coverage 52.97% (203579/384307)
Branch Coverage 54.60% (87495/160243)

@freemandealer
Copy link
Contributor Author

freemandealer commented Sep 26, 2025

run p0

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 26, 2025

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.21% (23414/32879)
Line Coverage 57.63% (244636/424465)
Region Coverage 52.95% (203484/384307)
Branch Coverage 54.59% (87483/160243)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2025

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Sep 28, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xy720
xy720 approved these changes Sep 28, 2025
View reviewed changes
Copy link
Member

@xy720 xy720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 3b0cf8e into apache:master Sep 28, 2025
31 of 33 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 28, 2025
@freemandealer
[fix](filecache) fix filecache microbench bvar (#56360)
605ea8b 
read_at should update read latency bvar instead of write latency bvar

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@github-actions github-actions bot mentioned this pull request Sep 28, 2025
Merged
yiguolei pushed a commit that referenced this pull request Sep 29, 2025
@github-actions @freemandealer
branch-4.0: [fix](filecache) fix filecache microbench bvar #56360 (#5…
bf5bcc1 
…6586)

Cherry-picked from #56360

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
Co-authored-by: zhengyu <zhangzhengyu@selectdb.com>
freemandealer added a commit to freemandealer/doris that referenced this pull request Oct 30, 2025
@freemandealer
[branch-3.1][fix](filecache) fix filecache microbench bvar (apache#56360
1762e8e 
)

read_at should update read latency bvar instead of write latency bvar

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
freemandealer added a commit to freemandealer/doris that referenced this pull request Oct 30, 2025
@freemandealer
[fix](filecache) fix filecache microbench bvar (apache#56360)
e97c655 
read_at should update read latency bvar instead of write latency bvar

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
freemandealer added a commit to freemandealer/doris that referenced this pull request Oct 30, 2025
@freemandealer
[fix](filecache) fix filecache microbench bvar (apache#56360)
359bd5e 
read_at should update read latency bvar instead of write latency bvar

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@morrySnow morrySnow mentioned this pull request Nov 4, 2025
Merged
morrySnow pushed a commit that referenced this pull request Nov 4, 2025
@freemandealer
branch-3.1: [fix](filecache) fix filecache microbench bvar #56360 (#5…
eb2b07d 
…7535)

picked from #56360

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@xy720 xy720 xy720 approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.3-merged dev/4.0.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@freemandealer @Thearas @hello-stephen @gavinchou @xy720 @dataroaring @yiguolei @morrySnow