branch-4.0: [Improve](segment) Put Segment footer into index page cache #56382#56460
Merged
yiguolei merged 1 commit intobranch-4.0from Sep 27, 2025
Merged
branch-4.0: [Improve](segment) Put Segment footer into index page cache #56382#56460yiguolei merged 1 commit intobranch-4.0from
yiguolei merged 1 commit intobranch-4.0from
Conversation
This commit modified the caching logic for the Segment footer. Previously, the Segment footer was cached in the `DATA_PAGE` cache. This was incorrect as the footer is metadata, not data. This commit changes it to use the more appropriate `INDEX_PAGE` cache. Additionally, the calculation for `_meta_mem_usage` has been adjusted for better accuracy. The footer size is no longer included in the calculation since it's now managed by the `StoragePageCache`. The memory estimation for column readers is also updated to use `config::max_segment_partial_column_cache_size` for a more realistic value.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
ClickBench: Total hot run time: 30.56 s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #56382