[fix](function) Fix wrong calculation of timestampdiff of datetimev1#56893
Merged
morrySnow merged 1 commit intoapache:branch-3.1from Oct 15, 2025
Merged
[fix](function) Fix wrong calculation of timestampdiff of datetimev1#56893morrySnow merged 1 commit intoapache:branch-3.1from
morrySnow merged 1 commit intoapache:branch-3.1from
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
16 tasks
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32945 ms |
TPC-DS: Total hot run time: 192529 ms |
ClickBench: Total hot run time: 28.19 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33046 ms |
TPC-DS: Total hot run time: 193731 ms |
ClickBench: Total hot run time: 28.68 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32809 ms |
TPC-DS: Total hot run time: 191285 ms |
ClickBench: Total hot run time: 29.64 s |
morrySnow
reviewed
Oct 14, 2025
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/Now.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32566 ms |
TPC-DS: Total hot run time: 193145 ms |
ClickBench: Total hot run time: 29 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
morrySnow
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #49429
Problem Summary:
only fix in 3.1
before:
now:
and make fe fold of
now()return v2 typeRelease note
Fix wrong calculation of timestampdiff of datetimev1
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)