[Enhancement] support simple sql function for factorial(from Hive)#57144
Merged
zclllyybb merged 3 commits intoapache:masterfrom Nov 10, 2025
Merged
[Enhancement] support simple sql function for factorial(from Hive)#57144zclllyybb merged 3 commits intoapache:masterfrom
zclllyybb merged 3 commits intoapache:masterfrom
Conversation
- BE: Custom IFunction in math.cpp, UT in function_math_test.cpp. - FE: Update BuiltinScalarFunctions, signature in Factorial.java, constant folding in NumericArithmetic.java, visitor in ScalarFunctionVisitor.java. - Tests: Regression in test_math_unary_always_nullable.groovy & fold_constant_numeric_arithmatic.groovy, updated .out; additional updates for math.cpp, NumericArithmetic.java, test_math_unary_always_nullable.groovy. Closes apache#48203
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
zclllyybb
reviewed
Oct 20, 2025
be/src/vec/functions/math.cpp
Outdated
|
|
||
| Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments, | ||
| uint32_t result, size_t input_rows_count) const override { | ||
| ColumnPtr int_col = block.get_by_position(arguments[0]).column->convert_to_full_column_if_const(); |
Contributor
There was a problem hiding this comment.
no need to do this, we have framework to do for const
be/src/vec/functions/math.cpp
Outdated
| ColumnPtr int_col = block.get_by_position(arguments[0]).column->convert_to_full_column_if_const(); | ||
|
|
||
| const ColumnUInt8* input_null_map = nullptr; | ||
| if (int_col->is_nullable()) { |
Contributor
There was a problem hiding this comment.
ditto. we have framework for nullable input
be/src/vec/functions/math.cpp
Outdated
| const auto* data_col = check_and_get_column<ColumnInt64>(int_col.get()); | ||
|
|
||
| if (!data_col) { | ||
| return Status::InvalidArgument("Illegal column {} of argument of function {}", |
Contributor
There was a problem hiding this comment.
should be InternalError for wrong type.
zclllyybb
reviewed
Nov 6, 2025
Contributor
zclllyybb
left a comment
zclllyybb
left a comment
There was a problem hiding this comment.
basically good! please also add some case:
- factorial(column) which column is nullable and non-nullable
- factorial(nullable(literal))
Contributor
Author
done. not sure if its ok. looking forward to ur review |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Mryange
approved these changes
Nov 10, 2025
Contributor
|
run buildall |
TPC-H: Total hot run time: 34195 ms |
TPC-DS: Total hot run time: 188233 ms |
ClickBench: Total hot run time: 27.51 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE Regression Coverage ReportIncrement line coverage |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 10, 2025
…57144) Problem Summary: support simple sql function for factorial(from Hive)
wyxxxcat
pushed a commit
to wyxxxcat/doris
that referenced
this pull request
Nov 13, 2025
…pache#57144) Problem Summary: support simple sql function for factorial(from Hive)
wyxxxcat
pushed a commit
to wyxxxcat/doris
that referenced
this pull request
Nov 18, 2025
…pache#57144) Problem Summary: support simple sql function for factorial(from Hive)
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related PR: #48203
Problem Summary: support simple sql function for factorial(from Hive)
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)