Skip to content

[fix](segcompaction) Fix segcompaction coredump when adding key column#57162

Merged
dataroaring merged 1 commit intoapache:masterfrom
Hastyshell:fix-seg-compaction-during-sc
Oct 22, 2025
Merged

[fix](segcompaction) Fix segcompaction coredump when adding key column#57162
dataroaring merged 1 commit intoapache:masterfrom
Hastyshell:fix-seg-compaction-during-sc

Conversation

@Hastyshell
Copy link
Collaborator

@Hastyshell Hastyshell commented Oct 20, 2025

What problem does this PR solve?

Issue Number: close #56431

Problem Summary:

Only enable segment compaction when importing data.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Oct 20, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Hastyshell
Copy link
Collaborator Author

run buildall

dataroaring
dataroaring previously approved these changes Oct 20, 2025
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 20, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@freemandealer freemandealer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hastyshell
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

ClickBench: Total hot run time: 30.81 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 976e8c6ee8dd2fdbe6d557b5008690ddb0dfa120, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.05	0.06
query3	0.26	0.08	0.08
query4	1.61	0.11	0.12
query5	0.28	0.26	0.26
query6	1.20	0.66	0.64
query7	0.03	0.02	0.02
query8	0.06	0.05	0.05
query9	0.64	0.52	0.52
query10	0.60	0.58	0.59
query11	0.17	0.11	0.12
query12	0.16	0.12	0.12
query13	0.63	0.63	0.61
query14	1.04	1.04	1.05
query15	0.89	0.86	0.85
query16	0.42	0.39	0.40
query17	1.05	1.06	1.05
query18	0.21	0.20	0.19
query19	1.95	1.85	1.90
query20	0.02	0.02	0.01
query21	15.41	0.95	0.58
query22	0.74	1.15	0.64
query23	15.04	1.41	0.66
query24	7.57	1.00	1.01
query25	0.48	0.20	0.08
query26	0.54	0.16	0.15
query27	0.07	0.06	0.06
query28	9.14	1.38	0.93
query29	12.55	3.91	3.30
query30	0.29	0.14	0.11
query31	2.83	0.62	0.39
query32	3.26	0.56	0.48
query33	3.13	3.07	3.20
query34	16.21	5.48	4.94
query35	4.98	4.94	5.01
query36	0.68	0.52	0.51
query37	0.10	0.08	0.08
query38	0.07	0.06	0.04
query39	0.04	0.02	0.03
query40	0.18	0.15	0.16
query41	0.10	0.03	0.03
query42	0.05	0.04	0.03
query43	0.04	0.04	0.04
Total cold run time: 104.88 s
Total hot run time: 30.81 s

@Hastyshell Hastyshell force-pushed the fix-seg-compaction-during-sc branch from 976e8c6 to c7c2f1a Compare October 20, 2025 12:05
@Hastyshell
Copy link
Collaborator Author

run buildall

@Hastyshell
Copy link
Collaborator Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 21, 2025
@doris-robot
Copy link

ClickBench: Total hot run time: 30.91 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8eb0a4dcbb46bfea0671cee96d4cb71bebb8bf77, data reload: false

query1	0.07	0.06	0.05
query2	0.10	0.05	0.06
query3	0.26	0.10	0.08
query4	1.61	0.13	0.12
query5	0.28	0.27	0.26
query6	1.22	0.67	0.67
query7	0.04	0.04	0.02
query8	0.06	0.06	0.05
query9	0.63	0.56	0.53
query10	0.59	0.59	0.59
query11	0.17	0.12	0.12
query12	0.16	0.13	0.13
query13	0.64	0.63	0.62
query14	1.05	1.05	1.04
query15	0.93	0.89	0.89
query16	0.42	0.42	0.44
query17	1.08	1.10	1.09
query18	0.23	0.21	0.21
query19	2.04	1.86	1.95
query20	0.02	0.02	0.02
query21	15.41	0.99	0.63
query22	0.75	1.28	0.71
query23	14.82	1.34	0.69
query24	7.32	0.77	0.56
query25	0.50	0.10	0.10
query26	0.60	0.17	0.14
query27	0.07	0.06	0.06
query28	9.61	1.47	0.95
query29	12.55	4.21	3.40
query30	0.29	0.14	0.13
query31	2.85	0.61	0.40
query32	3.25	0.59	0.50
query33	3.23	3.19	3.10
query34	16.22	5.61	4.87
query35	4.93	4.91	4.98
query36	0.71	0.54	0.55
query37	0.12	0.08	0.08
query38	0.07	0.06	0.05
query39	0.04	0.04	0.03
query40	0.18	0.15	0.16
query41	0.09	0.04	0.03
query42	0.05	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 105.3 s
Total hot run time: 30.91 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.61% (17875/33977)
Line Coverage 37.83% (162134/428596)
Region Coverage 32.23% (123584/383460)
Branch Coverage 33.65% (54177/160987)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.44% (23795/33310)
Line Coverage 57.82% (247689/428348)
Region Coverage 53.02% (205940/388418)
Branch Coverage 54.74% (88608/161882)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 21, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit 3f87ec3 into apache:master Oct 22, 2025
26 of 27 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 22, 2025
#57162)

Issue Number: close #56431 

Only check segment compaction when importing data.
github-actions bot pushed a commit that referenced this pull request Oct 22, 2025
#57162)

Issue Number: close #56431 

Only check segment compaction when importing data.
yiguolei pushed a commit that referenced this pull request Oct 23, 2025
…ng key column #57162 (#57213)

Cherry-picked from #57162

Co-authored-by: Siyang Tang <tangsiyang@selectdb.com>
dwdwqfwe pushed a commit to dwdwqfwe/doris that referenced this pull request Oct 24, 2025
apache#57162)

Issue Number: close apache#56431 

Only check segment compaction when importing data.
morrySnow pushed a commit that referenced this pull request Oct 28, 2025
…ng key column #57162 (#57212)

Cherry-picked from #57162

Co-authored-by: Siyang Tang <tangsiyang@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.3-merged dev/4.0.1-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] run add bloom filter cause BE process exist

9 participants

Comments