[Fix](cast) Fix wrong corner case of datetime conversion about timezone convert#57422

zclllyybb · 2025-10-28T09:55:38Z

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

before:

mysql> select cast('9999-12-31 23:59:59.999999 +00:00' as datetime(6));
+----------------------------------------------------------+
| cast('9999-12-31 23:59:59.999999 +00:00' as datetime(6)) |
+----------------------------------------------------------+
|                                                          |
+----------------------------------------------------------+

now:

mysql> select cast('9999-12-31 23:59:59.999999 +00:00' as datetime(6));
+----------------------------------------------------------+
| cast('9999-12-31 23:59:59.999999 +00:00' as datetime(6)) |
+----------------------------------------------------------+
| NULL                                                     |
+----------------------------------------------------------+

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2025-10-28T09:55:43Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

zclllyybb · 2025-10-28T09:55:49Z

run buildall

doris-robot · 2025-10-28T12:03:43Z

BE UT Coverage Report

Increment line coverage 100.00% (4/4) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	52.76% (18056/34224)
Line Coverage	37.99% (163732/430954)
Region Coverage	32.37% (124821/385552)
Branch Coverage	33.74% (54571/161735)

hello-stephen · 2025-10-28T13:28:56Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (4/4) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	71.38% (23934/33529)
Line Coverage	57.79% (248922/430755)
Region Coverage	52.80% (206068/390267)
Branch Coverage	54.55% (88650/162508)

zclllyybb · 2025-10-28T13:52:33Z

run buildall

doris-robot · 2025-10-28T15:01:00Z

BE UT Coverage Report

Increment line coverage 100.00% (4/4) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	52.75% (18058/34231)
Line Coverage	37.99% (163730/431028)
Region Coverage	32.36% (124783/385654)
Branch Coverage	33.72% (54559/161777)

hello-stephen · 2025-10-28T16:50:55Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (4/4) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	71.38% (23937/33536)
Line Coverage	57.81% (249074/430836)
Region Coverage	52.99% (206872/390419)
Branch Coverage	54.67% (88867/162560)

zclllyybb · 2025-10-29T02:44:28Z

run performance

github-actions · 2025-10-29T03:33:05Z

PR approved by anyone and no changes requested.

github-actions · 2025-10-29T03:43:09Z

PR approved by at least one committer and no changes requested.

doris-robot · 2025-10-29T04:17:06Z

ClickBench: Total hot run time: 28.03 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ee92dc1d563f74f4f7b6c8a59e9d77b0fe59ec68, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.06	0.05
query3	0.26	0.09	0.09
query4	1.60	0.12	0.12
query5	0.28	0.26	0.26
query6	1.18	0.67	0.64
query7	0.03	0.03	0.02
query8	0.05	0.04	0.04
query9	0.64	0.54	0.52
query10	0.57	0.58	0.57
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.62	0.61	0.60
query14	1.02	1.05	1.03
query15	0.87	0.84	0.87
query16	0.39	0.39	0.40
query17	1.06	1.07	1.07
query18	0.22	0.21	0.21
query19	1.93	1.82	1.83
query20	0.02	0.01	0.01
query21	15.47	0.20	0.14
query22	5.08	0.07	0.05
query23	15.66	0.27	0.10
query24	2.81	0.59	0.78
query25	0.08	0.06	0.06
query26	0.15	0.14	0.12
query27	0.07	0.06	0.06
query28	5.01	1.16	0.94
query29	12.58	4.05	3.37
query30	0.29	0.13	0.11
query31	2.82	0.61	0.38
query32	3.24	0.55	0.47
query33	3.05	3.05	3.04
query34	15.81	5.18	4.54
query35	4.61	4.63	4.63
query36	0.69	0.51	0.50
query37	0.10	0.07	0.07
query38	0.07	0.05	0.04
query39	0.04	0.03	0.03
query40	0.17	0.15	0.14
query41	0.09	0.04	0.03
query42	0.04	0.04	0.03
query43	0.04	0.04	0.03
Total cold run time: 99.18 s
Total hot run time: 28.03 s

…ne convert (#57422) before: ```sql mysql> select cast('9999-12-31 23:59:59.999999 +00:00' as datetime(6)); +----------------------------------------------------------+ | cast('9999-12-31 23:59:59.999999 +00:00' as datetime(6)) | +----------------------------------------------------------+ | | +----------------------------------------------------------+ ``` now: ```sql mysql> select cast('9999-12-31 23:59:59.999999 +00:00' as datetime(6)); +----------------------------------------------------------+ | cast('9999-12-31 23:59:59.999999 +00:00' as datetime(6)) | +----------------------------------------------------------+ | NULL | +----------------------------------------------------------+ ```

…about timezone convert #57422 (#57442) Cherry-picked from #57422 Co-authored-by: zclllyybb <zhaochangle@selectdb.com>

…ne convert (apache#57422) before: ```sql mysql> select cast('9999-12-31 23:59:59.999999 +00:00' as datetime(6)); +----------------------------------------------------------+ | cast('9999-12-31 23:59:59.999999 +00:00' as datetime(6)) | +----------------------------------------------------------+ | | +----------------------------------------------------------+ ``` now: ```sql mysql> select cast('9999-12-31 23:59:59.999999 +00:00' as datetime(6)); +----------------------------------------------------------+ | cast('9999-12-31 23:59:59.999999 +00:00' as datetime(6)) | +----------------------------------------------------------+ | NULL | +----------------------------------------------------------+ ```

zclllyybb added the dev/4.0.x label Oct 28, 2025

1

ee92dc1

zclllyybb force-pushed the datetime_overflow branch from 87ae4cf to ee92dc1 Compare October 28, 2025 13:51

Mryange approved these changes Oct 29, 2025

View reviewed changes

github-actions bot added the reviewed label Oct 29, 2025

BiteTheDDDDt approved these changes Oct 29, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 29, 2025

zclllyybb merged commit 412efb1 into apache:master Oct 29, 2025
27 of 28 checks passed

zclllyybb deleted the datetime_overflow branch October 29, 2025 04:22

github-actions bot mentioned this pull request Oct 29, 2025

branch-4.0: [Fix](cast) Fix wrong corner case of datetime conversion about timezone convert #57422 #57442

Merged

yiguolei pushed a commit that referenced this pull request Oct 30, 2025

branch-4.0: [Fix](cast) Fix wrong corner case of datetime conversion …

bfae221

…about timezone convert #57422 (#57442) Cherry-picked from #57422 Co-authored-by: zclllyybb <zhaochangle@selectdb.com>

yiguolei added dev/4.0.1-merged and removed dev/4.0.x labels Oct 30, 2025

yiguolei mentioned this pull request Nov 5, 2025

4.0.1 Release Notes #57717

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fix](cast) Fix wrong corner case of datetime conversion about timezone convert#57422