Skip to content

[opt](partition) remove castTo in PartitionKey comparison#57518

Merged
morrySnow merged 1 commit intoapache:masterfrom
morrySnow:remove_partition_key_cast
Oct 31, 2025
Merged

[opt](partition) remove castTo in PartitionKey comparison#57518
morrySnow merged 1 commit intoapache:masterfrom
morrySnow:remove_partition_key_cast

Conversation

@morrySnow
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

ClickBench: Total hot run time: 29.13 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 126746ac6786d67ccd715a6eaa7a81d545178361, data reload: false

query1	0.07	0.06	0.05
query2	0.10	0.06	0.06
query3	0.26	0.10	0.11
query4	1.62	0.13	0.12
query5	0.31	0.29	0.27
query6	1.19	0.70	0.68
query7	0.04	0.04	0.03
query8	0.06	0.05	0.05
query9	0.66	0.57	0.57
query10	0.63	0.62	0.63
query11	0.18	0.13	0.13
query12	0.17	0.14	0.17
query13	0.64	0.64	0.61
query14	1.04	1.04	1.03
query15	0.91	0.90	0.90
query16	0.42	0.41	0.43
query17	1.16	1.25	1.15
query18	0.24	0.23	0.22
query19	2.00	1.91	1.87
query20	0.02	0.02	0.02
query21	15.50	0.22	0.15
query22	5.07	0.08	0.06
query23	15.67	0.32	0.12
query24	3.16	0.64	0.39
query25	0.09	0.07	0.07
query26	0.16	0.16	0.18
query27	0.08	0.07	0.06
query28	4.05	1.22	0.95
query29	12.63	4.71	3.86
query30	0.31	0.15	0.12
query31	2.85	0.64	0.42
query32	3.23	0.60	0.51
query33	3.20	3.24	3.08
query34	15.91	5.23	4.60
query35	4.67	4.67	4.61
query36	0.70	0.56	0.53
query37	0.12	0.08	0.08
query38	0.07	0.04	0.04
query39	0.04	0.04	0.03
query40	0.20	0.15	0.16
query41	0.09	0.04	0.03
query42	0.04	0.04	0.04
query43	0.05	0.04	0.04
Total cold run time: 99.61 s
Total hot run time: 29.13 s

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

1 similar comment
@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 31, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 1147613 into apache:master Oct 31, 2025
29 of 30 checks passed
@morrySnow morrySnow deleted the remove_partition_key_cast branch October 31, 2025 03:03
dwdwqfwe pushed a commit to dwdwqfwe/doris that referenced this pull request Oct 31, 2025
yiguolei pushed a commit that referenced this pull request Nov 5, 2025
…57518 (#57547)

Cherry-picked from #57518

Co-authored-by: morrySnow <zhangwenxin@selectdb.com>
@yiguolei yiguolei mentioned this pull request Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.1-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants