[Config] Add alter table, broker load, stream load, truncate table disable co…#5752
Closed
xinghuayu007 wants to merge 1 commit intoapache:masterfrom
Closed
[Config] Add alter table, broker load, stream load, truncate table disable co…#5752xinghuayu007 wants to merge 1 commit intoapache:masterfrom
xinghuayu007 wants to merge 1 commit intoapache:masterfrom
Conversation
morningman
reviewed
May 6, 2021
| public static boolean disable_truncate_table = false; | ||
|
|
||
| @ConfField(mutable = true) | ||
| public static boolean disable_stream_load = false; |
Contributor
There was a problem hiding this comment.
I think we can create an array config to do this.
Contributor
Author
There was a problem hiding this comment.
Good idea. Array config is easy to be extended and can reduce too much configs.
xinghuayu007
force-pushed
the
switch_for_alter_load_truncate
branch
from
583d86b to
321b479
Compare
morningman
reviewed
May 10, 2021
| * It can be extended to add more disable operations | ||
| */ | ||
| @ConfField(mutable = true, comment = "disable_alter_table, disable_broker_load, disable_truncate_table, disable_stream_load") | ||
| public static boolean[] disable_config = new boolean[4]; |
Contributor
There was a problem hiding this comment.
why not using string array to make it more readable?
Contributor
Author
There was a problem hiding this comment.
It has been modified to string array.
xinghuayu007
force-pushed
the
switch_for_alter_load_truncate
branch
2 times, most recently
from
b03e926 to
401cc1a
Compare
xinghuayu007
force-pushed
the
switch_for_alter_load_truncate
branch
from
401cc1a to
a511e22
Compare
yiguolei
pushed a commit
to yiguolei/incubator-doris
that referenced
this pull request
Dec 30, 2025
… requires all window expressions are in the same order apache#56622 (apache#5752) cherry-picks from apache#56622 Related to apache#5098 Co-authored-by: minghong <zhouminghong@selectdb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
When the Doris system is on OOM continuly caused by stream load/broker load, we has no method to handle stream load /broker load. Therefore, this PR add four configs to have a influnce on stream load, broker load, truncate table, alter table.
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...