[feature](function) Support interval function#57569
Open
dwdwqfwe wants to merge 4 commits intoapache:masterfrom
Open
[feature](function) Support interval function#57569dwdwqfwe wants to merge 4 commits intoapache:masterfrom
dwdwqfwe wants to merge 4 commits intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
dwdwqfwe
requested review from
CalvinKirs,
dataroaring,
gavinchou,
morningman and
w41ter
as code owners
Contributor
Author
|
run buildall |
TPC-DS: Total hot run time: 190260 ms |
ClickBench: Total hot run time: 27.61 s |
Contributor
Author
|
run feut |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
Author
|
run external |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE Regression Coverage ReportIncrement line coverage |
zclllyybb
reviewed
Nov 1, 2025
| size_t right = num_thresholds; | ||
| size_t result_idx = num_thresholds; | ||
|
|
||
| while (left < right) { |
Contributor
There was a problem hiding this comment.
why not use std::upper_bound?
| scalar(Unhex.class, "unhex"), | ||
| scalar(UnhexNull.class, "unhex_null"), | ||
| scalar(Uncompress.class, "uncompress"), | ||
| scalar(UnhexNull.class, "unhex_null"), |
| String get_name() const override { return name; } | ||
| bool is_variadic() const override { return true; } | ||
| size_t get_number_of_arguments() const override { return 0; } | ||
| bool use_default_implementation_for_nulls() const override { return true; } |
Contributor
There was a problem hiding this comment.
default value is already true
| Status execute_impl(FunctionContext* /*context*/, Block& block, const ColumnNumbers& arguments, | ||
| uint32_t result, size_t input_rows_count) const override { | ||
| if (arguments.size() < 2) { | ||
| return Status::InvalidArgument("interval requires at least 2 arguments"); |
Contributor
There was a problem hiding this comment.
should make sure it's checked in FE. add [[unlikely]] and return InternalError
| WHERE id <= 7 | ||
| ORDER BY id; | ||
| """ | ||
|
|
Contributor
There was a problem hiding this comment.
add test which some of thresholds are const
| res_data); | ||
| break; | ||
| default: | ||
| return Status::InvalidArgument( |
| auto compare_cwn = block.get_by_position(arguments[0]); | ||
| auto compare_col_ptr = compare_cwn.column; | ||
| bool compare_is_const = false; | ||
| std::tie(compare_col_ptr, compare_is_const) = unpack_if_const(compare_col_ptr); |
Contributor
There was a problem hiding this comment.
use default_preprocess_parameter_columns here is more proper
Contributor
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
TPC-DS: Total hot run time: 189552 ms |
ClickBench: Total hot run time: 27.63 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run cloud_p0 |
Contributor
Author
|
run nonConcurrent |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run nonConcurrent |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE Regression Coverage ReportIncrement line coverage |
zclllyybb
requested changes
Nov 5, 2025
| ColumnPtr compare_col_ptr = ColumnPtr {}; | ||
| bool compare_is_const = false; | ||
| compare_is_const = is_column_const(*block.get_by_position(arguments[0]).column); | ||
| default_preprocess_parameter_columns(&compare_col_ptr, &compare_is_const, {0}, block, |
Contributor
There was a problem hiding this comment.
default_preprocess_parameter_columns should process parameter columns, that is, column 1 .. n-1
|
|
||
| switch (compare_cwn.type->get_primitive_type()) { | ||
| case PrimitiveType::TYPE_TINYINT: | ||
| compute_interval<ColumnInt8>(block, arguments, *compare_col_ptr, compare_is_const, |
Contributor
There was a problem hiding this comment.
then, you can reference FunctionMonthsBetween, there's 3 possibility: data const, parameters all const, non const
16 tasks
zclllyybb
pushed a commit
that referenced
this pull request
Jan 7, 2026
… process (#58885) Related PR: #57569 Problem Summary: fix the wrong useage of function `default_preprocess_parameter_columns`, the variable `all_const` should not be affected by manually handled columns. ### Release note doc: apache/doris-website#3176 The INTERVAL function uses binary search to return the index of the first threshold strictly greater than N. ```sql SELECT INTERVAL(0, 1, 10, 100); +--------------------------+ | INTERVAL(0, 1, 10, 100) | +--------------------------+ | 0 | +--------------------------+ SELECT INTERVAL(10, 1, 10, 100, 1000); +-----------------------------------+ | INTERVAL(10, 1, 10, 100, 1000) | +-----------------------------------+ | 2 | +-----------------------------------+ -- First parameter is NULL SELECT INTERVAL(NULL, 1, 10, 100); +----------------------------+ | INTERVAL(NULL, 1, 10, 100) | +----------------------------+ | -1 | +----------------------------+ -- Subsequent parameters are NULL, treated as 0 SELECT INTERVAL(3, -1, NULL, 2, 3, 4); +--------------------------------+ | INTERVAL(3, -1, NULL, 2, 3, 4) | +--------------------------------+ | 4 | +--------------------------------+ ``` Co-authored-by: jianhao <1367919489@qq.com>
github-actions bot
pushed a commit
that referenced
this pull request
Jan 7, 2026
… process (#58885) Related PR: #57569 Problem Summary: fix the wrong useage of function `default_preprocess_parameter_columns`, the variable `all_const` should not be affected by manually handled columns. ### Release note doc: apache/doris-website#3176 The INTERVAL function uses binary search to return the index of the first threshold strictly greater than N. ```sql SELECT INTERVAL(0, 1, 10, 100); +--------------------------+ | INTERVAL(0, 1, 10, 100) | +--------------------------+ | 0 | +--------------------------+ SELECT INTERVAL(10, 1, 10, 100, 1000); +-----------------------------------+ | INTERVAL(10, 1, 10, 100, 1000) | +-----------------------------------+ | 2 | +-----------------------------------+ -- First parameter is NULL SELECT INTERVAL(NULL, 1, 10, 100); +----------------------------+ | INTERVAL(NULL, 1, 10, 100) | +----------------------------+ | -1 | +----------------------------+ -- Subsequent parameters are NULL, treated as 0 SELECT INTERVAL(3, -1, NULL, 2, 3, 4); +--------------------------------+ | INTERVAL(3, -1, NULL, 2, 3, 4) | +--------------------------------+ | 4 | +--------------------------------+ ``` Co-authored-by: jianhao <1367919489@qq.com>
zzzxl1993
pushed a commit
to zzzxl1993/doris
that referenced
this pull request
Jan 13, 2026
… process (apache#58885) Related PR: apache#57569 Problem Summary: fix the wrong useage of function `default_preprocess_parameter_columns`, the variable `all_const` should not be affected by manually handled columns. ### Release note doc: apache/doris-website#3176 The INTERVAL function uses binary search to return the index of the first threshold strictly greater than N. ```sql SELECT INTERVAL(0, 1, 10, 100); +--------------------------+ | INTERVAL(0, 1, 10, 100) | +--------------------------+ | 0 | +--------------------------+ SELECT INTERVAL(10, 1, 10, 100, 1000); +-----------------------------------+ | INTERVAL(10, 1, 10, 100, 1000) | +-----------------------------------+ | 2 | +-----------------------------------+ -- First parameter is NULL SELECT INTERVAL(NULL, 1, 10, 100); +----------------------------+ | INTERVAL(NULL, 1, 10, 100) | +----------------------------+ | -1 | +----------------------------+ -- Subsequent parameters are NULL, treated as 0 SELECT INTERVAL(3, -1, NULL, 2, 3, 4); +--------------------------------+ | INTERVAL(3, -1, NULL, 2, 3, 4) | +--------------------------------+ | 4 | +--------------------------------+ ``` Co-authored-by: jianhao <1367919489@qq.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
https://github.com/apache/doris-website/pull/3032/files
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)