branch-3.1: [fix](catalog) Prevent removing catalog from refresh queue on CREATE/ALTER#57671
Merged
zy-kkk merged 3 commits intoapache:branch-3.1from Nov 5, 2025
Merged
branch-3.1: [fix](catalog) Prevent removing catalog from refresh queue on CREATE/ALTER#57671zy-kkk merged 3 commits intoapache:branch-3.1from
zy-kkk merged 3 commits intoapache:branch-3.1from
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
5404780 to
40d6b4f
Compare
Member
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
Member
Author
|
run buildall |
Member
Author
|
run buildall |
morrySnow
approved these changes
Nov 5, 2025
Hastyshell
pushed a commit
to Hastyshell/doris
that referenced
this pull request
Nov 12, 2025
…e on CREATE/ALTER (apache#5529) pick apache#57671
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Summary:
catalogs are incorrectly removed from the auto-refresh queue when:
metadata_refresh_interval_secALTER CATALOG SET PROPERTIESThis causes auto-refresh to stop working even though
metadata_refresh_interval_secis configured.Root Cause:
CREATE/ALTER CATALOG
→ resetToUninitialized()
→ onClose()
→ CatalogIf.super.onClose()
→ removeFromRefreshMap(catalogId) ❌ Wrong!
Fix:
CatalogIf.super.onClose()call fromExternalCatalog.onClose()removeFromRefreshMap()inCatalogMgr.removeCatalog()Related: #57680