Skip to content

branch-3.1: [fix](csv reader) fix wrong result when escape same as enclose #57632#57762

Merged
morrySnow merged 1 commit intobranch-3.1from
auto-pick-57632-branch-3.1
Nov 7, 2025
Merged

branch-3.1: [fix](csv reader) fix wrong result when escape same as enclose #57632#57762
morrySnow merged 1 commit intobranch-3.1from
auto-pick-57632-branch-3.1

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 6, 2025

Cherry-picked from #57632

### What problem does this PR solve?

Fix wrong result when escape same as enclose, introduced by
#50101

data:
```
50,"{""a"": 1}"
60,"{""a"": 2}"
```

query
```
select * from local( "backend_id" = "1760087225568", "file_path" = "test.csv", "format" = "csv", "column_separator" = ",", "enclose" = "\"", "escape" = "\""
```

expectation:
```
+------+------------+
| k1   | k2         |
+------+------------+
|   50 | {"a": 1} |
|   60 | {"a": 2} |
+------+------------+
```

real:
```
+------+------------------------+
| k1   | k2                     |
+------+------------------------+
|   50 | {"a": 1}
60,{"a": 2}

 |
+------+------------------------+
```
@github-actions github-actions bot requested a review from morrySnow as a code owner November 6, 2025 09:44
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Nov 6, 2025
@dataroaring dataroaring reopened this Nov 6, 2025
@hello-stephen
Copy link
Contributor

run buildall

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.90% (12943/28200)
Line Coverage 36.74% (115728/315029)
Region Coverage 34.24% (65988/192716)
Branch Coverage 31.26% (34655/110870)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.42% (21230/27781)
Line Coverage 69.70% (219519/314932)
Region Coverage 67.64% (131049/193750)
Branch Coverage 61.32% (68354/111468)

@morrySnow morrySnow merged commit 72c4294 into branch-3.1 Nov 7, 2025
22 of 23 checks passed
@github-actions github-actions bot deleted the auto-pick-57632-branch-3.1 branch November 7, 2025 05:05
@morrySnow morrySnow mentioned this pull request Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants