Skip to content

branch-4.0: [improve](ann index)Accumulate multiple small batches before training #57623#57932

Merged
yiguolei merged 1 commit intoapache:branch-4.0from
zhiqiang-hhhh:pick_57623_to_upstream_branch-4.0
Nov 12, 2025
Merged

branch-4.0: [improve](ann index)Accumulate multiple small batches before training #57623#57932
yiguolei merged 1 commit intoapache:branch-4.0from
zhiqiang-hhhh:pick_57623_to_upstream_branch-4.0

Conversation

@zhiqiang-hhhh
Copy link
Contributor

@zhiqiang-hhhh zhiqiang-hhhh commented Nov 12, 2025

cherry pick from #57623

@zhiqiang-hhhh
Copy link
Contributor Author

zhiqiang-hhhh commented Nov 12, 2025

run buildall

@Thearas
Copy link
Contributor

Thearas commented Nov 12, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@uchenily @zhiqiang-hhhh
[improve](ann index)Accumulate multiple small batches before training (…
13a64a6 
…apache#57623)

Accumulate multiple small batches to avoid the following error when
training:
`Error: 'nx >= k' failed: Number of training points should be at least
as large as number of clusters`,
and significantly reduce the time for faiss train/add.
@zhiqiang-hhhh zhiqiang-hhhh force-pushed the pick_57623_to_upstream_branch-4.0 branch from cf8fdfb to 13a64a6 Compare November 12, 2025 08:57
@zhiqiang-hhhh
Copy link
Contributor Author

zhiqiang-hhhh commented Nov 12, 2025

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 12, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 4142dc7 into apache:branch-4.0 Nov 12, 2025
23 of 26 checks passed
@zhiqiang-hhhh zhiqiang-hhhh deleted the pick_57623_to_upstream_branch-4.0 branch November 13, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhiqiang-hhhh @Thearas @yiguolei @uchenily

Comments