[fix](window) allow constant expression evaluation in LAG/LEAD offset parameter#58200
Merged
morningman merged 2 commits intoapache:masterfrom Nov 23, 2025
Merged
[fix](window) allow constant expression evaluation in LAG/LEAD offset parameter#58200morningman merged 2 commits intoapache:masterfrom
morningman merged 2 commits intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
zhangstar333
changed the title
TPC-H: Total hot run time: 33946 ms |
TPC-DS: Total hot run time: 187716 ms |
ClickBench: Total hot run time: 27.62 s |
Contributor
Author
|
run buildall |
morrySnow
changed the title
morrySnow
approved these changes
Nov 21, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 35670 ms |
TPC-DS: Total hot run time: 187451 ms |
ClickBench: Total hot run time: 27.38 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 35144 ms |
TPC-DS: Total hot run time: 188230 ms |
ClickBench: Total hot run time: 27.73 s |
Contributor
FE Regression Coverage ReportIncrement line coverage |
2 similar comments
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
FE UT Coverage ReportIncrement line coverage |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 23, 2025
… parameter (#58200) ### What problem does this PR solve? Problem Summary: ``` mysql> select lag(k1,1+1,6) over() from test_query_qa.baseall; ERROR 1105 (HY000): errCode = 2, detailMessage = The offset parameter of LAG must be a constant positive integer: lag(k1, (1 + 1), 6) mysql> ``` before the function second param of offset must be a constant value. but 1 + 1 also should be support in offset params. ``` mysql> select lag(k1,1+1,6) over() from test_query_qa.baseall where k1 <= 3; +----------------------+ | lag(k1,1+1,6) over() | +----------------------+ | 6 | | 6 | | 3 | +----------------------+ ```
nagisa-kunhah
pushed a commit
to nagisa-kunhah/doris
that referenced
this pull request
Dec 14, 2025
… parameter (apache#58200) ### What problem does this PR solve? Problem Summary: ``` mysql> select lag(k1,1+1,6) over() from test_query_qa.baseall; ERROR 1105 (HY000): errCode = 2, detailMessage = The offset parameter of LAG must be a constant positive integer: lag(k1, (1 + 1), 6) mysql> ``` before the function second param of offset must be a constant value. but 1 + 1 also should be support in offset params. ``` mysql> select lag(k1,1+1,6) over() from test_query_qa.baseall where k1 <= 3; +----------------------+ | lag(k1,1+1,6) over() | +----------------------+ | 6 | | 6 | | 3 | +----------------------+ ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
before the function second param of offset must be a constant value.
but 1 + 1 also should be support in offset params.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)