[fix](delete) Fix missing prepare_rowset for delete job#59089
Merged
dataroaring merged 1 commit intoapache:masterfrom Dec 16, 2025
Merged
[fix](delete) Fix missing prepare_rowset for delete job#59089dataroaring merged 1 commit intoapache:masterfrom
prepare_rowset for delete job#59089dataroaring merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
gavinchou
reviewed
Dec 16, 2025
prepare_rowset for delete jobprepare_rowset for delete job
8e06b21 to
9cdfbca
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 35506 ms |
TPC-DS: Total hot run time: 179602 ms |
ClickBench: Total hot run time: 27.53 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
gavinchou
approved these changes
Dec 16, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Hastyshell
approved these changes
Dec 16, 2025
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
github-actions bot
pushed a commit
that referenced
this pull request
Dec 16, 2025
load, compaction, schema change use workflow with `prepare_rowset` -> `commit_rowset` delete job needs to be consistent even though the `delete` can work without prepare rowset
github-actions bot
pushed a commit
that referenced
this pull request
Dec 16, 2025
load, compaction, schema change use workflow with `prepare_rowset` -> `commit_rowset` delete job needs to be consistent even though the `delete` can work without prepare rowset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
load, compaction, schema change
use workflow with
prepare_rowset->commit_rowsetdelete job needs to be consistent even though the
deletecan work without prepare rowset