[BUG] Fix parse error when the memory parameter is a float value percentage#5916
Merged
morningman merged 1 commit intoapache:masterfrom May 27, 2021
Merged
Conversation
xinyiZzz
changed the title
xinyiZzz
force-pushed
the
conf_storage_page_cache_limit_error
branch
from
931b854 to
22c0798
Compare
morningman
added
approved
stdpain
pushed a commit
to stdpain/incubator-doris
that referenced
this pull request
Jul 8, 2021
…e percentage (apache#5916) When parsing memory parameters in `ParseUtil::parse_mem_spec`, convert the percentage to `double` instead of `int`. The currently affected parameters include `mem_limit` and `storage_page_cache_limit`
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jan 30, 2026
…#58317) (apache#5916) pick doris master apache#58317 --------- Co-authored-by: Jack <jiangkai@selectdb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
When parsing memory parameters in
ParseUtil::parse_mem_spec, convert the percentage todoubleinstead ofint.The currently affected parameters include
mem_limitandstorage_page_cache_limitTypes of changes
Checklist
storage_page_cache_limitwill cause the page_cache capacity calculation result to be wrong #5818) and described the bug/feature there in detail