[Fix](StreamingJob) fix create table issues when create streaming job#59828
Merged
JNSimba merged 5 commits intoapache:masterfrom Jan 14, 2026
Merged
[Fix](StreamingJob) fix create table issues when create streaming job#59828JNSimba merged 5 commits intoapache:masterfrom
JNSimba merged 5 commits intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
TPC-H: Total hot run time: 31878 ms |
TPC-DS: Total hot run time: 175143 ms |
There was a problem hiding this comment.
Pull request overview
This PR fixes three issues when creating tables for streaming jobs:
- VARCHAR column lengths are now multiplied by 3 to accommodate multi-byte character encodings
- Columns are reordered to place primary key columns first, in the order specified
- Unsupported column types now trigger an error with a clear message
Changes:
- Enhanced
getColumnsmethod to multiply varchar lengths by 3, validate against unsupported types, and sort columns by primary key order - Added comprehensive unit tests covering varchar conversion, primary key sorting, and edge cases
- Updated regression test to verify varchar length multiplication (200 * 3 = 600)
- Added logging and toString support for commit offset operations
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| fe/fe-core/src/main/java/org/apache/doris/job/util/StreamingJobUtils.java | Core logic changes: varchar length multiplication by 3, unsupported type validation, and primary key-based column sorting |
| fe/fe-core/src/test/java/org/apache/doris/job/util/StreamingJobUtilsTest.java | New comprehensive unit tests for getColumns method covering varchar conversion, primary key sorting, and edge cases |
| regression-test/suites/job_p0/streaming_job/cdc/test_streaming_mysql_job.groovy | Updated assertion to verify varchar(200) becomes varchar(600), added table3 cleanup |
| fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/StreamingJobAction.java | Added logging for offset commits and @tostring annotation for better debugging |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fe/fe-core/src/test/java/org/apache/doris/job/util/StreamingJobUtilsTest.java
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/StreamingJobAction.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/job/util/StreamingJobUtils.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/job/util/StreamingJobUtils.java
Show resolved
Hide resolved
fe/fe-core/src/test/java/org/apache/doris/job/util/StreamingJobUtilsTest.java
Show resolved
Hide resolved
fe/fe-core/src/test/java/org/apache/doris/job/util/StreamingJobUtilsTest.java
Show resolved
Hide resolved
Member
Author
|
run buildall |
Member
Author
|
run buildall |
TPC-H: Total hot run time: 31030 ms |
TPC-DS: Total hot run time: 173039 ms |
Member
Author
|
run buildall |
TPC-H: Total hot run time: 31423 ms |
TPC-DS: Total hot run time: 172158 ms |
Member
Author
|
run cloud_p0 |
Contributor
|
PR approved by anyone and no changes requested. |
CalvinKirs
approved these changes
Jan 14, 2026
Contributor
|
PR approved by at least one committer and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related PR: #58898
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)