[Bug] SimplifyInvalidDateBinaryPredicatesDateRule may cause invalid query plan#5987
Merged
morningman merged 3 commits intoapache:masterfrom Jun 10, 2021
Merged
Conversation
…uery plan 1. "where 1k > to_date(now())" will return EMPTYSET in query plan. 2. DateLiteral should accept date string like "2021-6-1".
morningman
added
kind/fix
Contributor
|
approved. I have tested function |
EmmyMiao87
reviewed
Jun 9, 2021
| // We have to handle the following cases: | ||
| // A. k1 is datetime, sql with "k1 > to_date(now())" will be converted to k1 > cast(to_date("xxxx-xx-xx")) | ||
| // B. k1 is datetime, sql with "k1 > '2021-10-32 10:00:00.100010'" will be converted to k1 > cast('2021-10-32 10:00:00.100010' as datetime) | ||
| // C. k1 is datetime, sql with "k1 > '2021-10-32'" will be converted to k1 > cast('2021-10-32' as datetime) |
Contributor
There was a problem hiding this comment.
converted to null literal
EmmyMiao87
pushed a commit
to EmmyMiao87/incubator-doris
that referenced
this pull request
Nov 10, 2021
…uery plan (apache#5987) 1. "where 1k > to_date(now())" will return EMPTYSET in query plan. 2. DateLiteral should accept date string like "2021-6-1".
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jan 30, 2026
…dynamic modification (apache#58198) (apache#5987) ### What problem does this PR solve? The fixed scheduling time requires a restart to modify. To change it, use the command admin set frontend config("cloud_tablet_rebalancer_interval_second"="3"); to apply the change without a restart. pick from apache/doris apache#58198
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...