feature(client): support go client for hugegraph#514
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #514 +/- ##
============================================
- Coverage 62.49% 62.46% -0.04%
+ Complexity 1903 1902 -1
============================================
Files 262 262
Lines 9541 9533 -8
Branches 886 886
============================================
- Hits 5963 5955 -8
Misses 3190 3190
Partials 388 388 ☔ View full report in Codecov by Sentry. |
|
Is it still in progress? |
|
In process |
Change-Id: Id3081dd2f4a467ca570d2fc1a1be9b263878fa86
Change-Id: I76510813ff0ad20342ee97c802818d8f85241d62
Change-Id: I0d42d75cc3ae3ece1d9555ae35b464a8ac03915a
Change-Id: I9e97edcf81e550f97dc311e799eaa28283aa0a8b
Change-Id: Ibf441c8812f5cdd0993ceb43c80c341febf91ea6
pom.xml
Outdated
| <description> | ||
| hugegraph-toolchain is the integration project of a series of utilities for HugeGraph, it includes 4 main modules (loader/hubble/tools/client) | ||
| hugegraph-toolchain is the integration project of a series of utilities for HugeGraph, it | ||
| includes 4 main modules (loader/hubble/tools/client) |
There was a problem hiding this comment.
seems don't need to wrap line
There was a problem hiding this comment.
seems don't need to wrap line
Too long to read & break the auto-format rule, if it doesn't affect the pom attribute of the function, it is better to wrap line by 100 characters rather than put them in a LONG line
There was a problem hiding this comment.
Go follows a convention where source files are all lower case with underscore separating multiple words. why not use api_response.go?other source files have the same question.
There was a problem hiding this comment.
Normally, in Go language, underline is used as the file separator. Here, because the API is a tree structure, English commas are used to distinguish between trees, and then underline is used for segmentation. For example: api.veretx.create.go and api.vertex.get_ by_id.go . The use of English commas and underscores is more conducive to presentation and layering.
There was a problem hiding this comment.
Normally, in Go language, underline is used as the file separator. Here, because the API is a tree structure, English commas are used to distinguish between trees, and then underline is used for segmentation. For example: api.veretx.create.go and api.vertex.get_ by_id.go . The use of English commas and underscores is more conducive to presentation and layering.
@izliang @hankwenyx
should we follow the example of other graph communities? like nebula community go's sdk, seems does not use this naming style:

how about the following style:
- main.go
- api/
- user/
- user.go
- product/
- product.go
- order/
- order.go
- user/
Change-Id: Icdbded4c1553f7f4e71f569a64bf64ae84da0c8d
Change-Id: Ib1be757f2b92d33598a64ee728c9db865e3bc902
Change-Id: If504a41bb219151d4627c8917a27f849412e9827
|
At present, it is necessary to explore implementation solutions for the design of file directories and responsibilities for various APIs. There are currently several design options available:
@zyxxoo @hankwenyx @javeme @coderzc @Radeity could choose one |
Good idea, Maybe I choose 3 =.=, this style like with java style |
I also think 3nd is better. |
Change-Id: I84c9e2c47d88e719c4dac58b050e9d770146be57
I am not familiar with the Go language, you can refer to zyxxoo and coderzc's suggestions. |
Change-Id: I18ee780a8c1ea385ded4b960e43d0f768d1258bd
Change-Id: I66bb1fd19deaf7e9ca27fe124461894b95cb798d
Change-Id: I9f7470fc1b09374193e917f4ebbc05dc2ba34611
|
need handle some CI problems: |
Change-Id: I3f4e8003ed4e905cf472080c837ac8f68bab76d2
Change-Id: I233a0ed114d8702ad0e9efcd85b058faa0ee6a35
Change-Id: Iedb5aa6977c2fbc8b021588f3662dd92d6ba527a
|
I think you can try something like this openapi generator. Other parts LGTM. |
Purpose of the PR
subtask of #512
Main Changes
Add Hugegraph-client for golang
Support REST API By This feature
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need