Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Conversation

@bartekkuncer
Copy link
Contributor

This change upgrades oneDNN used by mxnet to v2.0.

@mxnet-bot
Copy link

Hey @bartekkuncer , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-cpu, sanity, clang, centos-cpu, miscellaneous, website, unix-gpu, windows-cpu, centos-gpu, edge, windows-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 14, 2020
@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 14, 2020
@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [unix-gpu, centos-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu, centos-gpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 14, 2020
@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [centos-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 14, 2020
@bartekkuncer
Copy link
Contributor Author

@leezu @szha Please help with the merge. This change just upgrades oneDNN used by mxnet to v2.0.

@leezu leezu merged commit 05fb317 into apache:master Dec 15, 2020
@szha
Copy link
Member

szha commented Dec 15, 2020

@leezu how does it impact horovod integration?

@bartekkuncer bartekkuncer deleted the onednn20master branch December 16, 2020 07:10
@leezu
Copy link
Contributor

leezu commented Dec 17, 2020

It breaks it. @bartekkuncer can you look at updating MXNet/Horovod to work with oneDNN v2? See horovod/horovod#2530 for reference

@bartekkuncer
Copy link
Contributor Author

It breaks it. @bartekkuncer can you look at updating MXNet/Horovod to work with oneDNN v2? See horovod/horovod#2530 for reference

Sure, I will look into it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pr-awaiting-review PR is waiting for code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants