[type:optimize] Optimize LogCollectUtils#6191
Merged
Aias00 merged 4 commits intoapache:masterfrom Sep 28, 2025
Merged
Conversation
Aias00
reviewed
Sep 27, 2025
| public class LogCollectUtils { | ||
|
|
||
| private static final List<String> BINARY_TYPE_LIST = Arrays.asList("image", "multipart", "cbor", | ||
| private static final Set<String> BINARY_TYPE_LIST = Sets.newHashSet("image", "multipart", "cbor", |
Contributor
Author
There was a problem hiding this comment.
The Set data structure has a time complexity of O(1) for element lookup, while List has O(n). Since the code frequently checks whether contentType.getType() and contentType.getSubtype() exist in BINARY_TYPE_LIST, using Set can significantly improve performance.
Aias00
approved these changes
Sep 28, 2025
Contributor
|
hi, add my wechat pls: aias00 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize LogCollectUtils