[Request]: Use label instead of id to discriminate default network as a system resource.

[jglogan]

Feature or enhancement request details

Tasks

• Add role label of builtin when creating default network.
• Data migration - when loading networks at startup, test id id == ClientNetwork.defaultNetworkName and true and isUserResource is true, add label and rewrite entity back to the entity store.
• Replace all other id == ClientNetwork.defaultNetworkName checks with label test.

Code of Conduct

• I agree to follow this project's Code of Conduct

[jglogan]

Local tests

Apply builtin role label to default network at startup.

% cat ~/Library/Application\ Support/com.apple.container/networks/default/entity.json| jq
{
  "labels": {},
  "mode": "nat",
  "creationDate": 791413601.151796,
  "id": "default"
}

% container system start                                                                 
Warning! Running debug build. Performance may be degraded.
Verifying apiserver is running...

% cat ~/Library/Application\ Support/com.apple.container/networks/default/entity.json| jq
{
  "labels": {
    "com.apple.container.resource.role": "builtin"
  },
  "id": "default",
  "creationDate": 791413601.151796,
  "mode": "nat"
}

%

Prevent deletion of builtin network

% container network rm default
Warning! Running debug build. Performance may be degraded.
Error: invalidArgument: "cannot delete a builtin network: default"

%

Network prune

% container network create foo
Warning! Running debug build. Performance may be degraded.
foo

% container network prune
Warning! Running debug build. Performance may be degraded.
foo

%

Builder container role

% container builder start
Warning! Running debug build. Performance may be degraded.

% container inspect buildkit | jq '.[0].configuration.labels'
Warning! Running debug build. Performance may be degraded.
{
  "com.apple.container.resource.role": "builder"
}

%