Closed
Conversation
7 tasks
Contributor
|
@DePasqualeOrg see the comment I posted on #1138. Since we need both sets of fixes together to build correctly, @saehejkang will bring over the changes from this PR and add you as the co-author. Once we've got everything building correctly, we're merge that PR and close this PR. Thanks for helping tidy up the API! |
7 tasks
Contributor
|
Closed in favor of #1161 which credits both contributors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"clean up" is a verb, and "cleanup" is a noun. I've fixed function names and comments accordingly. I didn't mark the incorrect function name as deprecated, since deprecation notices are not desired in this related PR.
CI tests will fail until apple/containerization#507 is merged.