Merged
Conversation
jglogan
requested changes
Feb 2, 2026
| } | ||
| } | ||
|
|
||
| @available(*, deprecated, renamed: "cleanUpOrphanedBlobs") |
Contributor
There was a problem hiding this comment.
Could you remove the old function entirely, and update any call sites in containerization with the renamed function name? We're not at the point in this project where we're concerned about breaking the API (we will be getting there soon).
Contributor
Author
There was a problem hiding this comment.
Okay, I've done that.
Contributor
|
@DePasqualeOrg could you rebase your change onto current main and push again? That way you'll have #511 which will help ensure tests pass (not the fault of your changes). |
DePasqualeOrg
force-pushed
the
fix-cleanup-usage
branch
from
6c678a9 to
9c39d06
Compare
Contributor
Author
|
I've rebased on main. |
jglogan
approved these changes
Feb 4, 2026
Contributor
|
@DePasqualeOrg Thanks for the contribution, I'd like to get the registry API changes from @saehejkang in and then we'll bump the tag and then you can update your container PR to pick up the updated API. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"clean up" is a verb, and "cleanup" is a noun. There are several examples of the incorrect usage of "cleanup" as a verb in this repository, including one in the public API (
cleanupOrphanedBlobs). For this public method, I've added a deprecation notice to the name with the incorrect usage.