Use typesafe IP/CIDR parameters everywhere.#448
Merged
jglogan merged 4 commits intoapple:mainfrom Dec 16, 2025
Merged
Conversation
- Closes apple#445. - Refines IPv4 types, adds IPv6 types. - For type safety and clarity, use IP and CIDR types where we were previously using String. Co-authored-by: Agam Dua agamdua@users.noreply.github.com
jglogan
force-pushed
the
ip-typesafety
branch
from
24285ad to
28ca995
Compare
yibozhuang
reviewed
Dec 15, 2025
dcantah
approved these changes
Dec 15, 2025
Member
dcantah
left a comment
dcantah
left a comment
There was a problem hiding this comment.
I love this, LGTM! The only thing I even have feedback on is the placement of the new types. I honestly think czextras is probably a safe bet, but the types are very integral to this project now, so I was thinking maybe they might make sense in Containerization itself. Up to you
dcantah
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Agam Dua agamdua@users.noreply.github.com